* [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF
@ 2025-05-14 13:13 Alexander Stein
2025-05-14 13:13 ` [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled Alexander Stein
2025-05-20 21:40 ` [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Stein @ 2025-05-14 13:13 UTC (permalink / raw)
To: Dong Aisheng, Fabio Estevam, Shawn Guo, Jacky Bai,
Pengutronix Kernel Team, NXP S32 Linux Team, Linus Walleij
Cc: Alexander Stein, Esben Haabendal, linux-gpio, linux-kernel
Although the driver itself does not depend on OF itself, it selects
PINCTRL_IMX which depends on OF. So only select PINCTRL_IMX if OF is
already selected to ensure dependencies are met.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v3:
* New patch
This fixes the dependency issues found by the kernel testrobot.
PINCTRL_IMX_SCU selects PINCTRL_IMX unconditionally of OF which is a
hard dependency of the latter one.
Thake this into account.
drivers/pinctrl/freescale/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index 4c420b21b804d..d1610e2f21427 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -20,6 +20,7 @@ config PINCTRL_IMX_SCMI
config PINCTRL_IMX_SCU
tristate
+ depends on OF
depends on IMX_SCU || COMPILE_TEST
select PINCTRL_IMX
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled.
2025-05-14 13:13 [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF Alexander Stein
@ 2025-05-14 13:13 ` Alexander Stein
2025-05-19 6:55 ` Esben Haabendal
2025-05-20 21:40 ` [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Alexander Stein @ 2025-05-14 13:13 UTC (permalink / raw)
To: Dong Aisheng, Fabio Estevam, Shawn Guo, Jacky Bai,
Pengutronix Kernel Team, NXP S32 Linux Team, Linus Walleij
Cc: Alexander Stein, Esben Haabendal, linux-gpio, linux-kernel
The pinctrl drivers are not enabled in defconfig. Instead of listing
each driver in the defconfig, enable then by default if the platform/soc
support is enabled as well.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v3:
* None
Changes in v2:
* default pinctrl driver depending on SoC support
The discussion at [1] resulted it is better to default SoC-specific pinctrl
drivers to thei SoC support instead of adding to defconfig or selecting
pinctrl.
[1] https://lore.kernel.org/all/20250507124414.3088510-1-alexander.stein@ew.tq-group.com/
drivers/pinctrl/freescale/Kconfig | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index d1610e2f21427..8d24decd3f074 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -22,6 +22,7 @@ config PINCTRL_IMX_SCU
tristate
depends on OF
depends on IMX_SCU || COMPILE_TEST
+ default IMX_SCU
select PINCTRL_IMX
config PINCTRL_IMX1_CORE
@@ -160,6 +161,7 @@ config PINCTRL_IMX8MM
tristate "IMX8MM pinctrl driver"
depends on OF
depends on SOC_IMX8M || COMPILE_TEST
+ default SOC_IMX8M
select PINCTRL_IMX
help
Say Y here to enable the imx8mm pinctrl driver
@@ -168,6 +170,7 @@ config PINCTRL_IMX8MN
tristate "IMX8MN pinctrl driver"
depends on OF
depends on SOC_IMX8M || COMPILE_TEST
+ default SOC_IMX8M
select PINCTRL_IMX
help
Say Y here to enable the imx8mn pinctrl driver
@@ -176,6 +179,7 @@ config PINCTRL_IMX8MP
tristate "IMX8MP pinctrl driver"
depends on OF
depends on SOC_IMX8M || COMPILE_TEST
+ default SOC_IMX8M
select PINCTRL_IMX
help
Say Y here to enable the imx8mp pinctrl driver
@@ -184,6 +188,7 @@ config PINCTRL_IMX8MQ
tristate "IMX8MQ pinctrl driver"
depends on OF
depends on SOC_IMX8M || COMPILE_TEST
+ default SOC_IMX8M
select PINCTRL_IMX
help
Say Y here to enable the imx8mq pinctrl driver
@@ -192,6 +197,7 @@ config PINCTRL_IMX8QM
tristate "IMX8QM pinctrl driver"
depends on OF
depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
+ default ARCH_MXC
select PINCTRL_IMX_SCU
help
Say Y here to enable the imx8qm pinctrl driver
@@ -200,6 +206,7 @@ config PINCTRL_IMX8QXP
tristate "IMX8QXP pinctrl driver"
depends on OF
depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
+ default ARCH_MXC
select PINCTRL_IMX_SCU
help
Say Y here to enable the imx8qxp pinctrl driver
@@ -208,6 +215,7 @@ config PINCTRL_IMX8DXL
tristate "IMX8DXL pinctrl driver"
depends on OF
depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
+ default ARCH_MXC
select PINCTRL_IMX_SCU
help
Say Y here to enable the imx8dxl pinctrl driver
@@ -216,6 +224,7 @@ config PINCTRL_IMX8ULP
tristate "IMX8ULP pinctrl driver"
depends on OF
depends on ARCH_MXC || COMPILE_TEST
+ default ARCH_MXC
select PINCTRL_IMX
help
Say Y here to enable the imx8ulp pinctrl driver
@@ -240,6 +249,7 @@ config PINCTRL_IMX93
tristate "IMX93 pinctrl driver"
depends on OF
depends on ARCH_MXC || COMPILE_TEST
+ default SOC_IMX9
select PINCTRL_IMX
help
Say Y here to enable the imx93 pinctrl driver
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled.
2025-05-14 13:13 ` [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled Alexander Stein
@ 2025-05-19 6:55 ` Esben Haabendal
0 siblings, 0 replies; 4+ messages in thread
From: Esben Haabendal @ 2025-05-19 6:55 UTC (permalink / raw)
To: Alexander Stein
Cc: Dong Aisheng, Fabio Estevam, Shawn Guo, Jacky Bai,
Pengutronix Kernel Team, NXP S32 Linux Team, Linus Walleij,
linux-gpio, linux-kernel
"Alexander Stein" <alexander.stein@ew.tq-group.com> writes:
> The pinctrl drivers are not enabled in defconfig. Instead of listing
> each driver in the defconfig, enable then by default if the platform/soc
> support is enabled as well.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v3:
> * None
>
> Changes in v2:
> * default pinctrl driver depending on SoC support
>
> The discussion at [1] resulted it is better to default SoC-specific pinctrl
> drivers to thei SoC support instead of adding to defconfig or selecting
> pinctrl.
>
> [1] https://lore.kernel.org/all/20250507124414.3088510-1-alexander.stein@ew.tq-group.com/
>
> drivers/pinctrl/freescale/Kconfig | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index d1610e2f21427..8d24decd3f074 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -22,6 +22,7 @@ config PINCTRL_IMX_SCU
> tristate
> depends on OF
> depends on IMX_SCU || COMPILE_TEST
> + default IMX_SCU
> select PINCTRL_IMX
>
> config PINCTRL_IMX1_CORE
> @@ -160,6 +161,7 @@ config PINCTRL_IMX8MM
> tristate "IMX8MM pinctrl driver"
> depends on OF
> depends on SOC_IMX8M || COMPILE_TEST
> + default SOC_IMX8M
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8mm pinctrl driver
> @@ -168,6 +170,7 @@ config PINCTRL_IMX8MN
> tristate "IMX8MN pinctrl driver"
> depends on OF
> depends on SOC_IMX8M || COMPILE_TEST
> + default SOC_IMX8M
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8mn pinctrl driver
> @@ -176,6 +179,7 @@ config PINCTRL_IMX8MP
> tristate "IMX8MP pinctrl driver"
> depends on OF
> depends on SOC_IMX8M || COMPILE_TEST
> + default SOC_IMX8M
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8mp pinctrl driver
> @@ -184,6 +188,7 @@ config PINCTRL_IMX8MQ
> tristate "IMX8MQ pinctrl driver"
> depends on OF
> depends on SOC_IMX8M || COMPILE_TEST
> + default SOC_IMX8M
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8mq pinctrl driver
> @@ -192,6 +197,7 @@ config PINCTRL_IMX8QM
> tristate "IMX8QM pinctrl driver"
> depends on OF
> depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> + default ARCH_MXC
> select PINCTRL_IMX_SCU
> help
> Say Y here to enable the imx8qm pinctrl driver
> @@ -200,6 +206,7 @@ config PINCTRL_IMX8QXP
> tristate "IMX8QXP pinctrl driver"
> depends on OF
> depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> + default ARCH_MXC
> select PINCTRL_IMX_SCU
> help
> Say Y here to enable the imx8qxp pinctrl driver
> @@ -208,6 +215,7 @@ config PINCTRL_IMX8DXL
> tristate "IMX8DXL pinctrl driver"
> depends on OF
> depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> + default ARCH_MXC
> select PINCTRL_IMX_SCU
> help
> Say Y here to enable the imx8dxl pinctrl driver
> @@ -216,6 +224,7 @@ config PINCTRL_IMX8ULP
> tristate "IMX8ULP pinctrl driver"
> depends on OF
> depends on ARCH_MXC || COMPILE_TEST
> + default ARCH_MXC
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8ulp pinctrl driver
> @@ -240,6 +249,7 @@ config PINCTRL_IMX93
> tristate "IMX93 pinctrl driver"
> depends on OF
> depends on ARCH_MXC || COMPILE_TEST
> + default SOC_IMX9
> select PINCTRL_IMX
> help
> Say Y here to enable the imx93 pinctrl driver
> --
> 2.43.0
Acked-by: Esben Haabendal <esben@geanix.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF
2025-05-14 13:13 [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF Alexander Stein
2025-05-14 13:13 ` [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled Alexander Stein
@ 2025-05-20 21:40 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2025-05-20 21:40 UTC (permalink / raw)
To: Alexander Stein
Cc: Dong Aisheng, Fabio Estevam, Shawn Guo, Jacky Bai,
Pengutronix Kernel Team, NXP S32 Linux Team, Esben Haabendal,
linux-gpio, linux-kernel
On Wed, May 14, 2025 at 3:13 PM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
> Although the driver itself does not depend on OF itself, it selects
> PINCTRL_IMX which depends on OF. So only select PINCTRL_IMX if OF is
> already selected to ensure dependencies are met.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Both patches applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-20 21:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-14 13:13 [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF Alexander Stein
2025-05-14 13:13 ` [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled Alexander Stein
2025-05-19 6:55 ` Esben Haabendal
2025-05-20 21:40 ` [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.