All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Steam Lin <STLin2@winbond.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mtd: spi-nor: winbond: Add support for w25q02jv
Date: Fri, 10 Jan 2025 15:46:32 +0100	[thread overview]
Message-ID: <87cyguafqv.fsf@bootlin.com> (raw)
In-Reply-To: <956f0490-2e47-4655-ab10-a10ef790cfad@wanadoo.fr> (Christophe JAILLET's message of "Thu, 9 Jan 2025 21:23:13 +0100")

Hi Christophe,

On 09/01/2025 at 21:23:13 +01, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> Le 09/01/2025 à 21:17, Miquel Raynal a écrit :
>> Add support for Winbond w25q02jv spi-nor chip which shares most of
>> w25q01jv's specificities as, this time, the chip is made of 4 different
>> dies.
>> Link:
>> https://www.winbond.com/resource-files/W25Q02JV_DTR%20RevD%2007092024%20Plus.pdf
>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> ---
>
> ...
>
>> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
>> index a4c0d99dde4fcd2b123eb7ded4f7822110c6a4ae..d82962e0bf7d8e00b305fd838274a58c34dd6c4e 100644
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -305,6 +305,10 @@ static const struct flash_info winbond_nor_parts[] = {
>>   	}, {
>>   		.id = SNOR_ID(0xef, 0x70, 0x19),
>>   		.name = "w25q256jvm",
>> +	}, {
>> +		.id = SNOR_ID(0xef, 0x70, 0x22),
>> +		/* W25Q02JV */
>
> Nitpick: The place of the comment is not consistent with patch 1/2.

That's right, I'll correct.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Steam Lin <STLin2@winbond.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mtd: spi-nor: winbond: Add support for w25q02jv
Date: Fri, 10 Jan 2025 15:46:32 +0100	[thread overview]
Message-ID: <87cyguafqv.fsf@bootlin.com> (raw)
In-Reply-To: <956f0490-2e47-4655-ab10-a10ef790cfad@wanadoo.fr> (Christophe JAILLET's message of "Thu, 9 Jan 2025 21:23:13 +0100")

Hi Christophe,

On 09/01/2025 at 21:23:13 +01, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> Le 09/01/2025 à 21:17, Miquel Raynal a écrit :
>> Add support for Winbond w25q02jv spi-nor chip which shares most of
>> w25q01jv's specificities as, this time, the chip is made of 4 different
>> dies.
>> Link:
>> https://www.winbond.com/resource-files/W25Q02JV_DTR%20RevD%2007092024%20Plus.pdf
>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> ---
>
> ...
>
>> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
>> index a4c0d99dde4fcd2b123eb7ded4f7822110c6a4ae..d82962e0bf7d8e00b305fd838274a58c34dd6c4e 100644
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -305,6 +305,10 @@ static const struct flash_info winbond_nor_parts[] = {
>>   	}, {
>>   		.id = SNOR_ID(0xef, 0x70, 0x19),
>>   		.name = "w25q256jvm",
>> +	}, {
>> +		.id = SNOR_ID(0xef, 0x70, 0x22),
>> +		/* W25Q02JV */
>
> Nitpick: The place of the comment is not consistent with patch 1/2.

That's right, I'll correct.

Thanks,
Miquèl

  reply	other threads:[~2025-01-10 15:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 20:17 [PATCH v2 0/2] mtd: spi-nor: winbond: Add support for flashes with several dies Miquel Raynal
2025-01-09 20:17 ` Miquel Raynal
2025-01-09 20:17 ` [PATCH v2 1/2] mtd: spi-nor: winbond: Add support for w25q01jv Miquel Raynal
2025-01-09 20:17   ` Miquel Raynal
2025-01-09 20:17 ` [PATCH v2 2/2] mtd: spi-nor: winbond: Add support for w25q02jv Miquel Raynal
2025-01-09 20:17   ` Miquel Raynal
2025-01-09 20:23   ` Christophe JAILLET
2025-01-09 20:23     ` Christophe JAILLET
2025-01-10 14:46     ` Miquel Raynal [this message]
2025-01-10 14:46       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyguafqv.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=STLin2@winbond.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.