All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Arnd Bergmann <arnd@kernel.org>,
	Kees Cook <keescook@chromium.org>, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH] vdso/datapage: Quick fix - use asm/page-def.h for ARM64
Date: Tue, 27 Feb 2024 16:34:42 +0100	[thread overview]
Message-ID: <87cyshapkd.ffs@tglx> (raw)
In-Reply-To: <Zd3nU4IbF0yYREt4@arm.com>

On Tue, Feb 27 2024 at 13:44, Catalin Marinas wrote:
> On Mon, Feb 26, 2024 at 06:50:23PM +0100, Anna-Maria Behnsen wrote:
>> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
>> index 7ba44379a095..5d5c0b8efff2 100644
>> --- a/include/vdso/datapage.h
>> +++ b/include/vdso/datapage.h
>> @@ -19,7 +19,11 @@
>>  #include <vdso/time32.h>
>>  #include <vdso/time64.h>
>>  
>> +#ifdef CONFIG_ARM64
>> +#include <asm/page-def.h>
>> +#else
>>  #include <asm/page.h>
>> +#endif
>
> I'm not a fan of guarding includes but I guess this would do until we
> merge Arnd's clean-up patches. FWIW:

Nobody is a fan of that, but the cleanup is not available tomorrow :)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Arnd Bergmann <arnd@kernel.org>,
	Kees Cook <keescook@chromium.org>, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH] vdso/datapage: Quick fix - use asm/page-def.h for ARM64
Date: Tue, 27 Feb 2024 16:34:42 +0100	[thread overview]
Message-ID: <87cyshapkd.ffs@tglx> (raw)
In-Reply-To: <Zd3nU4IbF0yYREt4@arm.com>

On Tue, Feb 27 2024 at 13:44, Catalin Marinas wrote:
> On Mon, Feb 26, 2024 at 06:50:23PM +0100, Anna-Maria Behnsen wrote:
>> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
>> index 7ba44379a095..5d5c0b8efff2 100644
>> --- a/include/vdso/datapage.h
>> +++ b/include/vdso/datapage.h
>> @@ -19,7 +19,11 @@
>>  #include <vdso/time32.h>
>>  #include <vdso/time64.h>
>>  
>> +#ifdef CONFIG_ARM64
>> +#include <asm/page-def.h>
>> +#else
>>  #include <asm/page.h>
>> +#endif
>
> I'm not a fan of guarding includes but I guess this would do until we
> merge Arnd's clean-up patches. FWIW:

Nobody is a fan of that, but the cleanup is not available tomorrow :)

  reply	other threads:[~2024-02-27 15:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 17:50 [PATCH] vdso/datapage: Quick fix - use asm/page-def.h for ARM64 Anna-Maria Behnsen
2024-02-26 17:50 ` Anna-Maria Behnsen
2024-02-26 22:24 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-02-27 13:44 ` [PATCH] " Catalin Marinas
2024-02-27 13:44   ` Catalin Marinas
2024-02-27 15:34   ` Thomas Gleixner [this message]
2024-02-27 15:34     ` Thomas Gleixner
2024-02-27 14:46 ` Vincenzo Frascino
2024-02-27 14:46   ` Vincenzo Frascino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyshapkd.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=anna-maria@linutronix.de \
    --cc=arnd@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft@linaro.org \
    --cc=luto@kernel.org \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.