* [PATCH] imx9: clock: Fix board_interface_eth_init for FEC
@ 2024-01-30 12:43 Primoz Fiser
2024-01-30 14:15 ` Mathieu Othacehe
2024-02-08 14:31 ` Fabio Estevam
0 siblings, 2 replies; 3+ messages in thread
From: Primoz Fiser @ 2024-01-30 12:43 UTC (permalink / raw)
To: Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team, Tom Rini,
Peng Fan, Ye Li, Jacky Bai, Sébastien Szymanski, u-boot
Cc: upstream
Commit d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init()
for i.MX93") implemented board_interface_eth_init for i.MX9 platforms.
However it only accounted for the EQOS interface while any board using
FEC as primary Ethernet interface was left out as return value -EINVAL
is always returned from the function in such case.
Fix this by returning 0 (success) when FEC interface is primarily used
instead of EQOS interface on i.MX93.
Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93")
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
arch/arm/mach-imx/imx9/clock.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/mach-imx/imx9/clock.c b/arch/arm/mach-imx/imx9/clock.c
index 92c41e9a67bf..75d92af036a1 100644
--- a/arch/arm/mach-imx/imx9/clock.c
+++ b/arch/arm/mach-imx/imx9/clock.c
@@ -882,6 +882,11 @@ int board_interface_eth_init(struct udevice *dev, phy_interface_t interface_type
device_is_compatible(dev, "nxp,imx93-dwmac-eqos"))
return imx93_eqos_interface_init(dev, interface_type);
+ if (IS_ENABLED(CONFIG_IMX93) &&
+ IS_ENABLED(CONFIG_FEC_MXC) &&
+ device_is_compatible(dev, "fsl,imx93-fec"))
+ return 0;
+
return -EINVAL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] imx9: clock: Fix board_interface_eth_init for FEC
2024-01-30 12:43 [PATCH] imx9: clock: Fix board_interface_eth_init for FEC Primoz Fiser
@ 2024-01-30 14:15 ` Mathieu Othacehe
2024-02-08 14:31 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Othacehe @ 2024-01-30 14:15 UTC (permalink / raw)
To: Primoz Fiser
Cc: Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team, Tom Rini,
Peng Fan, Ye Li, Jacky Bai, Sébastien Szymanski, u-boot,
upstream
Hello,
> Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93")
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
I confirm that it fixes Ethernet connection when using FEC as a primary
port on the phyBOARD-Segin-i.MX93.
Tested-by: Mathieu Othacehe <m.othacehe@gmail.com>
Mathieu
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] imx9: clock: Fix board_interface_eth_init for FEC
2024-01-30 12:43 [PATCH] imx9: clock: Fix board_interface_eth_init for FEC Primoz Fiser
2024-01-30 14:15 ` Mathieu Othacehe
@ 2024-02-08 14:31 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-02-08 14:31 UTC (permalink / raw)
To: Primoz Fiser
Cc: Stefano Babic, NXP i.MX U-Boot Team, Tom Rini, Peng Fan, Ye Li,
Jacky Bai, Sébastien Szymanski, u-boot, upstream
On Tue, Jan 30, 2024 at 9:43 AM Primoz Fiser <primoz.fiser@norik.com> wrote:
>
> Commit d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init()
> for i.MX93") implemented board_interface_eth_init for i.MX9 platforms.
> However it only accounted for the EQOS interface while any board using
> FEC as primary Ethernet interface was left out as return value -EINVAL
> is always returned from the function in such case.
>
> Fix this by returning 0 (success) when FEC interface is primarily used
> instead of EQOS interface on i.MX93.
>
> Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93")
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-08 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-30 12:43 [PATCH] imx9: clock: Fix board_interface_eth_init for FEC Primoz Fiser
2024-01-30 14:15 ` Mathieu Othacehe
2024-02-08 14:31 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.