From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH] drm/debugfs: drop unneeded DEBUG_FS guard
Date: Thu, 07 Dec 2023 12:09:36 +0200 [thread overview]
Message-ID: <87cyvi1fz3.fsf@intel.com> (raw)
In-Reply-To: <20231206150201.669055-1-dario.binacchi@amarulasolutions.com>
On Wed, 06 Dec 2023, Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> The Makefile enables/disables the file compilation depending on
> CONFIG_DEBUG_FS.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
>
> drivers/gpu/drm/drm_debugfs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index f291fb4b359f..f80d9cf3e71a 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -45,8 +45,6 @@
> #include "drm_crtc_internal.h"
> #include "drm_internal.h"
>
> -#if defined(CONFIG_DEBUG_FS)
> -
> /***************************************************
> * Initialization, etc.
> **************************************************/
> @@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc)
> debugfs_remove_recursive(crtc->debugfs_entry);
> crtc->debugfs_entry = NULL;
> }
> -
> -#endif /* CONFIG_DEBUG_FS */
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org,
Dario Binacchi <dario.binacchi@amarulasolutions.com>
Subject: Re: [PATCH] drm/debugfs: drop unneeded DEBUG_FS guard
Date: Thu, 07 Dec 2023 12:09:36 +0200 [thread overview]
Message-ID: <87cyvi1fz3.fsf@intel.com> (raw)
In-Reply-To: <20231206150201.669055-1-dario.binacchi@amarulasolutions.com>
On Wed, 06 Dec 2023, Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> The Makefile enables/disables the file compilation depending on
> CONFIG_DEBUG_FS.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
>
> drivers/gpu/drm/drm_debugfs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index f291fb4b359f..f80d9cf3e71a 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -45,8 +45,6 @@
> #include "drm_crtc_internal.h"
> #include "drm_internal.h"
>
> -#if defined(CONFIG_DEBUG_FS)
> -
> /***************************************************
> * Initialization, etc.
> **************************************************/
> @@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc)
> debugfs_remove_recursive(crtc->debugfs_entry);
> crtc->debugfs_entry = NULL;
> }
> -
> -#endif /* CONFIG_DEBUG_FS */
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-12-07 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 15:01 [PATCH] drm/debugfs: drop unneeded DEBUG_FS guard Dario Binacchi
2023-12-06 15:01 ` Dario Binacchi
2023-12-07 10:09 ` Jani Nikula [this message]
2023-12-07 10:09 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyvi1fz3.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.