* Re: 回复: [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()
@ 2023-11-29 17:37 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2023-11-29 17:37 UTC (permalink / raw)
To: 何敏红, ville.syrjala, uma.shankar
Cc: airlied, animesh.manna, ankit.k.nautiyal, daniel, dri-devel,
intel-gfx, joonas.lahtinen, linux-kernel, rodrigo.vivi,
tvrtko.ursulin, kernel test robot
On Wed, 29 Nov 2023, 何敏红 <heminhong@kylinos.cn> wrote:
> Friendly ping. I think this patch was forgotten.
Pushed, thanks for the patch.
>
> ----
>
> 主 题：[PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()
> 日 期：2023-11-14 10:43
> 发件人：何敏红
> 收件人：何敏红;
>
> Current, the dewake_scanline variable is defined as unsigned int,
> an unsigned int variable that is always greater than or equal to 0.
> when _intel_dsb_commit function is called by intel_dsb_commit function,
> the dewake_scanline variable may have an int value.
> So the dewake_scanline variable is necessary to defined as an int.
>
> Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
> Reported-by: kernel test robot
> Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@intel.com/
> Cc: Ville Syrjälä
> Cc: Uma Shankar
>
> Signed-off-by: heminhong
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 78b6fe24dcd8..7fd6280c54a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
> }
>
> static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
> - unsigned int dewake_scanline)
> + int dewake_scanline)
> {
> struct intel_crtc *crtc = dsb->crtc;
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: 回复: [PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()
@ 2023-11-29 17:37 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2023-11-29 17:37 UTC (permalink / raw)
To: 何敏红, ville.syrjala, uma.shankar
Cc: tvrtko.ursulin, kernel test robot, animesh.manna, linux-kernel,
dri-devel, rodrigo.vivi, ankit.k.nautiyal, intel-gfx
On Wed, 29 Nov 2023, 何敏红 <heminhong@kylinos.cn> wrote:
> Friendly ping. I think this patch was forgotten.
Pushed, thanks for the patch.
>
> ----
>
> 主 题：[PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()
> 日 期：2023-11-14 10:43
> 发件人：何敏红
> 收件人：何敏红;
>
> Current, the dewake_scanline variable is defined as unsigned int,
> an unsigned int variable that is always greater than or equal to 0.
> when _intel_dsb_commit function is called by intel_dsb_commit function,
> the dewake_scanline variable may have an int value.
> So the dewake_scanline variable is necessary to defined as an int.
>
> Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
> Reported-by: kernel test robot
> Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@intel.com/
> Cc: Ville Syrjälä
> Cc: Uma Shankar
>
> Signed-off-by: heminhong
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 78b6fe24dcd8..7fd6280c54a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
> }
>
> static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
> - unsigned int dewake_scanline)
> + int dewake_scanline)
> {
> struct intel_crtc *crtc = dsb->crtc;
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 5+ messages in thread