All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Dave Thaler <dthaler=40microsoft.com@dmarc.ietf.org>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"bpf@ietf.org" <bpf@ietf.org>
Subject: Re: [Bpf] [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
Date: Wed, 26 Jul 2023 15:30:54 +0200	[thread overview]
Message-ID: <87cz0e7qb5.fsf@oracle.com> (raw)
In-Reply-To: <PH7PR21MB3878287822C8A1F5994A8E9FA300A@PH7PR21MB3878.namprd21.prod.outlook.com> (Dave Thaler's message of "Wed, 26 Jul 2023 13:28:53 +0000")


>> -----Original Message-----
>> From: Jose E. Marchesi <jose.marchesi@oracle.com>
>> Sent: Wednesday, July 26, 2023 2:26 AM
>> To: bpf@vger.kernel.org
>> Subject: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
>> 
>> This patch fixes the documentation of the BPF_NEG instruction to denote
>> that it does not use the source register operand.
>> 
>> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
>> ---
>>  Documentation/bpf/standardization/instruction-set.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/bpf/standardization/instruction-set.rst
>> b/Documentation/bpf/standardization/instruction-set.rst
>> index 751e657973f0..6ef5534b410a 100644
>> --- a/Documentation/bpf/standardization/instruction-set.rst
>> +++ b/Documentation/bpf/standardization/instruction-set.rst
>> @@ -165,7 +165,7 @@ BPF_OR    0x40   dst \|= src
>>  BPF_AND   0x50   dst &= src
>>  BPF_LSH   0x60   dst <<= (src & mask)
>>  BPF_RSH   0x70   dst >>= (src & mask)
>> -BPF_NEG   0x80   dst = -src
>> +BPF_NEG   0x80   dst = -dst
>>  BPF_MOD   0x90   dst = (src != 0) ? (dst % src) : dst
>>  BPF_XOR   0xa0   dst ^= src
>>  BPF_MOV   0xb0   dst = src
>> --
>> 2.30.2
>
> Acked-by: Dave Thaler <dthaler@microsoft.com>
>
> Also, all changes to files in the standardization directory should also be cc'ed
> to bpf@ietf.org, which I am doing on this email.

Will do in future posts.  Thanks for CCing.

> Dave

WARNING: multiple messages have this Message-ID (diff)
From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Dave Thaler <dthaler=40microsoft.com@dmarc.ietf.org>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"bpf@ietf.org" <bpf@ietf.org>
Subject: Re: [Bpf] [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
Date: Wed, 26 Jul 2023 15:30:54 +0200	[thread overview]
Message-ID: <87cz0e7qb5.fsf@oracle.com> (raw)
Message-ID: <20230726133054.7zfiKYpvPaKwOJj1Zov-3cX2OrxqRuIJCUJIMijSUpE@z> (raw)
In-Reply-To: <PH7PR21MB3878287822C8A1F5994A8E9FA300A@PH7PR21MB3878.namprd21.prod.outlook.com> (Dave Thaler's message of "Wed, 26 Jul 2023 13:28:53 +0000")


>> -----Original Message-----
>> From: Jose E. Marchesi <jose.marchesi@oracle.com>
>> Sent: Wednesday, July 26, 2023 2:26 AM
>> To: bpf@vger.kernel.org
>> Subject: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
>> 
>> This patch fixes the documentation of the BPF_NEG instruction to denote
>> that it does not use the source register operand.
>> 
>> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
>> ---
>>  Documentation/bpf/standardization/instruction-set.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/bpf/standardization/instruction-set.rst
>> b/Documentation/bpf/standardization/instruction-set.rst
>> index 751e657973f0..6ef5534b410a 100644
>> --- a/Documentation/bpf/standardization/instruction-set.rst
>> +++ b/Documentation/bpf/standardization/instruction-set.rst
>> @@ -165,7 +165,7 @@ BPF_OR    0x40   dst \|= src
>>  BPF_AND   0x50   dst &= src
>>  BPF_LSH   0x60   dst <<= (src & mask)
>>  BPF_RSH   0x70   dst >>= (src & mask)
>> -BPF_NEG   0x80   dst = -src
>> +BPF_NEG   0x80   dst = -dst
>>  BPF_MOD   0x90   dst = (src != 0) ? (dst % src) : dst
>>  BPF_XOR   0xa0   dst ^= src
>>  BPF_MOV   0xb0   dst = src
>> --
>> 2.30.2
>
> Acked-by: Dave Thaler <dthaler@microsoft.com>
>
> Also, all changes to files in the standardization directory should also be cc'ed
> to bpf@ietf.org, which I am doing on this email.

Will do in future posts.  Thanks for CCing.

> Dave

-- 
Bpf mailing list
Bpf@ietf.org
https://www.ietf.org/mailman/listinfo/bpf

  reply	other threads:[~2023-07-26 13:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  9:25 [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst Jose E. Marchesi
2023-07-26 13:28 ` Dave Thaler
2023-07-26 13:28   ` [Bpf] " Dave Thaler
2023-07-26 13:30   ` Jose E. Marchesi [this message]
2023-07-26 13:30     ` Jose E. Marchesi
2023-07-27  4:44 ` Yonghong Song
2023-07-28  0:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz0e7qb5.fsf@oracle.com \
    --to=jose.marchesi@oracle.com \
    --cc=bpf@ietf.org \
    --cc=bpf@vger.kernel.org \
    --cc=dthaler=40microsoft.com@dmarc.ietf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.