All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Laurent Dufour <ldufour@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, dave.hansen@linux.intel.com,
	x86@kernel.org, mingo@redhat.com, bp@alien8.de,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 8/9] powerpc: Add HOTPLUG_SMT support
Date: Mon, 12 Jun 2023 18:34:41 +0200	[thread overview]
Message-ID: <87cz207i72.ffs@tglx> (raw)
In-Reply-To: <c0fe7b2c-1ce7-3d2f-0175-e61920fc3dee@linux.ibm.com>

On Mon, Jun 12 2023 at 17:20, Laurent Dufour wrote:
> On 10/06/2023 23:10:02, Thomas Gleixner wrote:
>> This needs more thoughts to avoid a completely inconsistent duct tape
>> mess.
>
> Despite the test against smt_enabled_at_boot, mentioned above, I can't see
> anything else to rework. Am I missing something?

See my comments on the core code changes.

>> Btw, the command line parser and the variable smt_enabled_at_boot being
>> type int allow negative number of threads too... Maybe not what you want.
>
> I do agree, it should an unsigned type.

I assume you'll fix that yourself. :)

Thanks,

        tglx

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Laurent Dufour <ldufour@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, x86@kernel.org,
	dave.hansen@linux.intel.com, mingo@redhat.com, bp@alien8.de,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 8/9] powerpc: Add HOTPLUG_SMT support
Date: Mon, 12 Jun 2023 18:34:41 +0200	[thread overview]
Message-ID: <87cz207i72.ffs@tglx> (raw)
In-Reply-To: <c0fe7b2c-1ce7-3d2f-0175-e61920fc3dee@linux.ibm.com>

On Mon, Jun 12 2023 at 17:20, Laurent Dufour wrote:
> On 10/06/2023 23:10:02, Thomas Gleixner wrote:
>> This needs more thoughts to avoid a completely inconsistent duct tape
>> mess.
>
> Despite the test against smt_enabled_at_boot, mentioned above, I can't see
> anything else to rework. Am I missing something?

See my comments on the core code changes.

>> Btw, the command line parser and the variable smt_enabled_at_boot being
>> type int allow negative number of threads too... Maybe not what you want.
>
> I do agree, it should an unsigned type.

I assume you'll fix that yourself. :)

Thanks,

        tglx

  reply	other threads:[~2023-06-12 16:35 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 15:56 [PATCH 1/9] cpu/SMT: Move SMT prototypes into cpu_smt.h Michael Ellerman
2023-05-24 15:56 ` Michael Ellerman
2023-05-24 15:56 ` [PATCH 2/9] cpu/SMT: Move smt/control simple exit cases earlier Michael Ellerman
2023-05-24 15:56   ` Michael Ellerman
2023-05-24 15:56 ` [PATCH 3/9] cpu/SMT: Store the current/max number of threads Michael Ellerman
2023-05-24 15:56   ` Michael Ellerman
2023-06-10 21:26   ` Thomas Gleixner
2023-06-10 21:26     ` Thomas Gleixner
2023-06-10 22:08     ` Thomas Gleixner
2023-06-10 22:08       ` Thomas Gleixner
2023-06-13 17:16     ` Laurent Dufour
2023-06-13 17:16       ` Laurent Dufour
2023-06-13 18:53       ` Thomas Gleixner
2023-06-13 18:53         ` Thomas Gleixner
2023-06-14 12:27         ` Laurent Dufour
2023-06-14 12:27           ` Laurent Dufour
2023-05-24 15:56 ` [PATCH 4/9] cpu/SMT: Create topology_smt_threads_supported() Michael Ellerman
2023-05-24 15:56   ` Michael Ellerman
2023-06-10 22:15   ` Thomas Gleixner
2023-06-10 22:15     ` Thomas Gleixner
2023-05-24 15:56 ` [PATCH 5/9] cpu/SMT: Create topology_smt_thread_allowed() Michael Ellerman
2023-05-24 15:56   ` Michael Ellerman
2023-06-10 22:35   ` Thomas Gleixner
2023-06-10 22:35     ` Thomas Gleixner
2023-05-24 15:56 ` [PATCH 6/9] cpu/SMT: Allow enabling partial SMT states via sysfs Michael Ellerman
2023-05-24 15:56   ` Michael Ellerman
2023-06-10 20:09   ` Thomas Gleixner
2023-06-10 20:09     ` Thomas Gleixner
2023-06-10 20:13     ` Thomas Gleixner
2023-06-10 20:13       ` Thomas Gleixner
2023-05-24 15:56 ` [PATCH 7/9] powerpc/pseries: Initialise CPU hotplug callbacks earlier Michael Ellerman
2023-05-24 15:56   ` Michael Ellerman
2023-05-24 15:56 ` [PATCH 8/9] powerpc: Add HOTPLUG_SMT support Michael Ellerman
2023-05-24 15:56   ` Michael Ellerman
2023-06-01 13:27   ` Laurent Dufour
2023-06-01 13:27     ` Laurent Dufour
2023-06-01 16:19     ` Laurent Dufour
2023-06-01 16:19       ` Laurent Dufour
2023-06-10 21:10       ` Thomas Gleixner
2023-06-10 21:10         ` Thomas Gleixner
2023-06-12 15:20         ` Laurent Dufour
2023-06-12 15:20           ` Laurent Dufour
2023-06-12 16:34           ` Thomas Gleixner [this message]
2023-06-12 16:34             ` Thomas Gleixner
2023-05-24 15:56 ` [PATCH 9/9] powerpc/pseries: Honour current SMT state when DLPAR onlining CPUs Michael Ellerman
2023-05-24 15:56   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz207i72.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.