All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Kunkun Jiang <jiangkunkun@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"wanghaibin.wang@huawei.com" <wanghaibin.wang@huawei.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: A question about Cortex-A73 erratum 858921
Date: Fri, 09 Sep 2022 13:23:38 +0100	[thread overview]
Message-ID: <87czc4rb1x.wl-maz@kernel.org> (raw)
In-Reply-To: <cce62c36-c2f4-7e0e-ad6d-6eae98f45aee@huawei.com>

On Fri, 09 Sep 2022 08:31:43 +0100,
Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> 
> Hi all,
> 
> Recently I am learning the code related to Arm arch timer. I found that the
> Cortex-A73 erratum 858921 does not set the corresponding callback functions:
> set_next_event_phys and set_next_event_virt like other erratums. Won't it
> get the wrong value when reading the counter during setting next event?

Yup, you're correct.

This is a regression introduced by a38b71b0833e
("clocksource/drivers/arm_arch_timer: Move system register timer
programming over to CVAL"). We used to use the TVAL accessor which
doesn't need a read of the counter, while the switch to CVAL needs
one. Obviously, I didn't enough pay attention to the A73 erratum.

Please send in a fix for this.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Kunkun Jiang <jiangkunkun@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"wanghaibin.wang@huawei.com" <wanghaibin.wang@huawei.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: A question about Cortex-A73 erratum 858921
Date: Fri, 09 Sep 2022 13:23:38 +0100	[thread overview]
Message-ID: <87czc4rb1x.wl-maz@kernel.org> (raw)
In-Reply-To: <cce62c36-c2f4-7e0e-ad6d-6eae98f45aee@huawei.com>

On Fri, 09 Sep 2022 08:31:43 +0100,
Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> 
> Hi all,
> 
> Recently I am learning the code related to Arm arch timer. I found that the
> Cortex-A73 erratum 858921 does not set the corresponding callback functions:
> set_next_event_phys and set_next_event_virt like other erratums. Won't it
> get the wrong value when reading the counter during setting next event?

Yup, you're correct.

This is a regression introduced by a38b71b0833e
("clocksource/drivers/arm_arch_timer: Move system register timer
programming over to CVAL"). We used to use the TVAL accessor which
doesn't need a read of the counter, while the switch to CVAL needs
one. Obviously, I didn't enough pay attention to the A73 erratum.

Please send in a fix for this.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2022-09-09 12:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09  7:31 A question about Cortex-A73 erratum 858921 Kunkun Jiang
2022-09-09  7:31 ` Kunkun Jiang
2022-09-09 12:23 ` Marc Zyngier [this message]
2022-09-09 12:23   ` Marc Zyngier
2022-09-13 10:52   ` Kunkun Jiang
2022-09-13 10:52     ` Kunkun Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czc4rb1x.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=jiangkunkun@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=tglx@linutronix.de \
    --cc=wanghaibin.wang@huawei.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.