All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: eric.auger@redhat.com
Cc: kvm@vger.kernel.org, andrew.jones@linux.dev,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH v2 3/3] arm: pmu: Check for overflow in the low counter in chained counters tests
Date: Mon, 08 Aug 2022 11:40:01 +0100	[thread overview]
Message-ID: <87czdbvx1a.wl-maz@kernel.org> (raw)
In-Reply-To: <289609de-ca61-2257-caf0-daedaf6c9bc3@redhat.com>

On Thu, 04 Aug 2022 19:21:49 +0100,
Eric Auger <eric.auger@redhat.com> wrote:
>
> I definitively missed that spec detail when originally writing the test,
> thank you for fixing.

To be fair, it is only in a very recent version of the ARM ARM that
this detail came to light, and we collectively misunderstood the spec
for a few years, resulting in a over-complicated KVM infrastructure
(the new emulation code is so much simpler).

BTW, I think I forgot to Cc you and Andrew on the KVM rework at [1],
sorry about that.

Thanks,

	M.

[1] https://lore.kernel.org/kvm/20220805135813.2102034-1-maz@kernel.org

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: eric.auger@redhat.com
Cc: Ricardo Koller <ricarkol@google.com>,
	kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	andrew.jones@linux.dev, alexandru.elisei@arm.com,
	oliver.upton@linux.dev, reijiw@google.com
Subject: Re: [kvm-unit-tests PATCH v2 3/3] arm: pmu: Check for overflow in the low counter in chained counters tests
Date: Mon, 08 Aug 2022 11:40:01 +0100	[thread overview]
Message-ID: <87czdbvx1a.wl-maz@kernel.org> (raw)
In-Reply-To: <289609de-ca61-2257-caf0-daedaf6c9bc3@redhat.com>

On Thu, 04 Aug 2022 19:21:49 +0100,
Eric Auger <eric.auger@redhat.com> wrote:
>
> I definitively missed that spec detail when originally writing the test,
> thank you for fixing.

To be fair, it is only in a very recent version of the ARM ARM that
this detail came to light, and we collectively misunderstood the spec
for a few years, resulting in a over-complicated KVM infrastructure
(the new emulation code is so much simpler).

BTW, I think I forgot to Cc you and Andrew on the KVM rework at [1],
sorry about that.

Thanks,

	M.

[1] https://lore.kernel.org/kvm/20220805135813.2102034-1-maz@kernel.org

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2022-08-08 10:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 18:23 [kvm-unit-tests PATCH v2 0/3] arm: pmu: Fixes for bare metal Ricardo Koller
2022-08-03 18:23 ` Ricardo Koller
2022-08-03 18:23 ` [kvm-unit-tests PATCH v2 1/3] arm: pmu: Add missing isb()'s after sys register writing Ricardo Koller
2022-08-03 18:23   ` Ricardo Koller
2022-08-04  8:55   ` Alexandru Elisei
2022-08-04  8:55     ` Alexandru Elisei
2022-08-05  0:42     ` Ricardo Koller
2022-08-05  0:42       ` Ricardo Koller
2022-08-03 18:23 ` [kvm-unit-tests PATCH v2 2/3] arm: pmu: Reset the pmu registers before starting some tests Ricardo Koller
2022-08-03 18:23   ` Ricardo Koller
2022-08-04 18:21   ` Eric Auger
2022-08-04 18:21     ` Eric Auger
2022-08-03 18:23 ` [kvm-unit-tests PATCH v2 3/3] arm: pmu: Check for overflow in the low counter in chained counters tests Ricardo Koller
2022-08-03 18:23   ` Ricardo Koller
2022-08-04  8:18   ` Andrew Jones
2022-08-04  8:18     ` Andrew Jones
2022-08-05  0:43     ` Ricardo Koller
2022-08-05  0:43       ` Ricardo Koller
2022-08-04 18:21   ` Eric Auger
2022-08-04 18:21     ` Eric Auger
2022-08-08 10:40     ` Marc Zyngier [this message]
2022-08-08 10:40       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czdbvx1a.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=andrew.jones@linux.dev \
    --cc=eric.auger@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.