All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Baochen Qiang <quic_bqiang@quicinc.com>,
	<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] ath11k: Add support for SAR
Date: Wed, 20 Apr 2022 19:35:45 +0300	[thread overview]
Message-ID: <87czhbogpq.fsf@kernel.org> (raw)
In-Reply-To: <cb07aa82-2971-69dd-bf80-ff7f0cff4569@quicinc.com> (Jeff Johnson's message of "Fri, 1 Apr 2022 12:06:44 -0700")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 4/1/2022 5:09 AM, Baochen Qiang wrote:
>> ath11k assigns ath11k_mac_op_set_bios_sar_specs to ath11k_ops,
>> and this function is called when user space application
>> calls NL80211_CMD_SET_SAR_SPECS. ath11k also registers SAR
>> type and frequency ranges to wiphy so user space can query
>> SAR capabilities.
>
> I find this commit text very confusing since it uses "present simple"
> tense instead of "imperative" tense so it comes across as describing
> what the driver did prior to the patch instead of what the driver is
> supposed to do after the patch is applied.
>
> The patch itself LGTM.

I tried to improve the commit log, please check:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6b0778eaea60533a8b48df2d890543a48b590f55

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Baochen Qiang <quic_bqiang@quicinc.com>,
	<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] ath11k: Add support for SAR
Date: Wed, 20 Apr 2022 19:35:45 +0300	[thread overview]
Message-ID: <87czhbogpq.fsf@kernel.org> (raw)
In-Reply-To: <cb07aa82-2971-69dd-bf80-ff7f0cff4569@quicinc.com> (Jeff Johnson's message of "Fri, 1 Apr 2022 12:06:44 -0700")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 4/1/2022 5:09 AM, Baochen Qiang wrote:
>> ath11k assigns ath11k_mac_op_set_bios_sar_specs to ath11k_ops,
>> and this function is called when user space application
>> calls NL80211_CMD_SET_SAR_SPECS. ath11k also registers SAR
>> type and frequency ranges to wiphy so user space can query
>> SAR capabilities.
>
> I find this commit text very confusing since it uses "present simple"
> tense instead of "imperative" tense so it comes across as describing
> what the driver did prior to the patch instead of what the driver is
> supposed to do after the patch is applied.
>
> The patch itself LGTM.

I tried to improve the commit log, please check:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6b0778eaea60533a8b48df2d890543a48b590f55

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2022-04-20 16:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 12:09 [PATCH v4 0/2] ath11k: Add support for SAR Baochen Qiang
2022-04-01 12:09 ` Baochen Qiang
2022-04-01 12:09 ` [PATCH v4 1/2] ath11k: add support for extended wmi service bit Baochen Qiang
2022-04-01 12:09   ` Baochen Qiang
2022-04-01 18:07   ` Jeff Johnson
2022-04-01 18:07     ` Jeff Johnson
2022-04-20 16:35     ` Kalle Valo
2022-04-20 16:35       ` Kalle Valo
2022-04-21 15:04       ` Jeff Johnson
2022-04-21 15:04         ` Jeff Johnson
2022-04-23  9:27   ` Kalle Valo
2022-04-23  9:27     ` Kalle Valo
2022-04-01 12:09 ` [PATCH v4 2/2] ath11k: Add support for SAR Baochen Qiang
2022-04-01 12:09   ` Baochen Qiang
2022-04-01 13:18   ` Kalle Valo
2022-04-01 13:18     ` Kalle Valo
2022-04-01 19:06   ` Jeff Johnson
2022-04-01 19:06     ` Jeff Johnson
2022-04-20 16:35     ` Kalle Valo [this message]
2022-04-20 16:35       ` Kalle Valo
2022-04-21 15:05       ` Jeff Johnson
2022-04-21 15:05         ` Jeff Johnson
2022-04-01 12:27 ` [PATCH v4 0/2] " Kalle Valo
2022-04-01 12:27   ` Kalle Valo
2022-04-01 12:29   ` Baochen Qiang (QUIC)
2022-04-01 12:29     ` Baochen Qiang (QUIC)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czhbogpq.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_bqiang@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.