All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	linux-s390@vger.kernel.org, markver@us.ibm.com,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Xie Yongji <xieyongji@bytedance.com>,
	stefanha@redhat.com,
	Raphael Norwitz <raphael.norwitz@nutanix.com>,
	Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [RFC PATCH 1/1] virtio: write back features before verify
Date: Tue, 05 Oct 2021 17:25:32 +0200	[thread overview]
Message-ID: <87czoj1ok3.fsf@redhat.com> (raw)
In-Reply-To: <20211005135909.2b8ab021.pasic@linux.ibm.com>

On Tue, Oct 05 2021, Halil Pasic <pasic@linux.ibm.com> wrote:

> On Tue, 05 Oct 2021 13:13:31 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>> Or am I misunderstanding what you're getting at?
>> 
>
> Probably. I'm talking about pre- "do transport specific legacy detection
> in the device instead of looking at VERSION_1" you are probably talking
> about the post-state. If we had this new behavior for all relevant
> hypervisors then we wouldn't need to do a thing in the guest. The current
> code would work like charm.

Yeah, I was thinking more about the desired state. We need to both fix
QEMU (and other VMMs or devices should check whether they are doing the
right thing) and add a workaround on the driver side to make it work
with existing QEMUs.


WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, markver@us.ibm.com,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Xie Yongji <xieyongji@bytedance.com>,
	qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Raphael Norwitz <raphael.norwitz@nutanix.com>,
	stefanha@redhat.com, virtualization@lists.linux-foundation.org
Subject: Re: [RFC PATCH 1/1] virtio: write back features before verify
Date: Tue, 05 Oct 2021 17:25:32 +0200	[thread overview]
Message-ID: <87czoj1ok3.fsf@redhat.com> (raw)
In-Reply-To: <20211005135909.2b8ab021.pasic@linux.ibm.com>

On Tue, Oct 05 2021, Halil Pasic <pasic@linux.ibm.com> wrote:

> On Tue, 05 Oct 2021 13:13:31 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>> Or am I misunderstanding what you're getting at?
>> 
>
> Probably. I'm talking about pre- "do transport specific legacy detection
> in the device instead of looking at VERSION_1" you are probably talking
> about the post-state. If we had this new behavior for all relevant
> hypervisors then we wouldn't need to do a thing in the guest. The current
> code would work like charm.

Yeah, I was thinking more about the desired state. We need to both fix
QEMU (and other VMMs or devices should check whether they are doing the
right thing) and add a workaround on the driver side to make it work
with existing QEMUs.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, markver@us.ibm.com,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Xie Yongji <xieyongji@bytedance.com>,
	qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Raphael Norwitz <raphael.norwitz@nutanix.com>,
	stefanha@redhat.com, virtualization@lists.linux-foundation.org
Subject: Re: [RFC PATCH 1/1] virtio: write back features before verify
Date: Tue, 05 Oct 2021 17:25:32 +0200	[thread overview]
Message-ID: <87czoj1ok3.fsf@redhat.com> (raw)
In-Reply-To: <20211005135909.2b8ab021.pasic@linux.ibm.com>

On Tue, Oct 05 2021, Halil Pasic <pasic@linux.ibm.com> wrote:

> On Tue, 05 Oct 2021 13:13:31 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>> Or am I misunderstanding what you're getting at?
>> 
>
> Probably. I'm talking about pre- "do transport specific legacy detection
> in the device instead of looking at VERSION_1" you are probably talking
> about the post-state. If we had this new behavior for all relevant
> hypervisors then we wouldn't need to do a thing in the guest. The current
> code would work like charm.

Yeah, I was thinking more about the desired state. We need to both fix
QEMU (and other VMMs or devices should check whether they are doing the
right thing) and add a workaround on the driver side to make it work
with existing QEMUs.



  reply	other threads:[~2021-10-05 15:25 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30  1:20 [RFC PATCH 1/1] virtio: write back features before verify Halil Pasic
2021-09-30  1:20 ` Halil Pasic
2021-09-30  8:04 ` Christian Borntraeger
2021-09-30  8:04   ` Christian Borntraeger
2021-09-30  9:28 ` Cornelia Huck
2021-09-30  9:28   ` Cornelia Huck
2021-09-30 11:03   ` Halil Pasic
2021-09-30 11:03     ` Halil Pasic
2021-09-30 11:31     ` Cornelia Huck
2021-09-30 11:31       ` Cornelia Huck
2021-10-01 14:22       ` Halil Pasic
2021-10-01 14:22         ` Halil Pasic
2021-10-01 15:18         ` Cornelia Huck
2021-10-01 15:18           ` Cornelia Huck
2021-10-02 18:13           ` Michael S. Tsirkin
2021-10-02 18:13             ` Michael S. Tsirkin
2021-10-04  2:23             ` Halil Pasic
2021-10-04  2:23               ` Halil Pasic
2021-10-04  9:07               ` Michael S. Tsirkin
2021-10-04  9:07                 ` Michael S. Tsirkin
2021-10-04  9:07                 ` Michael S. Tsirkin
2021-10-05 10:06                 ` Cornelia Huck
2021-10-05 10:06                   ` Cornelia Huck
2021-10-05 10:06                   ` Cornelia Huck
2021-10-05 10:43                 ` Halil Pasic
2021-10-05 10:43                   ` Halil Pasic
2021-10-05 10:43                   ` Halil Pasic
2021-10-05 11:11                   ` Michael S. Tsirkin
2021-10-05 11:11                     ` Michael S. Tsirkin
2021-10-05 11:11                     ` Michael S. Tsirkin
2021-10-05 11:13                   ` Cornelia Huck
2021-10-05 11:13                     ` Cornelia Huck
2021-10-05 11:13                     ` Cornelia Huck
2021-10-05 11:20                     ` Michael S. Tsirkin
2021-10-05 11:20                       ` Michael S. Tsirkin
2021-10-05 11:20                       ` Michael S. Tsirkin
2021-10-05 11:59                     ` Halil Pasic
2021-10-05 11:59                       ` Halil Pasic
2021-10-05 11:59                       ` Halil Pasic
2021-10-05 15:25                       ` Cornelia Huck [this message]
2021-10-05 15:25                         ` Cornelia Huck
2021-10-05 15:25                         ` Cornelia Huck
2021-10-04  7:01             ` Cornelia Huck
2021-10-04  7:01               ` Cornelia Huck
2021-10-04  9:25               ` Halil Pasic
2021-10-04  9:25                 ` Halil Pasic
2021-10-04  9:51                 ` Cornelia Huck
2021-10-04  9:51                   ` Cornelia Huck
2021-10-02 12:09       ` Michael S. Tsirkin
2021-10-02 12:09         ` Michael S. Tsirkin
2021-09-30 11:12 ` Michael S. Tsirkin
2021-09-30 11:12   ` Michael S. Tsirkin
2021-09-30 11:36   ` Cornelia Huck
2021-09-30 11:36     ` Cornelia Huck
2021-10-02 18:20     ` Michael S. Tsirkin
2021-10-02 18:20       ` Michael S. Tsirkin
2021-10-03  5:00       ` Halil Pasic
2021-10-03  5:00         ` Halil Pasic
2021-10-03  6:42         ` Michael S. Tsirkin
2021-10-03  6:42           ` Michael S. Tsirkin
2021-10-03  7:26           ` Michael S. Tsirkin
2021-10-03  7:26             ` Michael S. Tsirkin
2021-10-04 12:01             ` Cornelia Huck
2021-10-04 12:01               ` Cornelia Huck
2021-10-04 12:01               ` [virtio-dev] " Cornelia Huck
2021-10-04 12:54               ` Michael S. Tsirkin
2021-10-04 12:54                 ` Michael S. Tsirkin
2021-10-04 14:27                 ` Cornelia Huck
2021-10-04 14:27                   ` Cornelia Huck
2021-10-04 14:27                   ` [virtio-dev] " Cornelia Huck
2021-10-04 15:05                   ` Michael S. Tsirkin
2021-10-04 15:05                     ` Michael S. Tsirkin
2021-10-04 15:05                     ` [virtio-dev] " Michael S. Tsirkin
2021-10-04 15:45                     ` Cornelia Huck
2021-10-04 15:45                       ` Cornelia Huck
2021-10-04 15:45                       ` Cornelia Huck
2021-10-04 20:01                       ` Michael S. Tsirkin
2021-10-04 20:01                         ` Michael S. Tsirkin
2021-10-05  7:38                         ` Cornelia Huck
2021-10-05  7:38                           ` Cornelia Huck
2021-10-05  7:38                           ` Cornelia Huck
2021-10-05 11:17                         ` Halil Pasic
2021-10-05 11:17                           ` Halil Pasic
2021-10-05 11:22                           ` Michael S. Tsirkin
2021-10-05 11:22                             ` Michael S. Tsirkin
2021-10-05 15:20                             ` Cornelia Huck
2021-10-05 15:20                               ` Cornelia Huck
2021-10-05 15:20                               ` Cornelia Huck
2021-10-05 15:20                               ` Cornelia Huck
2021-10-01  7:21   ` Halil Pasic
2021-10-01  7:21     ` Halil Pasic
2021-10-02 10:21     ` Michael S. Tsirkin
2021-10-02 10:21       ` Michael S. Tsirkin
2021-10-04 12:19       ` Cornelia Huck
2021-10-04 12:19         ` Cornelia Huck
2021-10-04 12:19         ` Cornelia Huck
2021-10-04 13:11         ` Michael S. Tsirkin
2021-10-04 13:11           ` Michael S. Tsirkin
2021-10-04 13:11           ` Michael S. Tsirkin
2021-10-04 14:33           ` Cornelia Huck
2021-10-04 14:33             ` Cornelia Huck
2021-10-04 14:33             ` Cornelia Huck
2021-10-04 15:07             ` Michael S. Tsirkin
2021-10-04 15:07               ` Michael S. Tsirkin
2021-10-04 15:07               ` Michael S. Tsirkin
2021-10-04 15:50               ` Cornelia Huck
2021-10-04 15:50                 ` Cornelia Huck
2021-10-04 15:50                 ` Cornelia Huck
2021-10-04 19:17                 ` Michael S. Tsirkin
2021-10-04 19:17                   ` Michael S. Tsirkin
2021-10-04 19:17                   ` Michael S. Tsirkin
2021-10-06 10:13                   ` Cornelia Huck
2021-10-06 10:13                     ` Cornelia Huck
2021-10-06 10:13                     ` Cornelia Huck
2021-10-06 12:15                     ` Michael S. Tsirkin
2021-10-06 12:15                       ` Michael S. Tsirkin
2021-10-06 12:15                       ` Michael S. Tsirkin
2021-10-05  7:25           ` Halil Pasic
2021-10-05  7:25             ` Halil Pasic
2021-10-05  7:25             ` Halil Pasic
2021-10-05  7:53             ` Michael S. Tsirkin
2021-10-05  7:53               ` Michael S. Tsirkin
2021-10-05  7:53               ` Michael S. Tsirkin
2021-10-05 10:46               ` Halil Pasic
2021-10-05 10:46                 ` Halil Pasic
2021-10-05 10:46                 ` Halil Pasic
2021-10-05 11:11                 ` Michael S. Tsirkin
2021-10-05 11:11                   ` Michael S. Tsirkin
2021-10-05 11:11                   ` Michael S. Tsirkin
2021-10-01 14:34 ` Christian Borntraeger
2021-10-01 14:34   ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czoj1ok3.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=markver@us.ibm.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=raphael.norwitz@nutanix.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.