Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

From: Kalle Valo <kvalo@codeaurora.org>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	lkml <linux-kernel@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	dt <devicetree@vger.kernel.org>,
	David S Miller <davem@davemloft.net>,
	John Stultz <john.stultz@linaro.org>,
	Konrad Dybcio <konradybcio@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests
Date: Mon, 08 Feb 2021 19:21:24 +0200	[thread overview]
Message-ID: <87czxa4grv.fsf@codeaurora.org> (raw)
In-Reply-To: <CAMi1Hd2FN6QQzbKHooVyqQfH1NFTNLt4RwxyVXRf+5DwTc9ojg@mail.gmail.com> (Amit Pundir's message of "Tue, 2 Feb 2021 16:41:19 +0530")

Amit Pundir <amit.pundir@linaro.org> writes:

> Hi Kalle,
>
> On Mon, 7 Dec 2020 at 22:25, Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> This is firmware version specific, right? There's also enum
>> ath10k_fw_features which is embedded within firmware-N.bin, we could add
>> a new flag there. But that means that a correct firmware-N.bin is needed
>> for each firmware version, not sure if that would work out. Just
>> throwing out ideas here.
>
> Apologies for this late reply. I was out for a while.

No worries.

> If by that (the firmware version) you mean "QC_IMAGE_VERSION_STRING",
> then that may be a bit tricky. Pocophone F1 use the same firmware
> family version (WLAN.HL.2.0.XXX), used by Dragonboard 845c (which has
> Wi-Fi working upstream).

I'm meaning the ath10k firmware meta data we have in firmware-N.bin
(N=2,3,4...) file. A quick summary:

Every ath10k firmware release should have firmware-N.bin. The file is
created with this tool:

https://github.com/qca/qca-swiss-army-knife/blob/master/tools/scripts/ath10k/ath10k-fwencoder

firmware-N.bin contains various metadata, one of those being firmware
feature flags:

enum ath10k_fw_features {
	/* wmi_mgmt_rx_hdr contains extra RSSI information */
	ATH10K_FW_FEATURE_EXT_WMI_MGMT_RX = 0,

	/* Firmware from 10X branch. Deprecated, don't use in new code. */
	ATH10K_FW_FEATURE_WMI_10X = 1,

        [...]

So what you could is add a new flag enum ath10k_fw_features, create a
new firmware-N.bin for your device and enable the flag on the firmware
releases for your device only.

I don't know if this is usable, but one solution which came to my mind.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k