All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: marcandre.lureau@redhat.com
Cc: Kevin Wolf <kwolf@redhat.com>,
	kraxel@redhat.com, qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine
Date: Tue, 27 Oct 2020 17:01:41 +0100	[thread overview]
Message-ID: <87d0134pzu.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20201027133602.3038018-4-marcandre.lureau@redhat.com> (marcandre lureau's message of "Tue, 27 Oct 2020 17:36:02 +0400")

marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Thanks to the monitors' coroutine support (merge commit b7092cda1b3),
> the screendump handler can trigger a graphic_hw_update(), yield and let
> the main loop run until update is done. Then the handler is resumed, and
> ppm_save() will write the screen image to disk in the coroutine context.
>
> The IO is still blocking though, as the file is set blocking so far,
> this could be addressed by some future change (with other caveats).
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1230527
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Thanks for persevering!

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2020-10-27 16:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 13:35 [PATCH v2 0/3] console: make QMP screendump use coroutine marcandre.lureau
2020-10-27 13:36 ` [PATCH v2 1/3] coroutine: let CoQueue wake up outside a coroutine marcandre.lureau
2020-10-27 13:36 ` [PATCH v2 2/3] console: modify ppm_save to take a pixman image ref marcandre.lureau
2020-11-03 13:24   ` Gerd Hoffmann
2020-10-27 13:36 ` [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine marcandre.lureau
2020-10-27 16:01   ` Markus Armbruster [this message]
2021-01-20 14:18   ` Gerd Hoffmann
2021-01-20 14:29     ` Marc-André Lureau
2021-01-20 16:09       ` Gerd Hoffmann
2021-01-20 16:25         ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0134pzu.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.