* [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled()
@ 2020-02-04 13:52 Jani Nikula
2020-02-05 2:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2020-02-04 13:52 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Make future work slightly easier.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index db3d1561e9bf..e86e9dc1fe06 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -61,9 +61,9 @@
* must be correctly synchronized/cancelled when shutting down the pipe."
*/
-static bool psr_global_enabled(u32 debug)
+static bool psr_global_enabled(struct drm_i915_private *i915)
{
- switch (debug & I915_PSR_DEBUG_MODE_MASK) {
+ switch (i915->psr.debug & I915_PSR_DEBUG_MODE_MASK) {
case I915_PSR_DEBUG_DEFAULT:
return i915_modparams.enable_psr;
case I915_PSR_DEBUG_DISABLE:
@@ -930,7 +930,7 @@ void intel_psr_enable(struct intel_dp *intel_dp,
mutex_lock(&dev_priv->psr.lock);
- if (!psr_global_enabled(dev_priv->psr.debug)) {
+ if (!psr_global_enabled(dev_priv)) {
drm_dbg_kms(&dev_priv->drm, "PSR disabled by flag\n");
goto unlock;
}
@@ -1085,7 +1085,7 @@ void intel_psr_update(struct intel_dp *intel_dp,
mutex_lock(&dev_priv->psr.lock);
- enable = crtc_state->has_psr && psr_global_enabled(psr->debug);
+ enable = crtc_state->has_psr && psr_global_enabled(dev_priv);
psr2_enable = intel_psr2_enabled(dev_priv, crtc_state);
if (enable == psr->enabled && psr2_enable == psr->psr2_enabled) {
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: pass i915 to psr_global_enabled() 2020-02-04 13:52 [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled() Jani Nikula @ 2020-02-05 2:28 ` Patchwork 2020-02-07 6:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-02-10 11:00 ` [Intel-gfx] [PATCH] " Mika Kuoppala 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-02-05 2:28 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: drm/i915/psr: pass i915 to psr_global_enabled() URL : https://patchwork.freedesktop.org/series/72968/ State : success == Summary == CI Bug Log - changes from CI_DRM_7867 -> Patchwork_16416 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/index.html Known issues ------------ Here are the changes found in Patchwork_16416 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s0: - fi-cml-s: [PASS][1] -> [FAIL][2] ([fdo#103375]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/fi-cml-s/igt@gem_exec_suspend@basic-s0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/fi-cml-s/igt@gem_exec_suspend@basic-s0.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-cml-s: [INCOMPLETE][3] ([i915#1078] / [i915#283]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/fi-cml-s/igt@gem_exec_suspend@basic-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/fi-cml-s/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live_blt: - fi-hsw-4770r: [DMESG-FAIL][5] ([i915#725]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/fi-hsw-4770r/igt@i915_selftest@live_blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/fi-hsw-4770r/igt@i915_selftest@live_blt.html #### Warnings #### * igt@gem_exec_parallel@fds: - fi-byt-n2820: [TIMEOUT][7] ([fdo#112271]) -> [INCOMPLETE][8] ([i915#45]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/fi-byt-n2820/igt@gem_exec_parallel@fds.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/fi-byt-n2820/igt@gem_exec_parallel@fds.html [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#1078]: https://gitlab.freedesktop.org/drm/intel/issues/1078 [i915#283]: https://gitlab.freedesktop.org/drm/intel/issues/283 [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 Participating hosts (42 -> 45) ------------------------------ Additional (9): fi-bdw-5557u fi-bsw-n3050 fi-hsw-peppy fi-kbl-7500u fi-gdg-551 fi-ivb-3770 fi-kbl-r fi-skl-6600u fi-snb-2600 Missing (6): fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7867 -> Patchwork_16416 CI-20190529: 20190529 CI_DRM_7867: a4c409e48c6281538b1e375545dfb5989fa02063 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5418: 4028bd390b41925f6e26f6f11b31e05054652527 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16416: 7c1e008d5eb711c739b6c563b507047d5abb8935 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 7c1e008d5eb7 drm/i915/psr: pass i915 to psr_global_enabled() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: pass i915 to psr_global_enabled() 2020-02-04 13:52 [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled() Jani Nikula 2020-02-05 2:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2020-02-07 6:15 ` Patchwork 2020-02-10 11:00 ` [Intel-gfx] [PATCH] " Mika Kuoppala 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-02-07 6:15 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: drm/i915/psr: pass i915 to psr_global_enabled() URL : https://patchwork.freedesktop.org/series/72968/ State : success == Summary == CI Bug Log - changes from CI_DRM_7867_full -> Patchwork_16416_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16416_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@vecs0-s3: - shard-skl: [PASS][1] -> [INCOMPLETE][2] ([i915#69]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-skl1/igt@gem_ctx_isolation@vecs0-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-skl2/igt@gem_ctx_isolation@vecs0-s3.html * igt@gem_exec_balancer@hang: - shard-tglb: [PASS][3] -> [TIMEOUT][4] ([fdo#112271]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-tglb5/igt@gem_exec_balancer@hang.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-tglb8/igt@gem_exec_balancer@hang.html * igt@gem_exec_schedule@preempt-queue-bsd1: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +14 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html * igt@gem_exec_schedule@preempt-queue-chain-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb8/igt@gem_exec_schedule@preempt-queue-chain-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb2/igt@gem_exec_schedule@preempt-queue-chain-bsd.html * igt@gem_partial_pwrite_pread@writes-after-reads-uncached: - shard-hsw: [PASS][9] -> [FAIL][10] ([i915#694]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-hsw1/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-hsw1/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-tglb: [PASS][11] -> [FAIL][12] ([i915#644]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-tglb8/igt@gem_ppgtt@flink-and-close-vma-leak.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-tglb8/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_atomic_interruptible@legacy-cursor: - shard-apl: [PASS][15] -> [TIMEOUT][16] ([fdo#112271]) +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-apl2/igt@kms_atomic_interruptible@legacy-cursor.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-apl7/igt@kms_atomic_interruptible@legacy-cursor.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][17] -> [FAIL][18] ([i915#79]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb4/igt@kms_psr@psr2_primary_mmap_gtt.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#112080]) +6 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb3/igt@perf_pmu@busy-no-semaphores-vcs1.html #### Possible fixes #### * igt@gem_ctx_isolation@vcs0-s3: - shard-apl: [DMESG-WARN][27] ([i915#180]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-apl1/igt@gem_ctx_isolation@vcs0-s3.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-apl1/igt@gem_ctx_isolation@vcs0-s3.html * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][29] ([fdo#110854]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb6/igt@gem_exec_balancer@smoke.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb4/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [SKIP][31] ([fdo#109276]) -> [PASS][32] +18 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb6/igt@gem_exec_schedule@promotion-bsd1.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [SKIP][33] ([fdo#112146]) -> [PASS][34] +3 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb1/igt@gem_exec_schedule@wide-bsd.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb7/igt@gem_exec_schedule@wide-bsd.html * igt@gem_partial_pwrite_pread@write-snoop: - shard-hsw: [FAIL][35] ([i915#694]) -> [PASS][36] +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-hsw7/igt@gem_partial_pwrite_pread@write-snoop.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-hsw7/igt@gem_partial_pwrite_pread@write-snoop.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [DMESG-WARN][37] ([i915#180]) -> [PASS][38] +8 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-kbl7/igt@gem_workarounds@suspend-resume-fd.html * igt@i915_hangman@error-state-capture-vcs1: - shard-iclb: [SKIP][39] ([fdo#112080]) -> [PASS][40] +5 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb3/igt@i915_hangman@error-state-capture-vcs1.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html * igt@i915_pm_dc@dc5-dpms: - shard-iclb: [FAIL][41] ([i915#447]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb7/igt@i915_pm_dc@dc5-dpms.html * igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent: - shard-skl: [FAIL][43] ([i915#54]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [FAIL][45] ([i915#79]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@plain-flip-fb-recreate-interruptible: - shard-apl: [FAIL][47] ([i915#34]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-apl1/igt@kms_flip@plain-flip-fb-recreate-interruptible.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-apl3/igt@kms_flip@plain-flip-fb-recreate-interruptible.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][49] ([fdo#108145] / [i915#265]) -> [PASS][50] +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-glk: [FAIL][51] ([i915#899]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-glk9/igt@kms_plane_lowres@pipe-a-tiling-x.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-glk1/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@psr2_cursor_mmap_gtt: - shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_gtt.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html * igt@kms_setmode@basic: - shard-kbl: [FAIL][55] ([i915#31]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-kbl6/igt@kms_setmode@basic.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-kbl1/igt@kms_setmode@basic.html #### Warnings #### * igt@i915_pm_dc@dc6-dpms: - shard-tglb: [FAIL][57] ([i915#454]) -> [SKIP][58] ([i915#468]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-tglb5/igt@i915_pm_dc@dc6-dpms.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [DMESG-WARN][59] ([fdo#107724]) -> [SKIP][60] ([fdo#109349]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7867/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7867 -> Patchwork_16416 CI-20190529: 20190529 CI_DRM_7867: a4c409e48c6281538b1e375545dfb5989fa02063 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5418: 4028bd390b41925f6e26f6f11b31e05054652527 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16416: 7c1e008d5eb711c739b6c563b507047d5abb8935 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16416/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled() 2020-02-04 13:52 [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled() Jani Nikula 2020-02-05 2:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-02-07 6:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-02-10 11:00 ` Mika Kuoppala 2020-02-10 12:59 ` Jani Nikula 2 siblings, 1 reply; 5+ messages in thread From: Mika Kuoppala @ 2020-02-10 11:00 UTC (permalink / raw) To: Jani Nikula, intel-gfx; +Cc: jani.nikula Jani Nikula <jani.nikula@intel.com> writes: > Make future work slightly easier. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > index db3d1561e9bf..e86e9dc1fe06 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -61,9 +61,9 @@ > * must be correctly synchronized/cancelled when shutting down the pipe." > */ > > -static bool psr_global_enabled(u32 debug) > +static bool psr_global_enabled(struct drm_i915_private *i915) > { > - switch (debug & I915_PSR_DEBUG_MODE_MASK) { > + switch (i915->psr.debug & I915_PSR_DEBUG_MODE_MASK) { > case I915_PSR_DEBUG_DEFAULT: > return i915_modparams.enable_psr; > case I915_PSR_DEBUG_DISABLE: > @@ -930,7 +930,7 @@ void intel_psr_enable(struct intel_dp *intel_dp, > > mutex_lock(&dev_priv->psr.lock); > > - if (!psr_global_enabled(dev_priv->psr.debug)) { > + if (!psr_global_enabled(dev_priv)) { > drm_dbg_kms(&dev_priv->drm, "PSR disabled by flag\n"); > goto unlock; > } > @@ -1085,7 +1085,7 @@ void intel_psr_update(struct intel_dp *intel_dp, > > mutex_lock(&dev_priv->psr.lock); > > - enable = crtc_state->has_psr && psr_global_enabled(psr->debug); > + enable = crtc_state->has_psr && psr_global_enabled(dev_priv); > psr2_enable = intel_psr2_enabled(dev_priv, crtc_state); > > if (enable == psr->enabled && psr2_enable == psr->psr2_enabled) { > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled() 2020-02-10 11:00 ` [Intel-gfx] [PATCH] " Mika Kuoppala @ 2020-02-10 12:59 ` Jani Nikula 0 siblings, 0 replies; 5+ messages in thread From: Jani Nikula @ 2020-02-10 12:59 UTC (permalink / raw) To: Mika Kuoppala, intel-gfx On Mon, 10 Feb 2020, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote: > Jani Nikula <jani.nikula@intel.com> writes: > >> Make future work slightly easier. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Pushed to dinq, thanks for the review. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c >> index db3d1561e9bf..e86e9dc1fe06 100644 >> --- a/drivers/gpu/drm/i915/display/intel_psr.c >> +++ b/drivers/gpu/drm/i915/display/intel_psr.c >> @@ -61,9 +61,9 @@ >> * must be correctly synchronized/cancelled when shutting down the pipe." >> */ >> >> -static bool psr_global_enabled(u32 debug) >> +static bool psr_global_enabled(struct drm_i915_private *i915) >> { >> - switch (debug & I915_PSR_DEBUG_MODE_MASK) { >> + switch (i915->psr.debug & I915_PSR_DEBUG_MODE_MASK) { >> case I915_PSR_DEBUG_DEFAULT: >> return i915_modparams.enable_psr; >> case I915_PSR_DEBUG_DISABLE: >> @@ -930,7 +930,7 @@ void intel_psr_enable(struct intel_dp *intel_dp, >> >> mutex_lock(&dev_priv->psr.lock); >> >> - if (!psr_global_enabled(dev_priv->psr.debug)) { >> + if (!psr_global_enabled(dev_priv)) { >> drm_dbg_kms(&dev_priv->drm, "PSR disabled by flag\n"); >> goto unlock; >> } >> @@ -1085,7 +1085,7 @@ void intel_psr_update(struct intel_dp *intel_dp, >> >> mutex_lock(&dev_priv->psr.lock); >> >> - enable = crtc_state->has_psr && psr_global_enabled(psr->debug); >> + enable = crtc_state->has_psr && psr_global_enabled(dev_priv); >> psr2_enable = intel_psr2_enabled(dev_priv, crtc_state); >> >> if (enable == psr->enabled && psr2_enable == psr->psr2_enabled) { >> -- >> 2.20.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-10 12:59 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-04 13:52 [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled() Jani Nikula 2020-02-05 2:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-02-07 6:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-02-10 11:00 ` [Intel-gfx] [PATCH] " Mika Kuoppala 2020-02-10 12:59 ` Jani Nikula
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.