From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Amol Grover <frextrite@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Joel Fernandes <joel@joelfernandes.org>,
Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Amol Grover <frextrite@gmail.com>
Subject: Re: [PATCH] bpf: devmap: Pass lockdep expression to RCU lists
Date: Thu, 23 Jan 2020 14:38:10 +0100 [thread overview]
Message-ID: <87d0ba9ttp.fsf@toke.dk> (raw)
In-Reply-To: <20200123120437.26506-1-frextrite@gmail.com>
Amol Grover <frextrite@gmail.com> writes:
> head is traversed using hlist_for_each_entry_rcu outside an
> RCU read-side critical section but under the protection
> of dtab->index_lock.
>
> Hence, add corresponding lockdep expression to silence false-positive
> lockdep warnings, and harden RCU lists.
>
> Signed-off-by: Amol Grover <frextrite@gmail.com>
Could you please add an appropriate Fixes: tag?
Otherwise:
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Amol Grover <frextrite@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Joel Fernandes <joel@joelfernandes.org>,
bpf@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] bpf: devmap: Pass lockdep expression to RCU lists
Date: Thu, 23 Jan 2020 14:38:10 +0100 [thread overview]
Message-ID: <87d0ba9ttp.fsf@toke.dk> (raw)
In-Reply-To: <20200123120437.26506-1-frextrite@gmail.com>
Amol Grover <frextrite@gmail.com> writes:
> head is traversed using hlist_for_each_entry_rcu outside an
> RCU read-side critical section but under the protection
> of dtab->index_lock.
>
> Hence, add corresponding lockdep expression to silence false-positive
> lockdep warnings, and harden RCU lists.
>
> Signed-off-by: Amol Grover <frextrite@gmail.com>
Could you please add an appropriate Fixes: tag?
Otherwise:
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-01-23 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 12:04 [PATCH] bpf: devmap: Pass lockdep expression to RCU lists Amol Grover
2020-01-23 12:04 ` [Linux-kernel-mentees] " Amol Grover
2020-01-23 13:37 ` Jesper Dangaard Brouer
2020-01-23 13:37 ` [Linux-kernel-mentees] " Jesper Dangaard Brouer
2020-01-23 13:42 ` Toke Høiland-Jørgensen
2020-01-23 13:42 ` [Linux-kernel-mentees] " Toke Høiland-Jørgensen
2020-01-23 17:10 ` Amol Grover
2020-01-23 17:10 ` [Linux-kernel-mentees] " Amol Grover
2020-01-23 13:38 ` Toke Høiland-Jørgensen [this message]
2020-01-23 13:38 ` Toke Høiland-Jørgensen
2020-01-23 15:59 ` Daniel Borkmann
2020-01-23 15:59 ` [Linux-kernel-mentees] " Daniel Borkmann
2020-01-23 17:18 ` Amol Grover
2020-01-23 17:18 ` [Linux-kernel-mentees] " Amol Grover
2020-01-23 22:04 ` Daniel Borkmann
2020-01-23 22:04 ` [Linux-kernel-mentees] " Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0ba9ttp.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=frextrite@gmail.com \
--cc=hawk@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=joel@joelfernandes.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.