Re: [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Jani Nikula <jani.nikula@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum
Date: Tue, 29 Oct 2019 11:27:20 +0200	[thread overview]
Message-ID: <87d0efaolj.fsf@intel.com> (raw)
In-Reply-To: <157233975222.4967.10493169909668288037@jlahtine-desk.ger.corp.intel.com>

On Tue, 29 Oct 2019, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> Quoting Jani Nikula (2019-10-28 12:38:20)
>> Mostly for improved documentation, convert the debug category macros
>> into an enum. Drop unused DRM_UT_NONE. Document previously undocumented
>> categories.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> <SNIP>
>
>> +enum drm_debug_category {
>> +       /**
>> +        * @DRM_UT_CORE: Used in the generic drm code: drm_ioctl.c, drm_mm.c,
>> +        * drm_memory.c, ...
>> +        */
>> +       DRM_UT_CORE             = 0x01,
>
> While here, why not BIT()

Thought about it, but since this is what folks look at when adding the
drm.debug module parameter, it's perhaps easier to combine the hex
values than just the bit positions? *shrug* Could go either way.

BR,
Jani.


>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Regards, Joonas

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)

From: Jani Nikula <jani.nikula@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum
Date: Tue, 29 Oct 2019 11:27:20 +0200	[thread overview]
Message-ID: <87d0efaolj.fsf@intel.com> (raw)
Message-ID: <20191029092720.WNmUED9fbtyvot-R6mnz3DLTKQy6kUGk31c5Ukvz6b8@z> (raw)
In-Reply-To: <157233975222.4967.10493169909668288037@jlahtine-desk.ger.corp.intel.com>

On Tue, 29 Oct 2019, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> Quoting Jani Nikula (2019-10-28 12:38:20)
>> Mostly for improved documentation, convert the debug category macros
>> into an enum. Drop unused DRM_UT_NONE. Document previously undocumented
>> categories.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> <SNIP>
>
>> +enum drm_debug_category {
>> +       /**
>> +        * @DRM_UT_CORE: Used in the generic drm code: drm_ioctl.c, drm_mm.c,
>> +        * drm_memory.c, ...
>> +        */
>> +       DRM_UT_CORE             = 0x01,
>
> While here, why not BIT()

Thought about it, but since this is what folks look at when adding the
drm.debug module parameter, it's perhaps easier to combine the hex
values than just the bit positions? *shrug* Could go either way.

BR,
Jani.


>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Regards, Joonas

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)

From: Jani Nikula <jani.nikula@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum
Date: Tue, 29 Oct 2019 11:27:20 +0200	[thread overview]
Message-ID: <87d0efaolj.fsf@intel.com> (raw)
Message-ID: <20191029092720.JHG_aaG9VLIFTLMYwFhc3LvbKx8_MsTxinqWJ8P1PXI@z> (raw)
In-Reply-To: <157233975222.4967.10493169909668288037@jlahtine-desk.ger.corp.intel.com>

On Tue, 29 Oct 2019, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> Quoting Jani Nikula (2019-10-28 12:38:20)
>> Mostly for improved documentation, convert the debug category macros
>> into an enum. Drop unused DRM_UT_NONE. Document previously undocumented
>> categories.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> <SNIP>
>
>> +enum drm_debug_category {
>> +       /**
>> +        * @DRM_UT_CORE: Used in the generic drm code: drm_ioctl.c, drm_mm.c,
>> +        * drm_memory.c, ...
>> +        */
>> +       DRM_UT_CORE             = 0x01,
>
> While here, why not BIT()

Thought about it, but since this is what folks look at when adding the
drm.debug module parameter, it's perhaps easier to combine the hex
values than just the bit positions? *shrug* Could go either way.

BR,
Jani.


>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Regards, Joonas

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

next prev parent reply	other threads:[~2019-10-29  9:27 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 10:38 [PATCH RESEND 0/8] drm/print: cleanup and new drm_device based logging Jani Nikula
2019-10-28 10:38 ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 1/8] drm/i915: use drm_debug_enabled() to check for debug categories Jani Nikula
2019-10-28 10:38   ` [Intel-gfx] " Jani Nikula
     [not found] ` <cover.1572258935.git.jani.nikula-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-10-28 10:38   ` [PATCH RESEND 2/8] drm/nouveau: " Jani Nikula
2019-10-28 10:38     ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38     ` Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 3/8] drm/amdgpu: " Jani Nikula
2019-10-28 10:38   ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38   ` Jani Nikula
2019-10-28 10:38   ` Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 4/8] drm/print: rename drm_debug to __drm_debug to discourage use Jani Nikula
2019-10-28 10:38   ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 5/8] drm/print: underscore prefix functions that should be private to print Jani Nikula
2019-10-28 10:38   ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38   ` Jani Nikula
2019-11-01 20:16   ` Rodrigo Vivi
2019-11-01 20:16     ` [Intel-gfx] " Rodrigo Vivi
2019-11-01 20:16     ` Rodrigo Vivi
2019-10-28 10:38 ` [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum Jani Nikula
2019-10-28 10:38   ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38   ` Jani Nikula
2019-10-29  9:02   ` Joonas Lahtinen
2019-10-29  9:02     ` [Intel-gfx] " Joonas Lahtinen
2019-10-29  9:02     ` Joonas Lahtinen
2019-10-29  9:27     ` Jani Nikula [this message]
2019-10-29  9:27       ` Jani Nikula
2019-10-29  9:27       ` Jani Nikula
2019-10-28 10:38 ` [PATCH RESEND 7/8] drm/print: group logging functions by prink or device based Jani Nikula
2019-10-28 10:38   ` [Intel-gfx] " Jani Nikula
2019-11-01 20:25   ` Rodrigo Vivi
2019-11-01 20:25     ` [Intel-gfx] " Rodrigo Vivi
2019-11-01 20:25     ` Rodrigo Vivi
2019-10-28 10:38 ` [PATCH RESEND 8/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-10-28 10:38   ` [Intel-gfx] " Jani Nikula
2019-10-28 10:38   ` Jani Nikula
2019-10-28 17:09   ` Ville Syrjälä
2019-10-28 17:09     ` [Intel-gfx] " Ville Syrjälä
2019-10-28 17:09     ` Ville Syrjälä
2019-11-01 20:27   ` Rodrigo Vivi
2019-11-01 20:27     ` [Intel-gfx] " Rodrigo Vivi
2019-11-01 20:27     ` Rodrigo Vivi
2019-10-28 13:28 ` ✗ Fi.CI.CHECKPATCH: warning for drm/print: cleanup and new drm_device based logging (rev2) Patchwork
2019-10-28 13:28   ` [Intel-gfx] " Patchwork
2019-10-28 13:49 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-28 13:49   ` [Intel-gfx] " Patchwork
2019-10-28 18:49 ` ✗ Fi.CI.CHECKPATCH: warning for drm/print: cleanup and new drm_device based logging (rev3) Patchwork
2019-10-28 18:49   ` [Intel-gfx] " Patchwork
2019-10-28 19:30 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-28 19:30   ` [Intel-gfx] " Patchwork
2019-10-29 13:57 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-29 13:57   ` [Intel-gfx] " Patchwork
2019-11-12 15:21 ` [PATCH RESEND 0/8] drm/print: cleanup and new drm_device based logging Sean Paul
2019-11-12 15:21   ` [Intel-gfx] " Sean Paul
2019-11-12 15:21   ` Sean Paul
2019-11-14 12:27   ` Jani Nikula
2019-11-14 12:27     ` [Intel-gfx] " Jani Nikula
2019-11-14 12:27     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0efaolj.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.