From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: arnd@arndb.de, dedekind1@gmail.com, y2038@lists.linaro.org,
gregkh@linuxfoundation.org, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, tj@kernel.org,
linux-mtd@lists.infradead.org, viro@zeniv.linux.org.uk,
richard@nod.at, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-ntfs-dev@lists.sourceforge.net, hch@lst.de,
anton@tuxera.com, jlbec@evilplan.org
Subject: Re: [f2fs-dev] [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc
Date: Tue, 30 Jul 2019 17:27:00 +0900 [thread overview]
Message-ID: <87d0hsapwr.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20190730014924.2193-4-deepa.kernel@gmail.com> (Deepa Dinamani's message of "Mon, 29 Jul 2019 18:49:07 -0700")
Deepa Dinamani <deepa.kernel@gmail.com> writes:
> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> index 1e08bd54c5fb..53bb7c6bf993 100644
> --- a/fs/fat/misc.c
> +++ b/fs/fat/misc.c
> @@ -307,8 +307,9 @@ int fat_truncate_time(struct inode *inode, struct timespec64 *now, int flags)
> inode->i_atime = (struct timespec64){ seconds, 0 };
> }
> if (flags & S_CTIME) {
> - if (sbi->options.isvfat)
> - inode->i_ctime = timespec64_trunc(*now, 10000000);
> + if (sbi->options.isvfat) {
> + inode->i_ctime = timestamp_truncate(*now, inode);
> + }
> else
> inode->i_ctime = fat_timespec64_trunc_2secs(*now);
> }
Looks like broken. It changed to sb->s_time_gran from 10000000, and
changed coding style.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: arnd@arndb.de, dedekind1@gmail.com, y2038@lists.linaro.org,
gregkh@linuxfoundation.org, yuchao0@huawei.com,
adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
tj@kernel.org, linux-mtd@lists.infradead.org,
viro@zeniv.linux.org.uk, richard@nod.at,
linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ntfs-dev@lists.sourceforge.net, hch@lst.de,
anton@tuxera.com, jlbec@evilplan.org
Subject: Re: [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc
Date: Tue, 30 Jul 2019 17:27:00 +0900 [thread overview]
Message-ID: <87d0hsapwr.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20190730014924.2193-4-deepa.kernel@gmail.com> (Deepa Dinamani's message of "Mon, 29 Jul 2019 18:49:07 -0700")
Deepa Dinamani <deepa.kernel@gmail.com> writes:
> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> index 1e08bd54c5fb..53bb7c6bf993 100644
> --- a/fs/fat/misc.c
> +++ b/fs/fat/misc.c
> @@ -307,8 +307,9 @@ int fat_truncate_time(struct inode *inode, struct timespec64 *now, int flags)
> inode->i_atime = (struct timespec64){ seconds, 0 };
> }
> if (flags & S_CTIME) {
> - if (sbi->options.isvfat)
> - inode->i_ctime = timespec64_trunc(*now, 10000000);
> + if (sbi->options.isvfat) {
> + inode->i_ctime = timestamp_truncate(*now, inode);
> + }
> else
> inode->i_ctime = fat_timespec64_trunc_2secs(*now);
> }
Looks like broken. It changed to sb->s_time_gran from 10000000, and
changed coding style.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, arnd@arndb.de,
y2038@lists.linaro.org, adrian.hunter@intel.com,
anton@tuxera.com, dedekind1@gmail.com,
gregkh@linuxfoundation.org, hch@lst.de, jaegeuk@kernel.org,
jlbec@evilplan.org, richard@nod.at, tj@kernel.org,
yuchao0@huawei.com, linux-f2fs-devel@lists.sourceforge.net,
linux-ntfs-dev@lists.sourceforge.net,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc
Date: Tue, 30 Jul 2019 17:27:00 +0900 [thread overview]
Message-ID: <87d0hsapwr.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20190730014924.2193-4-deepa.kernel@gmail.com> (Deepa Dinamani's message of "Mon, 29 Jul 2019 18:49:07 -0700")
Deepa Dinamani <deepa.kernel@gmail.com> writes:
> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> index 1e08bd54c5fb..53bb7c6bf993 100644
> --- a/fs/fat/misc.c
> +++ b/fs/fat/misc.c
> @@ -307,8 +307,9 @@ int fat_truncate_time(struct inode *inode, struct timespec64 *now, int flags)
> inode->i_atime = (struct timespec64){ seconds, 0 };
> }
> if (flags & S_CTIME) {
> - if (sbi->options.isvfat)
> - inode->i_ctime = timespec64_trunc(*now, 10000000);
> + if (sbi->options.isvfat) {
> + inode->i_ctime = timestamp_truncate(*now, inode);
> + }
> else
> inode->i_ctime = fat_timespec64_trunc_2secs(*now);
> }
Looks like broken. It changed to sb->s_time_gran from 10000000, and
changed coding style.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2019-07-30 8:45 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 1:49 [PATCH 00/20] vfs: Add support for timestamp limits Deepa Dinamani
2019-07-30 1:49 ` Deepa Dinamani
2019-07-30 1:49 ` [f2fs-dev] " Deepa Dinamani
2019-07-30 1:49 ` Deepa Dinamani
2019-07-30 1:49 ` [PATCH 01/20] vfs: Add file timestamp range support Deepa Dinamani
2019-07-30 1:49 ` [PATCH 02/20] vfs: Add timestamp_truncate() api Deepa Dinamani
2019-07-30 1:49 ` [f2fs-dev] [PATCH 03/20] timestamp_truncate: Replace users of timespec64_trunc Deepa Dinamani
2019-07-30 1:49 ` Deepa Dinamani
2019-07-30 1:49 ` Deepa Dinamani
2019-07-30 8:27 ` OGAWA Hirofumi [this message]
2019-07-30 8:27 ` OGAWA Hirofumi
2019-07-30 8:27 ` OGAWA Hirofumi
2019-07-30 17:26 ` [f2fs-dev] " Deepa Dinamani
2019-07-30 17:26 ` Deepa Dinamani
2019-07-30 17:26 ` Deepa Dinamani
2019-07-30 22:28 ` [f2fs-dev] " Anton Altaparmakov
2019-07-30 22:28 ` Anton Altaparmakov
2019-07-30 22:28 ` Anton Altaparmakov
2019-07-31 0:08 ` [f2fs-dev] " Deepa Dinamani
2019-07-31 0:08 ` Deepa Dinamani
2019-07-31 0:08 ` Deepa Dinamani
2019-07-30 1:49 ` [PATCH 04/20] mount: Add mount warning for impending timestamp expiry Deepa Dinamani
2019-08-05 14:12 ` [Y2038] " Ben Hutchings
2019-08-05 14:40 ` Arnd Bergmann
2019-08-10 20:47 ` Deepa Dinamani
2019-08-05 14:14 ` Ben Hutchings
2019-08-10 20:44 ` Deepa Dinamani
2019-08-12 13:25 ` Ben Hutchings
2019-08-12 14:11 ` Arnd Bergmann
2019-08-12 16:09 ` Deepa Dinamani
2019-08-12 16:15 ` Deepa Dinamani
2019-08-12 17:43 ` Ben Hutchings
2019-07-30 1:49 ` [PATCH 05/20] utimes: Clamp the timestamps before update Deepa Dinamani
2019-07-31 15:14 ` Darrick J. Wong
2019-07-31 15:33 ` Deepa Dinamani
2019-08-05 13:30 ` [Y2038] " Ben Hutchings
2019-08-10 20:36 ` Deepa Dinamani
2019-07-30 1:49 ` [PATCH 06/20] fs: Fill in max and min timestamps in superblock Deepa Dinamani
2019-07-30 1:49 ` Deepa Dinamani
2019-07-30 1:49 ` Deepa Dinamani
2019-07-31 15:28 ` Darrick J. Wong
2019-07-31 15:28 ` Darrick J. Wong
2019-07-30 1:49 ` [PATCH 07/20] 9p: Fill min and max timestamps in sb Deepa Dinamani
2019-07-30 1:49 ` [PATCH 08/20] adfs: Fill in max and min " Deepa Dinamani
2019-07-30 1:49 ` [PATCH 09/20] ext4: Initialize timestamps limits Deepa Dinamani
2019-07-31 15:26 ` Darrick J. Wong
2019-08-01 19:18 ` Deepa Dinamani
2019-08-01 22:43 ` Theodore Y. Ts'o
2019-08-02 10:39 ` Arnd Bergmann
2019-08-02 15:43 ` Theodore Y. Ts'o
2019-08-02 19:00 ` Arnd Bergmann
2019-08-02 21:39 ` Theodore Y. Ts'o
2019-08-03 9:30 ` Arnd Bergmann
2019-08-03 16:02 ` Theodore Y. Ts'o
2019-08-03 20:24 ` Arnd Bergmann
2019-08-07 18:04 ` Andreas Dilger
2019-08-08 18:27 ` Deepa Dinamani
2019-07-30 1:49 ` [PATCH 10/20] fs: nfs: Initialize filesystem timestamp ranges Deepa Dinamani
2019-07-30 1:49 ` [PATCH 11/20] fs: cifs: " Deepa Dinamani
2019-07-30 1:49 ` [PATCH 12/20] fs: fat: " Deepa Dinamani
2019-07-30 9:31 ` OGAWA Hirofumi
2019-07-30 17:39 ` Deepa Dinamani
2019-07-31 0:48 ` OGAWA Hirofumi
2019-07-30 1:49 ` [PATCH 13/20] fs: affs: " Deepa Dinamani
2019-08-01 11:28 ` David Sterba
2019-07-30 1:49 ` [PATCH 14/20] fs: sysv: " Deepa Dinamani
2019-07-30 1:49 ` [PATCH 15/20] fs: ceph: " Deepa Dinamani
2019-07-30 1:49 ` [PATCH 16/20] fs: orangefs: " Deepa Dinamani
2019-07-30 1:49 ` [PATCH 17/20] fs: hpfs: " Deepa Dinamani
2019-07-30 1:49 ` [PATCH 18/20] fs: omfs: " Deepa Dinamani
2019-07-30 14:25 ` Bob Copeland
2019-07-30 1:49 ` [PATCH 19/20] pstore: fs superblock limits Deepa Dinamani
2019-07-30 4:31 ` Kees Cook
2019-07-30 7:36 ` Arnd Bergmann
2019-08-02 2:26 ` Deepa Dinamani
2019-08-02 7:15 ` Arnd Bergmann
2019-08-18 14:00 ` Deepa Dinamani
2019-07-30 1:49 ` [PATCH 20/20] isofs: Initialize filesystem timestamp ranges Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0hsapwr.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=adrian.hunter@intel.com \
--cc=anton@tuxera.com \
--cc=arnd@arndb.de \
--cc=dedekind1@gmail.com \
--cc=deepa.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=jlbec@evilplan.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=richard@nod.at \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.