From: Kalle Valo <kvalo@codeaurora.org>
To: Rakesh Pillai <pillair@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: Fix rate table updation in tx stats
Date: Fri, 03 May 2019 10:04:50 +0300 [thread overview]
Message-ID: <87d0l0koh9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <edfbff30627849996b0597b964ed018c@codeaurora.org> (Rakesh Pillai's message of "Fri, 03 May 2019 12:26:31 +0530")
(please don't top post, fixing that manually)
Rakesh Pillai <pillair@codeaurora.org> writes:
> On 2019-05-03 11:30, Kalle Valo wrote:
>> Rakesh Pillai <pillair@codeaurora.org> wrote:
>>
>>> The index for updating rate table, which is displayed
>>> in the tx stats via debugfs, is calculated using the
>>> bandwidth value. The bandwidth values do not map
>>> correctly with the bandwidth values shown in the rate table.
>>>
>>> Correct the bandwidth value calculation which is used
>>> to calculate the index for rate table updation for tx stats.
>>>
>>> Tested HW: WCN3990
>>> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
>>>
>>> Fixes: e88975ca37d1 ("ath10k: dump tx stats in rate table format")
>>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>>
>> Fails to compile:
>>
>> drivers/net/wireless/ath/ath10k/htt_rx.c: In function
>> 'ath10k_accumulate_per_peer_tx_stats':
>> drivers/net/wireless/ath/ath10k/htt_rx.c:3252:14: error: implicit
>> declaration of function 'ath10k_get_bw'; did you mean
>> 'ath10k_get_tid'? [-Werror=implicit-function-declaration]
>> rtable_bw = ath10k_get_bw(&ar->hw_params, pstats->flags);
>> ^~~~~~~~~~~~~
>> ath10k_get_tid
>
> This set of patches is dependent on
> https://patchwork.kernel.org/patch/10831319/
> I can send out v2 for this patchset, marking the dependency, if needed.
Ok, I added this patchset back to my queue. No need to resend.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Rakesh Pillai <pillair@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] ath10k: Fix rate table updation in tx stats
Date: Fri, 03 May 2019 10:04:50 +0300 [thread overview]
Message-ID: <87d0l0koh9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <edfbff30627849996b0597b964ed018c@codeaurora.org> (Rakesh Pillai's message of "Fri, 03 May 2019 12:26:31 +0530")
(please don't top post, fixing that manually)
Rakesh Pillai <pillair@codeaurora.org> writes:
> On 2019-05-03 11:30, Kalle Valo wrote:
>> Rakesh Pillai <pillair@codeaurora.org> wrote:
>>
>>> The index for updating rate table, which is displayed
>>> in the tx stats via debugfs, is calculated using the
>>> bandwidth value. The bandwidth values do not map
>>> correctly with the bandwidth values shown in the rate table.
>>>
>>> Correct the bandwidth value calculation which is used
>>> to calculate the index for rate table updation for tx stats.
>>>
>>> Tested HW: WCN3990
>>> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
>>>
>>> Fixes: e88975ca37d1 ("ath10k: dump tx stats in rate table format")
>>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>>
>> Fails to compile:
>>
>> drivers/net/wireless/ath/ath10k/htt_rx.c: In function
>> 'ath10k_accumulate_per_peer_tx_stats':
>> drivers/net/wireless/ath/ath10k/htt_rx.c:3252:14: error: implicit
>> declaration of function 'ath10k_get_bw'; did you mean
>> 'ath10k_get_tid'? [-Werror=implicit-function-declaration]
>> rtable_bw = ath10k_get_bw(&ar->hw_params, pstats->flags);
>> ^~~~~~~~~~~~~
>> ath10k_get_tid
>
> This set of patches is dependent on
> https://patchwork.kernel.org/patch/10831319/
> I can send out v2 for this patchset, marking the dependency, if needed.
Ok, I added this patchset back to my queue. No need to resend.
--
Kalle Valo
next prev parent reply other threads:[~2019-05-03 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 15:53 [PATCH 0/2] Fix tx stats inconsistencies Rakesh Pillai
2019-03-11 15:53 ` Rakesh Pillai
2019-03-11 15:53 ` [PATCH 1/2] ath10k: Fix rate table updation in tx stats Rakesh Pillai
2019-03-11 15:53 ` Rakesh Pillai
2019-03-11 22:58 ` kbuild test robot
2019-03-11 22:58 ` kbuild test robot
2019-03-11 23:01 ` kbuild test robot
2019-03-11 23:01 ` kbuild test robot
2019-05-03 6:00 ` Kalle Valo
2019-05-03 6:00 ` Kalle Valo
[not found] ` <20190503060032.23F1C61195@smtp.codeaurora.org>
2019-05-03 6:56 ` Rakesh Pillai
2019-05-03 6:56 ` Rakesh Pillai
2019-05-03 7:04 ` Kalle Valo [this message]
2019-05-03 7:04 ` Kalle Valo
2019-09-23 8:22 ` Kalle Valo
2019-09-23 8:22 ` Kalle Valo
2019-03-11 15:53 ` [PATCH 2/2] ath10k: Fix NSS tx stats for legacy rates Rakesh Pillai
2019-03-11 15:53 ` Rakesh Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0l0koh9.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.