All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	IGT development <igt-dev@lists.freedesktop.org>
Cc: Petri Latvala <petri.latvala@intel.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Dave Airlie <airlied@redhat.com>, Sean Paul <sean@poorly.run>
Subject: Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory
Date: Wed, 16 Jan 2019 14:41:21 -0800	[thread overview]
Message-ID: <87d0owgr8u.fsf@anholt.net> (raw)
In-Reply-To: <20190116163903.12785-1-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 1742 bytes --]

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
>   and a sysroot build (should address all the build/cross platform
>   concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
>   don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
>   igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

igt is a bit awkward to work in (the mailing list is very noisy with the
Intel CI being email-based instead of gitlab-based and most of the
traffic being Intel), but it's the right place to be putting shared
tests and hopefully that pain point goes away eventually using gitlab
MRs.

I think there are going to be some interesting questions on how to deal
with things like KMS properties that aren't amenable to
chamelium/writeback-based testing.  However, we should default to
requiring tests and only skip that when we agree collectively that
something isn't testable currently.

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: DRI Development <dri-devel@lists.freedesktop.org>,
	IGT development <igt-dev@lists.freedesktop.org>
Cc: Petri Latvala <petri.latvala@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Dave Airlie <airlied@redhat.com>,
	Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
	Sean Paul <sean@poorly.run>
Subject: Re: [PATCH] drm/doc: Make igts for cross-driver stuff mandatory
Date: Wed, 16 Jan 2019 14:41:21 -0800	[thread overview]
Message-ID: <87d0owgr8u.fsf@anholt.net> (raw)
In-Reply-To: <20190116163903.12785-1-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 1742 bytes --]

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
>   and a sysroot build (should address all the build/cross platform
>   concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
>   don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
>   igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

igt is a bit awkward to work in (the mailing list is very noisy with the
Intel CI being email-based instead of gitlab-based and most of the
traffic being Intel), but it's the right place to be putting shared
tests and hopefully that pain point goes away eventually using gitlab
MRs.

I think there are going to be some interesting questions on how to deal
with things like KMS properties that aren't amenable to
chamelium/writeback-based testing.  However, we should default to
requiring tests and only skip that when we agree collectively that
something isn't testable currently.

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-01-16 22:41 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 16:39 [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory Daniel Vetter
2019-01-16 16:39 ` Daniel Vetter
2019-01-16 22:41 ` Eric Anholt [this message]
2019-01-16 22:41   ` Eric Anholt
2019-01-17 11:50   ` [igt-dev] " Daniel Vetter
2019-01-17 11:50     ` Daniel Vetter
2019-01-17 11:01 ` [igt-dev] " Arkadiusz Hiler
2019-01-17 11:01   ` Arkadiusz Hiler
2019-01-17 11:09   ` [igt-dev] " Petri Latvala
2019-01-17 11:09     ` Petri Latvala
2019-01-17 11:38 ` [igt-dev] " Liviu Dudau
2019-01-17 11:38   ` Liviu Dudau
2019-01-17 11:52   ` [igt-dev] " Daniel Vetter
2019-01-17 11:52     ` Daniel Vetter
2019-01-17 12:26     ` [igt-dev] " Liviu Dudau
2019-01-17 12:26       ` Liviu Dudau
2019-01-17 12:32       ` [igt-dev] " Daniel Vetter
2019-01-17 12:32         ` Daniel Vetter
2019-01-17 14:54         ` [igt-dev] " Liviu Dudau
2019-01-17 14:54           ` Liviu Dudau
2019-01-17 15:59           ` [igt-dev] " Daniel Vetter
2019-01-17 15:59             ` Daniel Vetter
2019-01-18 11:19             ` [igt-dev] " Liviu Dudau
2019-01-18 11:19               ` Liviu Dudau
2019-01-21 11:54     ` Brian Starkey
2019-01-21 17:21       ` Daniel Vetter
2019-01-22  8:53         ` [igt-dev] " Daniel Vetter
2019-01-22  8:53           ` Daniel Vetter
2019-01-22 13:27           ` [igt-dev] " Brian Starkey
2019-01-22 13:27             ` Brian Starkey
2019-01-22 14:03             ` [igt-dev] " Daniel Vetter
2019-01-22 14:03               ` Daniel Vetter
2019-01-22 15:08               ` [igt-dev] " Brian Starkey
2019-01-22 15:08                 ` Brian Starkey
2019-01-22 15:17                 ` [igt-dev] " Daniel Vetter
2019-01-22 15:17                   ` Daniel Vetter
2019-01-22 16:11                   ` [igt-dev] " Sean Paul
2019-01-22 16:11                     ` Sean Paul
2019-01-22 16:28                     ` [igt-dev] " Daniel Vetter
2019-01-22 16:28                       ` Daniel Vetter
2019-01-28 14:03                       ` [igt-dev] " Liviu Dudau
2019-01-28 14:03                         ` Liviu Dudau
2019-01-28 17:21                         ` [igt-dev] " Daniel Vetter
2019-01-28 17:21                           ` Daniel Vetter
2019-01-22 19:00 ` [igt-dev] " Wentland, Harry
2019-01-22 19:00   ` Wentland, Harry
2019-01-22 19:19   ` Daniel Vetter
2019-01-22 19:19     ` Daniel Vetter
2019-01-22 19:42     ` Wentland, Harry
2019-01-22 19:42       ` Wentland, Harry
2019-01-22 19:53       ` Sean Paul
2019-01-22 19:53         ` Sean Paul
2019-01-23  9:46         ` Brian Starkey
2019-01-23  9:46           ` Brian Starkey
2019-01-23 10:03       ` Daniel Stone
2019-01-23 10:03         ` Daniel Stone
2019-01-23 10:11         ` Jani Nikula
2019-01-23 10:11           ` Jani Nikula
2019-01-23 10:53           ` Daniel Vetter
2019-01-23 10:53             ` Daniel Vetter
2019-01-23 10:03       ` Jani Nikula
2019-01-23 10:54         ` Daniel Vetter
2019-01-23 10:54           ` Daniel Vetter
2019-01-23  9:40     ` Brian Starkey
2019-01-23  9:40       ` Brian Starkey
2019-01-23 10:50       ` Daniel Vetter
2019-01-23 10:50         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0owgr8u.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=liviu.dudau@arm.com \
    --cc=petri.latvala@intel.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.