From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Loic Poulain <loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] wcn36xx: Fix WEP encryption
Date: Thu, 14 Jun 2018 17:28:56 +0300 [thread overview]
Message-ID: <87d0wt8ms7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1527506960-13358-3-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> (Loic Poulain's message of "Mon, 28 May 2018 13:29:20 +0200")
Loic Poulain <loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> writes:
> In case of WEP encryption, driver has to configure shared key for
> associated station(s). Note that sta pointer is NULL in case of non
> pairwise key, causing NULL pointer dereference with existing code
> (sta_priv->is_data_encrypted). Fix this by using associated sta list
> instead.
>
> Signed-off-by: Loic Poulain <loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
I guess this fix is for AP mode with WEP encryption? And client mode
with WEP doesn't have any issues?
If yes, I'll clarify that in the commit log.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/3] wcn36xx: Fix WEP encryption
Date: Thu, 14 Jun 2018 17:28:56 +0300 [thread overview]
Message-ID: <87d0wt8ms7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1527506960-13358-3-git-send-email-loic.poulain@linaro.org> (Loic Poulain's message of "Mon, 28 May 2018 13:29:20 +0200")
Loic Poulain <loic.poulain@linaro.org> writes:
> In case of WEP encryption, driver has to configure shared key for
> associated station(s). Note that sta pointer is NULL in case of non
> pairwise key, causing NULL pointer dereference with existing code
> (sta_priv->is_data_encrypted). Fix this by using associated sta list
> instead.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
I guess this fix is for AP mode with WEP encryption? And client mode
with WEP doesn't have any issues?
If yes, I'll clarify that in the commit log.
--
Kalle Valo
next prev parent reply other threads:[~2018-06-14 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 11:29 [PATCH 1/3] wcn36xx: Fix WEP104 encryption type Loic Poulain
2018-05-28 11:29 ` Loic Poulain
[not found] ` <1527506960-13358-1-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-05-28 11:29 ` [PATCH 2/3] wcn36xx: Track associated stations Loic Poulain
2018-05-28 11:29 ` Loic Poulain
2018-05-28 11:29 ` [PATCH 3/3] wcn36xx: Fix WEP encryption Loic Poulain
2018-05-28 11:29 ` Loic Poulain
[not found] ` <1527506960-13358-3-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-06-14 14:28 ` Kalle Valo [this message]
2018-06-14 14:28 ` Kalle Valo
2018-06-14 14:24 ` [PATCH 1/3] wcn36xx: Fix WEP104 encryption type Kalle Valo
2018-06-14 14:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0wt8ms7.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.