All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Update preproduction steppings
@ 2018-06-06 14:18 Mika Kuoppala
  2018-06-06 14:28 ` Chris Wilson
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Mika Kuoppala @ 2018-06-06 14:18 UTC (permalink / raw)
  To: intel-gfx

Update preproduction steppings detection so that
we get the warning and taint correctly for more
recent platforms.

Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 4 ++++
 drivers/gpu/drm/i915/i915_drv.h | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 6b599b1837dc..166ff1707522 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -857,6 +857,10 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
 	pre |= IS_HSW_EARLY_SDV(dev_priv);
 	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
 	pre |= IS_BXT_REVID(dev_priv, 0, BXT_REVID_B_LAST);
+	pre |= IS_KBL_REVID(dev_priv, 0, KBL_REVID_A0);
+	pre |= IS_GLK_REVID(dev_priv, 0, GLK_REVID_B0);
+	pre |= IS_CNL_REVID(dev_priv, 0, CNL_REVID_G0);
+	pre |= IS_ICL_REVID(dev_priv, 0, ICL_REVID_C0);
 
 	if (pre) {
 		DRM_ERROR("This is a pre-production stepping. "
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index a4bb30c32a52..b36143a5451c 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2460,6 +2460,7 @@ intel_info(const struct drm_i915_private *dev_priv)
 
 #define GLK_REVID_A0		0x0
 #define GLK_REVID_A1		0x1
+#define GLK_REVID_B0		0x3
 
 #define IS_GLK_REVID(dev_priv, since, until) \
 	(IS_GEMINILAKE(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2467,6 +2468,8 @@ intel_info(const struct drm_i915_private *dev_priv)
 #define CNL_REVID_A0		0x0
 #define CNL_REVID_B0		0x1
 #define CNL_REVID_C0		0x2
+#define CNL_REVID_D0		0x4
+#define CNL_REVID_G0		0x5
 
 #define IS_CNL_REVID(p, since, until) \
 	(IS_CANNONLAKE(p) && IS_REVID(p, since, until))
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Update preproduction steppings
  2018-06-06 14:18 [PATCH] drm/i915: Update preproduction steppings Mika Kuoppala
@ 2018-06-06 14:28 ` Chris Wilson
  2018-06-07 15:07   ` Jani Nikula
  2018-06-06 14:38 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
  2018-06-06 14:57 ` ✗ Fi.CI.BAT: failure " Patchwork
  2 siblings, 1 reply; 5+ messages in thread
From: Chris Wilson @ 2018-06-06 14:28 UTC (permalink / raw)
  To: Mika Kuoppala, intel-gfx

Quoting Mika Kuoppala (2018-06-06 15:18:24)
> Update preproduction steppings detection so that
> we get the warning and taint correctly for more
> recent platforms.

Before crying foul, I suggest we check INTEL_INFO()->is_alpha_support.
We don't want to taint SDP boxes as we work on them for stabilisation.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* ✗ Fi.CI.SPARSE: warning for drm/i915: Update preproduction steppings
  2018-06-06 14:18 [PATCH] drm/i915: Update preproduction steppings Mika Kuoppala
  2018-06-06 14:28 ` Chris Wilson
@ 2018-06-06 14:38 ` Patchwork
  2018-06-06 14:57 ` ✗ Fi.CI.BAT: failure " Patchwork
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-06 14:38 UTC (permalink / raw)
  To: Mika Kuoppala; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Update preproduction steppings
URL   : https://patchwork.freedesktop.org/series/44355/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Commit: drm/i915: Update preproduction steppings
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3668:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3671:16: warning: expression using sizeof(void)

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Update preproduction steppings
  2018-06-06 14:18 [PATCH] drm/i915: Update preproduction steppings Mika Kuoppala
  2018-06-06 14:28 ` Chris Wilson
  2018-06-06 14:38 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2018-06-06 14:57 ` Patchwork
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-06 14:57 UTC (permalink / raw)
  To: Mika Kuoppala; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Update preproduction steppings
URL   : https://patchwork.freedesktop.org/series/44355/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4282 -> Patchwork_9219 =

== Summary - FAILURE ==

  Serious unknown changes coming with Patchwork_9219 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9219, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/44355/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9219:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_module_reload@basic-no-display:
      fi-glk-j4005:       PASS -> DMESG-WARN +1

    igt@drv_module_reload@basic-reload-inject:
      fi-cnl-y3:          NOTRUN -> DMESG-WARN +2

    
    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        SKIP -> PASS

    
== Known issues ==

  Here are the changes found in Patchwork_9219 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_mmap_gtt@basic-small-bo-tiledx:
      fi-gdg-551:         PASS -> FAIL (fdo#102575)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000) +1

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
      fi-cnl-psr:         PASS -> FAIL (fdo#103481)

    
    ==== Possible fixes ====

    igt@gem_sync@basic-each:
      fi-cnl-y3:          INCOMPLETE (fdo#105086) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    
  fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
  fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105086 https://bugs.freedesktop.org/show_bug.cgi?id=105086
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000


== Participating hosts (41 -> 37) ==

  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-skl-6700hq 


== Build changes ==

    * Linux: CI_DRM_4282 -> Patchwork_9219

  CI_DRM_4282: c1064b9be065603680d060184da1a93d404dcf0c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4508: 78a68c905066beeefd24b3a4518d817a811e8798 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9219: 099e09470dc9a27dda1e0b7bc14cb1a46b8de983 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

099e09470dc9 drm/i915: Update preproduction steppings

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9219/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Update preproduction steppings
  2018-06-06 14:28 ` Chris Wilson
@ 2018-06-07 15:07   ` Jani Nikula
  0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2018-06-07 15:07 UTC (permalink / raw)
  To: Chris Wilson, Mika Kuoppala, intel-gfx

On Wed, 06 Jun 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Mika Kuoppala (2018-06-06 15:18:24)
>> Update preproduction steppings detection so that
>> we get the warning and taint correctly for more
>> recent platforms.
>
> Before crying foul, I suggest we check INTEL_INFO()->is_alpha_support.
> We don't want to taint SDP boxes as we work on them for stabilisation.

Agreed.

> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-07 15:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-06 14:18 [PATCH] drm/i915: Update preproduction steppings Mika Kuoppala
2018-06-06 14:28 ` Chris Wilson
2018-06-07 15:07   ` Jani Nikula
2018-06-06 14:38 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2018-06-06 14:57 ` ✗ Fi.CI.BAT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.