From: Eric Anholt <eric@anholt.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/panel: rpi-touchscreen: propagate errors in rpi_touchscreen_i2c_read()
Date: Tue, 31 Oct 2017 00:02:13 +0000 [thread overview]
Message-ID: <87d154w5fe.fsf@anholt.net> (raw)
In-Reply-To: <20171020002845.kar2wg7gqxg7tzqi@mwanda>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
Dan Carpenter <dan.carpenter@oracle.com> writes:
> There is one caller which checks whether rpi_touchscreen_i2c_read()
> returns negative error codes. Currently it can't because negative
> error codes are truncated to u8, but that's easy to fix if we change the
> type to int.
Reviewed and applied to -next. Thanks!
(Not to -fixes because we're late in the cycle, we don't have an
upstream DT exposing the panel, and it seems unlikely that the error
value here would happen to collide with one of the 2 values of a valid
firmware revision)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/panel: rpi-touchscreen: propagate errors in rpi_touchscreen_i2c_read()
Date: Mon, 30 Oct 2017 17:02:13 -0700 [thread overview]
Message-ID: <87d154w5fe.fsf@anholt.net> (raw)
In-Reply-To: <20171020002845.kar2wg7gqxg7tzqi@mwanda>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
Dan Carpenter <dan.carpenter@oracle.com> writes:
> There is one caller which checks whether rpi_touchscreen_i2c_read()
> returns negative error codes. Currently it can't because negative
> error codes are truncated to u8, but that's easy to fix if we change the
> type to int.
Reviewed and applied to -next. Thanks!
(Not to -fixes because we're late in the cycle, we don't have an
upstream DT exposing the panel, and it seems unlikely that the error
value here would happen to collide with one of the 2 values of a valid
firmware revision)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-10-31 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 0:28 [PATCH] drm/panel: rpi-touchscreen: propagate errors in rpi_touchscreen_i2c_read() Dan Carpenter
2017-10-20 0:28 ` Dan Carpenter
2017-10-31 0:02 ` Eric Anholt [this message]
2017-10-31 0:02 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d154w5fe.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.