From: balbi@kernel.org (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error
Date: Thu, 30 Mar 2017 13:39:43 +0300 [thread overview]
Message-ID: <87d1czjbf4.fsf@linux.intel.com> (raw)
In-Reply-To: <676bd6d232af7ce08f2fb1f7e4188fc20ef751db.1490715349.git.cristian.birsan@microchip.com>
Hi,
cristian.birsan at microchip.com writes:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> Use dev_warn() to display EP configuration error to avoid silent failure.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 2bd8410..942c9c9 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
> * but it's clearly harmless...
> */
> if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED))
> - dev_dbg(&udc->pdev->dev,
> + dev_warn(&udc->pdev->dev,
seems like dev_err() would've been more fitting.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170330/594f62d6/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: cristian.birsan@microchip.com, nicolas.ferre@atmel.com,
gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ludovic.desroches@atmel.com,
alexandre.belloni@free-electrons.com,
boris.brezillon@free-electrons.com,
Cristian Birsan <cristian.birsan@microchip.com>
Subject: Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error
Date: Thu, 30 Mar 2017 13:39:43 +0300 [thread overview]
Message-ID: <87d1czjbf4.fsf@linux.intel.com> (raw)
In-Reply-To: <676bd6d232af7ce08f2fb1f7e4188fc20ef751db.1490715349.git.cristian.birsan@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
Hi,
cristian.birsan@microchip.com writes:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> Use dev_warn() to display EP configuration error to avoid silent failure.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 2bd8410..942c9c9 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
> * but it's clearly harmless...
> */
> if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED))
> - dev_dbg(&udc->pdev->dev,
> + dev_warn(&udc->pdev->dev,
seems like dev_err() would've been more fitting.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-03-30 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 16:07 [PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes cristian.birsan at microchip.com
2017-03-28 16:07 ` cristian.birsan
2017-03-28 16:07 ` [PATCH linux-next v2 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree cristian.birsan at microchip.com
2017-03-28 16:07 ` cristian.birsan
2017-03-30 10:38 ` Felipe Balbi
2017-03-30 10:38 ` Felipe Balbi
2017-03-28 16:07 ` [PATCH linux-next v2 2/4] usb: gadget: udc: atmel: Minor code cleanup cristian.birsan at microchip.com
2017-03-28 16:07 ` cristian.birsan
2017-03-28 16:07 ` [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error cristian.birsan at microchip.com
2017-03-28 16:07 ` cristian.birsan
2017-03-30 10:39 ` Felipe Balbi [this message]
2017-03-30 10:39 ` Felipe Balbi
2017-03-28 16:07 ` [PATCH linux-next v2 4/4] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0 cristian.birsan at microchip.com
2017-03-28 16:07 ` cristian.birsan
2017-03-29 8:38 ` [PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes Nicolas Ferre
2017-03-29 8:38 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1czjbf4.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.