From: Markus Armbruster <armbru@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] Why is "spapr-pci-host-bridge" no-user?
Date: Fri, 03 Jun 2016 08:40:43 +0200 [thread overview]
Message-ID: <87d1ny93mc.fsf@dusky.pond.sub.org> (raw)
Commit 09aa9a5 "spapr-pci: enable adding PHB via -device" set
cannot_instantiate_with_device_add_yet without also adding a comment
explaining why. It is currently the only one lacking such a comment.
Let's fix that.
Unfortunately, the commit message doesn't tell me (or I'm too dense to
understand it):
spapr-pci: enable adding PHB via -device
Recent changes introduced cannot_instantiate_with_device_add_yet
and removed capability of adding yet another PCI host bridge via
command line for SPAPR platform (POWERPC64 server).
This brings the capability back and puts SPAPR PHB into "bridge"
category.
This is not much use for emulated PHB but it is absolutely required
for VFIO as we put an IOMMU group onto a separate PHB on SPAPR.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alexander Graf <agraf@suse.de>
Alexey, can you explain why the device cannot be used with -device /
device_add?
next reply other threads:[~2016-06-03 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 6:40 Markus Armbruster [this message]
2016-06-03 8:40 ` [Qemu-devel] Why is "spapr-pci-host-bridge" no-user? Alexey Kardashevskiy
2016-06-03 11:36 ` Markus Armbruster
2016-06-03 11:52 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1ny93mc.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.