From: Juan Quintela <quintela@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Amit Shah <amit.shah@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devl <qemu-devel@nongnu.org>,
qemu block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage
Date: Mon, 23 Nov 2015 17:31:33 +0100 [thread overview]
Message-ID: <87d1v0isnu.fsf@emacs.mitica> (raw)
In-Reply-To: <564EE9C9.6000707@cn.fujitsu.com> (Wen Congyang's message of "Fri, 20 Nov 2015 17:37:13 +0800")
Wen Congyang <wency@cn.fujitsu.com> wrote:
> If we set migration speed in a very large value, block-migration will try to read
> all data to the memory. Because
> (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE
> will be overflow, and it will be always less than rate limit.
>
> There is no need to read too many data into memory when the rate limit is very large.
> So limit the memory usage can fix the overflow problem.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
If no block layer maintainer objects, I will apply this to my tree.
Later, Juan.
next prev parent reply other threads:[~2015-11-23 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 9:37 [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage Wen Congyang
2015-11-23 16:31 ` Juan Quintela [this message]
2015-11-24 4:47 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1v0isnu.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.