All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Shankar, Uma" <uma.shankar@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Kumar, Shobhit" <shobhit.kumar@intel.com>
Subject: Re: [BXT MIPI PATCH v4 05/14] drm/i915/bxt: DSI encoder support in CRTC modeset
Date: Thu, 01 Oct 2015 12:56:05 +0300	[thread overview]
Message-ID: <87d1wyc3pm.fsf@intel.com> (raw)
In-Reply-To: <E7C9878FBA1C6D42A1CA3F62AEB6945F580CD48B@BGSMSX104.gar.corp.intel.com>

On Wed, 30 Sep 2015, "Shankar, Uma" <uma.shankar@intel.com> wrote:
>>-----Original Message-----
>>From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>>Sent: Tuesday, September 29, 2015 12:59 PM
>>To: Shankar, Uma; intel-gfx@lists.freedesktop.org
>>Cc: Kumar, Shobhit; Deak, Imre; Sharma, Shashank
>>Subject: RE: [BXT MIPI PATCH v4 05/14] drm/i915/bxt: DSI encoder support in
>>CRTC modeset
>>
>>I just sent two patches [1][2] to modify ddi_get_encoder_port a
>>little. Rebase on top, and don't modify ddi_get_encoder_port() or
>>intel_ddi_get_encoder_port() at all. Just make sure you don't call the
>>functions for DSI. No need to add PORT_INVALID either.
>>
>>BR,
>>Jani.
>>
>
> Thanks Jani.  I will rebase and re-submit. Personally I feel this will
> be best approach as it will avoid the call itself.  However, only flip
> side is protection at multiple places in code for DSI.

As I explain in my review, it is not necessary to add those checks
everywhere.

BR,
Jani.

>>[1] http://mid.gmane.org/1443511466-8017-1-git-send-email-
>>jani.nikula@intel.com
>>[2] http://mid.gmane.org/1443511466-8017-2-git-send-email-
>>jani.nikula@intel.com

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-10-01  9:52 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 14:11 [BXT MIPI PATCH v3 00/14] MIPI DSI Support for BXT Uma Shankar
2015-09-01 14:11 ` [BXT MIPI PATCH v3 01/14] drm/i915/bxt: Initialize MIPI " Uma Shankar
2015-09-18 12:17   ` Jani Nikula
2015-09-23  8:08     ` Daniel Vetter
2015-09-01 14:11 ` [BXT MIPI PATCH v3 02/14] drm/i915/bxt: Enable BXT DSI PLL Uma Shankar
2015-09-18 12:32   ` Jani Nikula
2015-09-01 14:11 ` [BXT MIPI PATCH v3 03/14] drm/i915/bxt: Disable DSI PLL for BXT Uma Shankar
2015-09-18 12:57   ` Jani Nikula
2015-09-01 14:11 ` [BXT MIPI PATCH v3 04/14] drm/i915/bxt: DSI prepare changes " Uma Shankar
2015-09-18 13:05   ` Jani Nikula
2015-09-23  8:16     ` Daniel Vetter
2015-09-01 14:11 ` [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in CRTC modeset Uma Shankar
2015-09-18 14:18   ` Jani Nikula
2015-09-21 10:41     ` Shankar, Uma
2015-09-23  8:15       ` Daniel Vetter
2015-09-23 12:43         ` Jani Nikula
2015-09-23 13:11           ` Daniel Vetter
2015-09-23 14:44             ` Shankar, Uma
2015-09-23 12:53   ` Jani Nikula
2015-09-23 14:49     ` Shankar, Uma
2015-09-23 17:03       ` Shankar, Uma
2015-09-23 17:53         ` [BXT MIPI PATCH v4 " Uma Shankar
2015-09-28 13:28           ` Jani Nikula
2015-09-28 16:57             ` Shankar, Uma
2015-09-29  7:29               ` Jani Nikula
2015-09-30 16:33                 ` Shankar, Uma
2015-10-01  9:56                   ` Jani Nikula [this message]
2015-09-30 17:03                 ` [BXT MIPI PATCH v5 " Uma Shankar
2015-10-01  9:54                   ` Jani Nikula
2015-10-01 16:22                     ` Shankar, Uma
2015-10-01 16:53                     ` Uma Shankar
2015-10-02 11:05                       ` Jani Nikula
2015-10-02 12:34                       ` Daniel Vetter
2015-10-05 16:06                         ` Shankar, Uma
2015-10-06  6:05                           ` Jani Nikula
2015-09-01 14:11 ` [BXT MIPI PATCH v3 06/14] drm/i915/bxt: DSI enable for BXT Uma Shankar
2015-09-18 13:17   ` Jani Nikula
2015-09-21  9:33     ` Shankar, Uma
2015-09-01 14:11 ` [BXT MIPI PATCH v3 07/14] drm/i915/bxt: Program Tx Rx and Dphy clocks Uma Shankar
2015-09-18 13:27   ` Jani Nikula
2015-09-21 10:11     ` Shankar, Uma
2015-09-23 17:57     ` [BXT MIPI PATCH v4 " Uma Shankar
2015-09-28 13:04       ` Jani Nikula
2015-09-01 14:11 ` [BXT MIPI PATCH v3 08/14] drm/i915/bxt: DSI disable and post-disable Uma Shankar
2015-09-18 13:29   ` Jani Nikula
2015-09-01 14:11 ` [BXT MIPI PATCH v3 09/14] drm/i915/bxt: get_hw_state for BXT Uma Shankar
2015-09-18 13:30   ` Jani Nikula
2015-09-01 14:11 ` [BXT MIPI PATCH v3 10/14] drm/i915/bxt: get DSI pixelclock Uma Shankar
2015-09-18 13:30   ` Jani Nikula
2015-09-01 14:11 ` [BXT MIPI PATCH v3 11/14] drm/i915/bxt: Modify BXT BLC according to VBT changes Uma Shankar
2015-09-18 13:51   ` Jani Nikula
2015-09-21 10:26     ` Shankar, Uma
2015-09-23 17:59     ` [BXT MIPI PATCH v4 " Uma Shankar
2015-09-28 13:13       ` Jani Nikula
2015-09-30 17:04         ` [BXT MIPI PATCH v5 " Uma Shankar
2015-10-01 10:16           ` Jani Nikula
2015-10-02 12:58           ` Daniel Vetter
2015-09-01 14:11 ` [BXT MIPI PATCH v3 12/14] drm/i915/bxt: Program Backlight PWM frequency Uma Shankar
2015-09-18 13:33   ` Jani Nikula
2015-09-21 10:18     ` Shankar, Uma
2015-09-01 14:11 ` [BXT MIPI PATCH v3 13/14] drm/i915/bxt: Remove DSP CLK_GATE programming for BXT Uma Shankar
2015-09-18 13:38   ` Jani Nikula
2015-10-02 13:02     ` Daniel Vetter
2015-09-01 14:11 ` [BXT MIPI PATCH v3 14/14] drm/i915: Added BXT DSI backlight support Uma Shankar
2015-09-18 13:37   ` Jani Nikula
2015-09-21 10:22     ` Shankar, Uma
2015-09-23 18:00     ` [BXT MIPI PATCH v4 " Uma Shankar
2015-09-24 16:58       ` Ville Syrjälä
2015-09-25 10:15         ` Shankar, Uma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1wyc3pm.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=shobhit.kumar@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.