From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window
Date: Wed, 24 Sep 2014 13:26:18 +0300 [thread overview]
Message-ID: <87d2al9uwl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=P2mKLbdPTQYM_c-ohMtsucTHbc_aukzqcdpQUwhwtvQ@mail.gmail.com> (Michal Kazior's message of "Wed, 24 Sep 2014 08:58:56 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 23 September 2014 16:32, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> [...]
>> - for (ce_id = 0; ce_id < CE_COUNT; ce_id++)
>> + /* Skip the last copy engine, CE7 the diagnostic window, as that
>> + * uses polling and isn't initialized for interrupts. */
>
> Comment style :-)
Argh, I never learn. This new comment style is so unnatural for me that
I guess I need to completely convert ath10k to use the new style so that
I can use checkpatch to catch these :)
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window
Date: Wed, 24 Sep 2014 13:26:18 +0300 [thread overview]
Message-ID: <87d2al9uwl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=P2mKLbdPTQYM_c-ohMtsucTHbc_aukzqcdpQUwhwtvQ@mail.gmail.com> (Michal Kazior's message of "Wed, 24 Sep 2014 08:58:56 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 23 September 2014 16:32, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> [...]
>> - for (ce_id = 0; ce_id < CE_COUNT; ce_id++)
>> + /* Skip the last copy engine, CE7 the diagnostic window, as that
>> + * uses polling and isn't initialized for interrupts. */
>
> Comment style :-)
Argh, I never learn. This new comment style is so unnatural for me that
I guess I need to completely convert ath10k to use the new style so that
I can use checkpatch to catch these :)
--
Kalle Valo
next prev parent reply other threads:[~2014-09-24 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 14:32 [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window Kalle Valo
2014-09-23 14:32 ` Kalle Valo
2014-09-23 14:32 ` [PATCH v2 2/3] ath10k: add diag_read() to hif ops Kalle Valo
2014-09-23 14:32 ` Kalle Valo
2014-09-23 14:32 ` [PATCH v2 3/3] ath10k: add cal_data debugfs file Kalle Valo
2014-09-23 14:32 ` Kalle Valo
2014-09-24 7:00 ` Michal Kazior
2014-09-24 7:00 ` Michal Kazior
2014-09-24 11:00 ` Kalle Valo
2014-09-24 11:00 ` Kalle Valo
2014-09-23 14:38 ` [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window Kalle Valo
2014-09-23 14:38 ` Kalle Valo
2014-09-24 6:58 ` Michal Kazior
2014-09-24 6:58 ` Michal Kazior
2014-09-24 10:26 ` Kalle Valo [this message]
2014-09-24 10:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2al9uwl.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.