From: Kevin Hilman <khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Dave Martin <Dave.Martin-5wv7dgnIgG8@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v6 1/5] ARM: add basic support for Trusted Foundations
Date: Thu, 19 Sep 2013 13:49:31 -0700 [thread overview]
Message-ID: <87d2o4edus.fsf@linaro.org> (raw)
In-Reply-To: <1379238028-7960-2-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> (Alexandre Courbot's message of "Sun, 15 Sep 2013 18:40:24 +0900")
Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> writes:
> Trusted Foundations is a TrustZone-based secure monitor for ARM that
> can be invoked using the same SMC-based API on all supported
> platforms. This patch adds initial basic support for Trusted
> Foundations using the ARM firmware API. Current features are limited
> to the ability to boot secondary processors.
[...]
> +#if IS_ENABLED(CONFIG_OF)
> +void of_register_trusted_foundations(void)
> +{
> + struct device_node *node;
> + struct trusted_foundations_platform_data pdata;
> + int err;
> +
> + node = of_find_compatible_node(NULL, NULL, "tl,trusted-foundations");
> + if (!node)
> + return;
> +
> + err = of_property_read_u32(node, "version-major", &pdata.version_major);
> + if (err != 0)
> + panic("Trusted Foundation: missing version-major property\n");
Do really need to panic() the whole kernel for a missing property?
Surely this can more gracefully recover, or assume some defaults?
Same comment for the other uses of panic() in this patch.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/5] ARM: add basic support for Trusted Foundations
Date: Thu, 19 Sep 2013 13:49:31 -0700 [thread overview]
Message-ID: <87d2o4edus.fsf@linaro.org> (raw)
In-Reply-To: <1379238028-7960-2-git-send-email-acourbot@nvidia.com> (Alexandre Courbot's message of "Sun, 15 Sep 2013 18:40:24 +0900")
Alexandre Courbot <acourbot@nvidia.com> writes:
> Trusted Foundations is a TrustZone-based secure monitor for ARM that
> can be invoked using the same SMC-based API on all supported
> platforms. This patch adds initial basic support for Trusted
> Foundations using the ARM firmware API. Current features are limited
> to the ability to boot secondary processors.
[...]
> +#if IS_ENABLED(CONFIG_OF)
> +void of_register_trusted_foundations(void)
> +{
> + struct device_node *node;
> + struct trusted_foundations_platform_data pdata;
> + int err;
> +
> + node = of_find_compatible_node(NULL, NULL, "tl,trusted-foundations");
> + if (!node)
> + return;
> +
> + err = of_property_read_u32(node, "version-major", &pdata.version_major);
> + if (err != 0)
> + panic("Trusted Foundation: missing version-major property\n");
Do really need to panic() the whole kernel for a missing property?
Surely this can more gracefully recover, or assume some defaults?
Same comment for the other uses of panic() in this patch.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Stephen Warren <swarren@wwwdotorg.org>,
Tomasz Figa <t.figa@samsung.com>,
Dave Martin <Dave.Martin@arm.com>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
gnurou@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/5] ARM: add basic support for Trusted Foundations
Date: Thu, 19 Sep 2013 13:49:31 -0700 [thread overview]
Message-ID: <87d2o4edus.fsf@linaro.org> (raw)
In-Reply-To: <1379238028-7960-2-git-send-email-acourbot@nvidia.com> (Alexandre Courbot's message of "Sun, 15 Sep 2013 18:40:24 +0900")
Alexandre Courbot <acourbot@nvidia.com> writes:
> Trusted Foundations is a TrustZone-based secure monitor for ARM that
> can be invoked using the same SMC-based API on all supported
> platforms. This patch adds initial basic support for Trusted
> Foundations using the ARM firmware API. Current features are limited
> to the ability to boot secondary processors.
[...]
> +#if IS_ENABLED(CONFIG_OF)
> +void of_register_trusted_foundations(void)
> +{
> + struct device_node *node;
> + struct trusted_foundations_platform_data pdata;
> + int err;
> +
> + node = of_find_compatible_node(NULL, NULL, "tl,trusted-foundations");
> + if (!node)
> + return;
> +
> + err = of_property_read_u32(node, "version-major", &pdata.version_major);
> + if (err != 0)
> + panic("Trusted Foundation: missing version-major property\n");
Do really need to panic() the whole kernel for a missing property?
Surely this can more gracefully recover, or assume some defaults?
Same comment for the other uses of panic() in this patch.
Kevin
next prev parent reply other threads:[~2013-09-19 20:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 9:40 [PATCH v6 0/5] ARM: support for Trusted Foundations secure monitor Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
2013-09-15 9:40 ` [PATCH v6 1/5] ARM: add basic support for Trusted Foundations Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
[not found] ` <1379238028-7960-2-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-16 16:50 ` Stephen Warren
2013-09-16 16:50 ` Stephen Warren
2013-09-16 16:50 ` Stephen Warren
[not found] ` <523736DE.1050201-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-17 3:28 ` Alexandre Courbot
2013-09-17 3:28 ` Alexandre Courbot
2013-09-17 3:28 ` Alexandre Courbot
2013-09-19 20:49 ` Kevin Hilman [this message]
2013-09-19 20:49 ` Kevin Hilman
2013-09-19 20:49 ` Kevin Hilman
[not found] ` <87d2o4edus.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-09-23 20:37 ` Alexandre Courbot
2013-09-23 20:37 ` Alexandre Courbot
2013-09-23 20:37 ` Alexandre Courbot
[not found] ` <1379238028-7960-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-15 9:40 ` [PATCH v6 2/5] ARM: tegra: add " Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
2013-09-15 9:40 ` [PATCH v6 3/5] ARM: tegra: split setting of CPU reset handler Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
2013-09-15 9:40 ` [PATCH v6 4/5] ARM: tegra: set CPU reset handler with firmware op Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
2013-09-15 9:40 ` [PATCH v6 5/5] ARM: tegra: support Trusted Foundations by default Alexandre Courbot
2013-09-15 9:40 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2o4edus.fsf@linaro.org \
--to=khilman-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=Dave.Martin-5wv7dgnIgG8@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.