* [PATCH] mmc: dw_mmc: Handle DW_MCI_QUIRK_IDMAC_DTO properly
@ 2013-07-09 20:04 Doug Anderson
2013-07-10 14:54 ` Seungwon Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2013-07-09 20:04 UTC (permalink / raw)
To: Chris Ball
Cc: Markos Chandras, Jaehoon Chung, Seungwon Jeon, James Hogan,
Grant Grundler, Alim Akhtar, Abhilash Kesavan, Tomasz Figa,
Doug Anderson, linux-mmc, linux-kernel
In (1fb5f68 mmc: dw_mmc: Don't loop when handling an interrupt), the
code for handling DW_MCI_QUIRK_IDMAC_DTO became dead code. Move it to
where it ought to live.
Found by code inspection and compile-tested only--I don't know of any
boards that need DW_MCI_QUIRK_IDMAC_DTO.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
drivers/mmc/host/dw_mmc.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index bc3a1bc..cdc0940 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1595,18 +1595,17 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id)
pending = mci_readl(host, MINTSTS); /* read-only mask reg */
- if (pending) {
-
- /*
- * DTO fix - version 2.10a and below, and only if internal DMA
- * is configured.
- */
- if (host->quirks & DW_MCI_QUIRK_IDMAC_DTO) {
- if (!pending &&
- ((mci_readl(host, STATUS) >> 17) & 0x1fff))
- pending |= SDMMC_INT_DATA_OVER;
- }
+ /*
+ * DTO fix - version 2.10a and below, and only if internal DMA
+ * is configured.
+ */
+ if (host->quirks & DW_MCI_QUIRK_IDMAC_DTO) {
+ if (!pending &&
+ ((mci_readl(host, STATUS) >> 17) & 0x1fff))
+ pending |= SDMMC_INT_DATA_OVER;
+ }
+ if (pending) {
if (pending & DW_MCI_CMD_ERROR_FLAGS) {
mci_writel(host, RINTSTS, DW_MCI_CMD_ERROR_FLAGS);
host->cmd_status = pending;
--
1.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] mmc: dw_mmc: Handle DW_MCI_QUIRK_IDMAC_DTO properly
2013-07-09 20:04 [PATCH] mmc: dw_mmc: Handle DW_MCI_QUIRK_IDMAC_DTO properly Doug Anderson
@ 2013-07-10 14:54 ` Seungwon Jeon
2013-08-25 2:22 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Seungwon Jeon @ 2013-07-10 14:54 UTC (permalink / raw)
To: 'Doug Anderson', 'Chris Ball'
Cc: 'Markos Chandras', 'Jaehoon Chung',
'James Hogan', 'Grant Grundler',
'Alim Akhtar', 'Abhilash Kesavan',
'Tomasz Figa', linux-mmc, linux-kernel
On Wed, July 10, 2013, Doug Anderson wrote:
> In (1fb5f68 mmc: dw_mmc: Don't loop when handling an interrupt), the
> code for handling DW_MCI_QUIRK_IDMAC_DTO became dead code. Move it to
> where it ought to live.
>
> Found by code inspection and compile-tested only--I don't know of any
> boards that need DW_MCI_QUIRK_IDMAC_DTO.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Handle DW_MCI_QUIRK_IDMAC_DTO properly
2013-07-10 14:54 ` Seungwon Jeon
@ 2013-08-25 2:22 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2013-08-25 2:22 UTC (permalink / raw)
To: Seungwon Jeon
Cc: 'Doug Anderson', 'Markos Chandras',
'Jaehoon Chung', 'James Hogan',
'Grant Grundler', 'Alim Akhtar',
'Abhilash Kesavan', 'Tomasz Figa', linux-mmc,
linux-kernel
Hi,
On Wed, Jul 10 2013, Seungwon Jeon wrote:
> On Wed, July 10, 2013, Doug Anderson wrote:
>> In (1fb5f68 mmc: dw_mmc: Don't loop when handling an interrupt), the
>> code for handling DW_MCI_QUIRK_IDMAC_DTO became dead code. Move it to
>> where it ought to live.
>>
>> Found by code inspection and compile-tested only--I don't know of any
>> boards that need DW_MCI_QUIRK_IDMAC_DTO.
>>
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-25 2:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-09 20:04 [PATCH] mmc: dw_mmc: Handle DW_MCI_QUIRK_IDMAC_DTO properly Doug Anderson
2013-07-10 14:54 ` Seungwon Jeon
2013-08-25 2:22 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.