All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kevin Liu <keyuan.liu@gmail.com>,
	"linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	linux-arm-kernel@lists.infradead.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Axel Lin <axel.lin@ingics.com>, Jingoo Han <jg1.han@samsung.com>,
	Felipe Balbi <balbi@ti.com>, Dmitry Torokhov <dtor@mail.ru>,
	linux-mmc@vger.kernel.org
Subject: Re: FW: Regulator API ignored return values
Date: Fri, 22 Mar 2013 12:41:00 -0400	[thread overview]
Message-ID: <87d2uro09v.fsf@octavius.laptop.org> (raw)
In-Reply-To: <87y5dsheqo.fsf@octavius.laptop.org> (Chris Ball's message of "Tue, 12 Mar 2013 10:30:55 -0400")

Hi,

On Tue, Mar 12 2013, Chris Ball wrote:
> On Tue, Mar 12 2013, Arnd Bergmann wrote:
>>> Need add regulator_put here since regulator_get has succeed?
>>
>> Hmm, we still don't actually bail out if the error is encountered, so
>> the reference count is balanced with the current patch, but I maybe
>> a failed regulator_enable() should actually be a fatal error?
>
> The reason I didn't make it a fatal error is that this is just vqmmc
> (responsible for moving from 3.3V to 1.8V for UHS modes), not the
> main vmmc regulator.  We can just disable those UHS modes from the
> capabilities on the host if vqmmc is missing, or failed to enable,
> or doesn't support those voltages, and that's what the code does now.

I've pushed this patch to mmc-next for 3.10 now, let me know if you
disagree.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: FW: Regulator API ignored return values
Date: Fri, 22 Mar 2013 12:41:00 -0400	[thread overview]
Message-ID: <87d2uro09v.fsf@octavius.laptop.org> (raw)
In-Reply-To: <87y5dsheqo.fsf@octavius.laptop.org> (Chris Ball's message of "Tue, 12 Mar 2013 10:30:55 -0400")

Hi,

On Tue, Mar 12 2013, Chris Ball wrote:
> On Tue, Mar 12 2013, Arnd Bergmann wrote:
>>> Need add regulator_put here since regulator_get has succeed?
>>
>> Hmm, we still don't actually bail out if the error is encountered, so
>> the reference count is balanced with the current patch, but I maybe
>> a failed regulator_enable() should actually be a fatal error?
>
> The reason I didn't make it a fatal error is that this is just vqmmc
> (responsible for moving from 3.3V to 1.8V for UHS modes), not the
> main vmmc regulator.  We can just disable those UHS modes from the
> capabilities on the host if vqmmc is missing, or failed to enable,
> or doesn't support those voltages, and that's what the code does now.

I've pushed this patch to mmc-next for 3.10 now, let me know if you
disagree.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kevin Liu <keyuan.liu@gmail.com>,
	"linux-kernel\@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	linux-arm-kernel@lists.infradead.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Axel Lin <axel.lin@ingics.com>, Jingoo Han <jg1.han@samsung.com>,
	Felipe Balbi <balbi@ti.com>, Dmitry Torokhov <dtor@mail.ru>,
	linux-mmc@vger.kernel.org
Subject: Re: FW: Regulator API ignored return values
Date: Fri, 22 Mar 2013 12:41:00 -0400	[thread overview]
Message-ID: <87d2uro09v.fsf@octavius.laptop.org> (raw)
In-Reply-To: <87y5dsheqo.fsf@octavius.laptop.org> (Chris Ball's message of "Tue, 12 Mar 2013 10:30:55 -0400")

Hi,

On Tue, Mar 12 2013, Chris Ball wrote:
> On Tue, Mar 12 2013, Arnd Bergmann wrote:
>>> Need add regulator_put here since regulator_get has succeed?
>>
>> Hmm, we still don't actually bail out if the error is encountered, so
>> the reference count is balanced with the current patch, but I maybe
>> a failed regulator_enable() should actually be a fatal error?
>
> The reason I didn't make it a fatal error is that this is just vqmmc
> (responsible for moving from 3.3V to 1.8V for UHS modes), not the
> main vmmc regulator.  We can just disable those UHS modes from the
> capabilities on the host if vqmmc is missing, or failed to enable,
> or doesn't support those voltages, and that's what the code does now.

I've pushed this patch to mmc-next for 3.10 now, let me know if you
disagree.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2013-03-22 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <25B60CDC2F704E4E9D88FFD52780CB4C0BDEB0547F@SC-VEXCH1.marvell.com>
2013-03-12  4:15 ` FW: Regulator API ignored return values Kevin Liu
2013-03-12  4:15   ` Kevin Liu
2013-03-12 14:03   ` Arnd Bergmann
2013-03-12 14:03     ` Arnd Bergmann
2013-03-12 14:30     ` Chris Ball
2013-03-12 14:30       ` Chris Ball
2013-03-12 14:30       ` Chris Ball
2013-03-22 16:41       ` Chris Ball [this message]
2013-03-22 16:41         ` Chris Ball
2013-03-22 16:41         ` Chris Ball
2013-03-22 17:06         ` Arnd Bergmann
2013-03-22 17:06           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2uro09v.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=arnd@arndb.de \
    --cc=axel.lin@ingics.com \
    --cc=balbi@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dtor@mail.ru \
    --cc=jg1.han@samsung.com \
    --cc=keyuan.liu@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.