From: Markus Armbruster <armbru@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 06/11] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg
Date: Thu, 26 Jul 2012 13:12:11 +0200 [thread overview]
Message-ID: <87d33iepys.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1343235256-26310-7-git-send-email-lcapitulino@redhat.com> (Luiz Capitulino's message of "Wed, 25 Jul 2012 13:54:11 -0300")
Luiz Capitulino <lcapitulino@redhat.com> writes:
> Actually, renames it to 'object'. This must be what the original author
> meant to write, as there's no 'object' in the error's data member.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> qerror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qerror.c b/qerror.c
> index 3d8ba2a..01d2493 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -49,7 +49,7 @@ static const QErrorStringTable qerror_table[] = {
> },
> {
> .error_fmt = QERR_AMBIGUOUS_PATH,
> - .desc = "Path '%(path)' does not uniquely identify a %(object)"
> + .desc = "Path '%(path)' does not uniquely identify a object"
> },
> {
> .error_fmt = QERR_BAD_BUS_FOR_DEVICE,
"an object", please.
next prev parent reply other threads:[~2012-07-26 11:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 16:54 [Qemu-devel] [PATCH v2 00/11]: qapi: generate qerrors from qapi-schema-errors.json Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 01/11] qerror: rename QERR_SOCKET_* macros Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 02/11] qerror: rename QERR_SOCK_CONNECT_IN_PROGRESS Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 03/11] qerror: rename QERR_QMP_EXTRA_MEMBER Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 04/11] qerror: rename QERR_PROPERTY_VALUE_NOT_POWER_OF_2 Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 05/11] qerror: QERR_DEVICE_ENCRYPTED: add filename info to human msg Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 06/11] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from " Luiz Capitulino
2012-07-26 11:12 ` Markus Armbruster [this message]
2012-07-26 14:15 ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped Luiz Capitulino
2012-07-25 17:45 ` Peter Maydell
2012-07-25 19:18 ` Luiz Capitulino
2012-07-25 19:47 ` Peter Maydell
2012-07-26 11:22 ` Markus Armbruster
2012-07-26 13:47 ` Luiz Capitulino
2012-07-26 16:11 ` Markus Armbruster
2012-07-26 17:09 ` [Qemu-devel] [PATCH] fixup! " Markus Armbruster
2012-07-26 18:21 ` Peter Maydell
2012-07-27 14:29 ` Luiz Capitulino
2012-07-28 6:37 ` Markus Armbruster
2012-07-30 13:09 ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 08/11] qapi: add qapi-schema-errors.json Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py Luiz Capitulino
2012-07-26 11:50 ` Markus Armbruster
2012-07-26 11:55 ` Paolo Bonzini
2012-07-26 12:38 ` Eric Blake
2012-07-26 12:42 ` Eric Blake
2012-07-26 14:45 ` Luiz Capitulino
2012-07-26 14:34 ` Luiz Capitulino
2012-07-26 16:31 ` Markus Armbruster
2012-07-26 12:12 ` Markus Armbruster
2012-07-26 14:47 ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated error macros and table Luiz Capitulino
2012-07-26 11:56 ` Markus Armbruster
2012-07-26 14:50 ` Luiz Capitulino
2012-07-26 16:05 ` Markus Armbruster
2012-07-26 16:52 ` Luiz Capitulino
2012-07-25 16:54 ` [Qemu-devel] [PATCH 11/11] scripts: update check-qerror.sh Luiz Capitulino
2012-07-26 11:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d33iepys.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.