From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sh_mmcif: fix clock gating on platforms, implementing a .down_pwr() method
Date: Thu, 01 Dec 2011 12:48:51 -0500 [thread overview]
Message-ID: <87d3c8mbcs.fsf@laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1111161009060.1100@axis700.grange> (Guennadi Liakhovetski's message of "Wed, 16 Nov 2011 10:10:41 +0100 (CET)")
Hi,
On Wed, Nov 16 2011, Guennadi Liakhovetski wrote:
> Do not power down the card in .set_ios(), unless MMC_POWER_OFF is
> requested. This fixes the MMCIF interface functionality on ecovec boards.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/mmc/host/sh_mmcif.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 557886b..c021482 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -895,7 +895,7 @@ static void sh_mmcif_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> if (host->power) {
> pm_runtime_put(&host->pd->dev);
> host->power = false;
> - if (p->down_pwr)
> + if (p->down_pwr && ios->power_mode == MMC_POWER_OFF)
> p->down_pwr(host->pd);
> }
> host->state = STATE_IDLE;
Thanks, pushed to mmc-next for 3.2.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-12-01 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 9:10 [PATCH] mmc: sh_mmcif: fix clock gating on platforms, implementing a .down_pwr() method Guennadi Liakhovetski
2011-12-01 17:48 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3c8mbcs.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.