* [PATCH] mmc: sh_mmcif: fix clock gating on platforms, implementing a .down_pwr() method
@ 2011-11-16 9:10 Guennadi Liakhovetski
2011-12-01 17:48 ` Chris Ball
0 siblings, 1 reply; 2+ messages in thread
From: Guennadi Liakhovetski @ 2011-11-16 9:10 UTC (permalink / raw)
To: linux-mmc; +Cc: Chris Ball
Do not power down the card in .set_ios(), unless MMC_POWER_OFF is
requested. This fixes the MMCIF interface functionality on ecovec boards.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
drivers/mmc/host/sh_mmcif.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 557886b..c021482 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -895,7 +895,7 @@ static void sh_mmcif_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
if (host->power) {
pm_runtime_put(&host->pd->dev);
host->power = false;
- if (p->down_pwr)
+ if (p->down_pwr && ios->power_mode == MMC_POWER_OFF)
p->down_pwr(host->pd);
}
host->state = STATE_IDLE;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: sh_mmcif: fix clock gating on platforms, implementing a .down_pwr() method
2011-11-16 9:10 [PATCH] mmc: sh_mmcif: fix clock gating on platforms, implementing a .down_pwr() method Guennadi Liakhovetski
@ 2011-12-01 17:48 ` Chris Ball
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2011-12-01 17:48 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: linux-mmc
Hi,
On Wed, Nov 16 2011, Guennadi Liakhovetski wrote:
> Do not power down the card in .set_ios(), unless MMC_POWER_OFF is
> requested. This fixes the MMCIF interface functionality on ecovec boards.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/mmc/host/sh_mmcif.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 557886b..c021482 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -895,7 +895,7 @@ static void sh_mmcif_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> if (host->power) {
> pm_runtime_put(&host->pd->dev);
> host->power = false;
> - if (p->down_pwr)
> + if (p->down_pwr && ios->power_mode == MMC_POWER_OFF)
> p->down_pwr(host->pd);
> }
> host->state = STATE_IDLE;
Thanks, pushed to mmc-next for 3.2.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-01 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 9:10 [PATCH] mmc: sh_mmcif: fix clock gating on platforms, implementing a .down_pwr() method Guennadi Liakhovetski
2011-12-01 17:48 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.