From: Kevin Hilman <khilman@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, santosh.shilimkar@ti.com, tony@atomide.com
Subject: Re: [PATCH v3 19/20] GPIO: OMAP: optimize suspend and resume functions
Date: Wed, 06 Jul 2011 13:54:50 -0700 [thread overview]
Message-ID: <87d3hnf7tx.fsf@ti.com> (raw)
In-Reply-To: <1309513634-20971-20-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Fri, 1 Jul 2011 15:17:13 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> There is no need to operate on all the banks every time the function is called.
> Just operate on the current bank passed by the framework.
That's a good change.
There is also no need to runtime suspend/resume the bank if
bank->suspend_wakeup == 0 during suspend (or bank->saved_wakeup == 0
during resume.)
IOW, banks with no wakeups enabled have an unnecessary runtime
resume/suspend in both the system suspend and resume path.
Kevin
next prev parent reply other threads:[~2011-07-06 20:54 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 9:46 [PATCH v3 00/20] GPIO: OMAP: driver cleanup and fixes Tarun Kanti DebBarma
2011-07-01 9:46 ` [PATCH v3 01/20] GPIO: OMAP: Remove dependency on gpio_bank_count Tarun Kanti DebBarma
2011-07-01 9:46 ` [PATCH v3 02/20] GPIO: OMAP2+: Use flag to identify wakeup domain Tarun Kanti DebBarma
2011-07-01 9:46 ` [PATCH v3 03/20] GPIO: OMAP: Make gpio_context part of gpio_bank structure Tarun Kanti DebBarma
2011-07-01 9:46 ` [PATCH v3 04/20] GPIO: OMAP: Fix pwrdm_post_transition call sequence Tarun Kanti DebBarma
2011-07-01 9:46 ` [PATCH v3 05/20] GPIO: OMAP: Handle save/restore ctx in GPIO driver Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 06/20] GPIO: OMAP2+: Make non-wakeup GPIO part of pdata Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 07/20] GPIO: OMAP: Avoid cpu checks during module ena/disable Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 08/20] GPIO: OMAP: Use wkup regs off/suspend support flag Tarun Kanti DebBarma
2011-07-06 19:51 ` Kevin Hilman
2011-07-07 5:06 ` DebBarma, Tarun Kanti
2011-07-01 9:47 ` [PATCH v3 09/20] GPIO: OMAP: Use level/edge detect reg offsets Tarun Kanti DebBarma
2011-07-05 23:51 ` Kevin Hilman
2011-07-06 4:15 ` DebBarma, Tarun Kanti
2011-07-06 19:57 ` Kevin Hilman
2011-07-07 4:47 ` DebBarma, Tarun Kanti
2011-07-01 9:47 ` [PATCH v3 10/20] GPIO: OMAP: Remove hardcoded offsets in ctxt save/restore Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 11/20] GPIO: OMAP: Clean set_gpio_triggering function Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 12/20] GPIO: OMAP: Use wkup_status for all SoCs Tarun Kanti DebBarma
2011-07-06 0:50 ` Kevin Hilman
2011-07-06 4:30 ` DebBarma, Tarun Kanti
2011-07-06 4:33 ` DebBarma, Tarun Kanti
2011-07-12 0:04 ` DebBarma, Tarun Kanti
2011-07-12 15:30 ` Kevin Hilman
2011-07-13 3:55 ` DebBarma, Tarun Kanti
2011-07-01 9:47 ` [PATCH v3 13/20] GPIO: OMAP: Clean omap_gpio_mod_init function Tarun Kanti DebBarma
2011-07-06 20:38 ` Kevin Hilman
2011-07-07 4:40 ` DebBarma, Tarun Kanti
2011-07-01 9:47 ` [PATCH v3 14/20] GPIO: OMAP15xx: Use pinctrl offset instead of macro Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 15/20] GPIO: OMAP: Use readl in irq_handler for all access Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 16/20] GPIO: OMAP: Remove bank->method & METHOD_* macros Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 17/20] GPIO: OMAP: Fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma
2011-07-01 9:47 ` [PATCH v3 18/20] GPIO: OMAP: Use PM runtime framework Tarun Kanti DebBarma
2011-07-20 6:28 ` Roger Quadros
2011-07-20 9:28 ` DebBarma, Tarun Kanti
2011-07-20 9:33 ` Roger Quadros
2011-07-20 9:46 ` DebBarma, Tarun Kanti
2011-07-01 9:47 ` [PATCH v3 19/20] GPIO: OMAP: optimize suspend and resume functions Tarun Kanti DebBarma
2011-07-06 20:54 ` Kevin Hilman [this message]
2011-07-07 4:42 ` DebBarma, Tarun Kanti
2011-07-01 9:47 ` [PATCH v3 20/20] GPIO: OMAP2+: Clean prepare_for_idle and resume_after_idle Tarun Kanti DebBarma
2011-07-05 23:46 ` [PATCH v3 00/20] GPIO: OMAP: driver cleanup and fixes Kevin Hilman
2011-07-06 4:37 ` DebBarma, Tarun Kanti
2011-07-06 21:07 ` Kevin Hilman
2011-07-07 4:16 ` DebBarma, Tarun Kanti
2011-07-12 15:22 ` Hilman, Kevin
2011-07-13 3:48 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3hnf7tx.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.