From: Ben Gamari <bgamari.foss@gmail.com>
To: balbi@ti.com
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap2-beagle: Depend upon CONFIG_GPIO_TWL4030
Date: Tue, 18 Jan 2011 08:51:52 -0500 [thread overview]
Message-ID: <87d3nus4jr.fsf@gmail.com> (raw)
In-Reply-To: <20110118031038.GA2436@legolas.emea.dhcp.ti.com>
On Tue, 18 Jan 2011 05:10:39 +0200, Felipe Balbi <balbi@ti.com> wrote:
> NAK. This is totally bogus. The board doesn't really depend on
> GPIO_TWL4030, the MMC driver does.
>
I've looked a little more deeply into this and I'm not entirely
convinced that what you claim is true. It seems that the only dependency
that the MMC module _might_ have on the TWL4030 is for the LDOs, which I
believe should be covered in the regulator driver, not GPIO.
In light of this, I think the use of the TWL's GPIO lines for MMC it
might be a board specific design decision. In the case of the
Beagleboard, they are only TWL GPIO used by the MMC configuration is for
.gpio_cd but as far as I could see they could have chosen any GPIO for
this. Am I missing something?
Cheers,
- Ben
WARNING: multiple messages have this Message-ID (diff)
From: bgamari.foss@gmail.com (Ben Gamari)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap2-beagle: Depend upon CONFIG_GPIO_TWL4030
Date: Tue, 18 Jan 2011 08:51:52 -0500 [thread overview]
Message-ID: <87d3nus4jr.fsf@gmail.com> (raw)
In-Reply-To: <20110118031038.GA2436@legolas.emea.dhcp.ti.com>
On Tue, 18 Jan 2011 05:10:39 +0200, Felipe Balbi <balbi@ti.com> wrote:
> NAK. This is totally bogus. The board doesn't really depend on
> GPIO_TWL4030, the MMC driver does.
>
I've looked a little more deeply into this and I'm not entirely
convinced that what you claim is true. It seems that the only dependency
that the MMC module _might_ have on the TWL4030 is for the LDOs, which I
believe should be covered in the regulator driver, not GPIO.
In light of this, I think the use of the TWL's GPIO lines for MMC it
might be a board specific design decision. In the case of the
Beagleboard, they are only TWL GPIO used by the MMC configuration is for
.gpio_cd but as far as I could see they could have chosen any GPIO for
this. Am I missing something?
Cheers,
- Ben
next prev parent reply other threads:[~2011-01-18 13:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 21:25 [PATCH] omap2-beagle: Depend upon CONFIG_GPIO_TWL4030 Ben Gamari
2011-01-17 21:25 ` Ben Gamari
2011-01-18 3:10 ` Felipe Balbi
2011-01-18 3:10 ` Felipe Balbi
2011-01-18 13:51 ` Ben Gamari [this message]
2011-01-18 13:51 ` Ben Gamari
2011-01-19 3:45 ` Felipe Balbi
2011-01-19 3:45 ` Felipe Balbi
2011-01-19 20:04 ` Ben Gamari
2011-01-19 20:04 ` Ben Gamari
2011-01-20 4:08 ` Felipe Balbi
2011-01-20 4:08 ` Felipe Balbi
2011-01-20 17:27 ` Tony Lindgren
2011-01-20 17:27 ` Tony Lindgren
2011-01-20 21:44 ` Ben Gamari
2011-01-20 21:44 ` Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3nus4jr.fsf@gmail.com \
--to=bgamari.foss@gmail.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.