Re: [PATCH 2/5] quota: Implement project id support for generic quota

[Dmitry Monakhov <dmonakhov@openvz.org>]

Christoph Hellwig <hch@infradead.org> writes:

> On Thu, Mar 04, 2010 at 09:34:34PM +0300, Dmitry Monakhov wrote:
>>  		case GRPQUOTA:
>>  			return in_group_p(dquot->dq_id);
>> +		case PRJQUOTA:
>> +			/* XXX: Currently there is no way to understand
>> +			   which project_id this task belonges to, So print
>> +			   a warn message unconditionally. -dmon */
>> +			return 1;
>
> Note that this is different from the XFS behaviour, which neve warns
> for project quota.  In fact project quota in XFS traditionally doesn't
> even return EDQUOT but ENOSPC instead, as it's not a traditional quota
> mechanism but filesystem containerization.
Yes, i know, but imho it is better to return true EDQUOT to understand
what is really happen.
>
> Otherwise the patch looks good except for the ifdef mess already comment
> on in the previous patch.