From: Peter Korsgaard <jacmet@sunsite.dk>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling
Date: Tue, 19 Aug 2008 22:01:37 +0200 [thread overview]
Message-ID: <87d4k4n59a.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080812161733.GA32164@oksana.dev.rtsoft.ru> (Anton Vorontsov's message of "Tue\, 12 Aug 2008 20\:17\:33 +0400")
>>>>> "Anton" == Anton Vorontsov <avorontsov@ru.mvista.com> writes:
Anton> On a PowerPC board with ds1374 RTC I'm getting this error while
Anton> RTC tries to probe:
Anton> rtc-ds1374 0-0068: unable to request IRQ
Anton> This happens because I2C probing code (drivers/of/of_i2c.c) is
Anton> specifying IRQ0 for 'no irq' case, which is correct.
Anton> The driver handles this incorrectly, though. This patch fixes it.
Great, I was just about to send a similar patch. Another advantage of
using 0 for 'no irq' is for I2C_BOARD_INFO(). With that you can simply
not assign anything to .irq instead of having to set it to -1.
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling
Date: Tue, 19 Aug 2008 22:01:37 +0200 [thread overview]
Message-ID: <87d4k4n59a.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080812161733.GA32164@oksana.dev.rtsoft.ru> (Anton Vorontsov's message of "Tue\, 12 Aug 2008 20\:17\:33 +0400")
>>>>> "Anton" == Anton Vorontsov <avorontsov@ru.mvista.com> writes:
Anton> On a PowerPC board with ds1374 RTC I'm getting this error while
Anton> RTC tries to probe:
Anton> rtc-ds1374 0-0068: unable to request IRQ
Anton> This happens because I2C probing code (drivers/of/of_i2c.c) is
Anton> specifying IRQ0 for 'no irq' case, which is correct.
Anton> The driver handles this incorrectly, though. This patch fixes it.
Great, I was just about to send a similar patch. Another advantage of
using 0 for 'no irq' is for I2C_BOARD_INFO(). With that you can simply
not assign anything to .irq instead of having to set it to -1.
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-08-19 20:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 16:17 [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling Anton Vorontsov
2008-08-12 16:17 ` Anton Vorontsov
2008-08-19 20:01 ` Peter Korsgaard [this message]
2008-08-19 20:01 ` Peter Korsgaard
2008-08-19 20:39 ` Jon Smirl
2008-08-19 20:39 ` Jon Smirl
2008-08-19 20:29 ` Alan Cox
2008-08-19 20:29 ` Alan Cox
2008-08-19 21:23 ` Jon Smirl
2008-08-19 21:23 ` Jon Smirl
2008-08-19 22:04 ` Alan Cox
2008-08-19 22:04 ` Alan Cox
2008-08-19 21:12 ` Anton Vorontsov
2008-08-19 21:12 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4k4n59a.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.