Re: [PATCH] Drivemap module

[Marco Gerards <mgerards@xs4all.nl>]

Javier Martín <lordhabbit@gmail.com> writes:

> Ok, making a mixup reply...

Please don't.  Unless you do not like it that your mails go unread.

>> > Having a small kernel is highly desireable for most users.  If the kernel is
>> > too big, it won't fit and then either we have to use blocklists (which are
>> > unreliable), or we have to abort the install.
>> >
>> > Please, try to find a way that doesn't increase kernel size significantly.
>> >
>> > If the kernel interfaces are not extensible enough, you could try to readjust
>> > them for your needs.  This approach works well most of the time (although I
>> > haven't studied this particular problem in detail).
>> 
>> Like discussed before.  Bring up such modifications like hooks up in a
>> *separate* thread.  I already said that not everyone reads this
>> discussion.  I will not accept a patch that changes the kernel if it
>> is part of a bigger patch that not many people read.
>> 
>> Please don't discuss this over with Robert and me, you know that it
>> was pointed out that this has to be a patch in a separate thread.
>> Furthermore, this is a way to get some feedback from Bean who wants
>> something similar, IIRC.
>
> I know I will be regretting saying this, but it is _very_ rude to review
> some five versions of the patch, spotting mostly coding-style errors on
> each, and then, on version 8, tell me that "you won't accept a patch
> that contains blah" (with "blah" being essential for the patch to work).
> Quite the proverbial slap in the face to me.

I did NOT say that your patch will not be accepted.  In one of the
earlier reviews (perhaps even the first) I mentioned that certain
parts should be reviewed separately.  It is a slap in the face that
you imply I am a bad person when I repeat that you need to bring up
some issues *separately*.  I would consider it bad style from me
towards other developers to change code they might have a strong
opinion on.

And you can say what you want, but if you are stubborn enough to
ignore what I say in the reviews, you shouldn't be surprised if I
didn't change my opinion in the next review and still ask you to
change something.  In fact, it is rude just to send in a new patch
while you did not take the review seriously.  There are a lot of
projects that reject patches on beforehand if you didn't at least
bother to get familiar with their coding styles.

Furthermore, I reviewed your patch mainly because I care, not because
I am the foremost expert in BIOS disks.  It's for the best if other
people can look at specific parts of your patch, especially if it
changes the kernel.

Perhaps you do not notice how many time I spent on reviewing patches
on this list lately.  Anyways, if it is not appreciated, I will leave
the reviews to other people.  But I simply will reject all code I do
not like without actually bothering to explain why.  I rather spend my
time on coding instead of feeding trolls.

--
Marco