From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Drivemap module
Date: Thu, 12 Jun 2008 21:00:21 -0400 [thread overview]
Message-ID: <1213318821.20744.12.camel@dv> (raw)
In-Reply-To: <20080612155828.3d1be792@gibibit.com>
On Thu, 2008-06-12 at 15:58 -0700, Colin D Bennett wrote:
> I think Pavel meant the lines added by the patch, i.e., beginning with
> a plus in the patch, not in the original source.
Yes, I meant added lines. There is a lot of code that needs
reformatting, but the patch shouldn't add more to that.
> I highly recommend running
>
> indent --no-tabs
Why no tabs? Tabs are heavily used in the code. GNU indent is supposed
to default to GNU Coding Standards, and it uses tabs.
> on your source code, as long as it doesn't cause too many spurious
> changes to pre-existing code.
It will.
> This should take care of most formatting
> inconsistencies and frees you a little but from concerning yourself
> with trivial details.
We can use a script to re-indent everything. Then new patches could be
easily run through the same script. Otherwise, it's not going to be
simple.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-06-13 1:00 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 20:09 [PATCH] Drivemap module Javier Martín
2008-06-10 20:23 ` Vesa Jääskeläinen
2008-06-10 21:31 ` Javier Martín
2008-06-12 20:31 ` Pavel Roskin
2008-06-12 22:43 ` Javier Martín
2008-06-12 22:58 ` Colin D Bennett
2008-06-13 1:00 ` Pavel Roskin [this message]
2008-06-13 4:09 ` Colin D Bennett
2008-06-13 1:37 ` Pavel Roskin
2008-06-13 2:29 ` Javier Martín
2008-06-11 14:44 ` Marco Gerards
-- strict thread matches above, loose matches on Subject: below --
2008-07-04 2:12 Javier Martín
2008-07-05 11:04 ` Marco Gerards
2008-07-16 15:39 ` Javier Martín
2008-07-20 19:40 ` Marco Gerards
2008-07-21 0:55 ` Javier Martín
2008-07-21 11:07 ` Javier Martín
2008-07-22 21:32 ` Robert Millan
2008-07-31 19:01 ` Marco Gerards
2008-08-03 23:29 ` Javier Martín
2008-08-04 20:51 ` Marco Gerards
2008-08-04 23:10 ` Javier Martín
2008-08-05 0:50 ` Isaac Dupree
2008-08-05 2:38 ` Javier Martín
2008-08-05 11:31 ` Marco Gerards
2008-08-05 11:23 ` Marco Gerards
2008-08-05 17:18 ` Colin D Bennett
2008-08-05 11:28 ` Marco Gerards
2008-08-05 16:39 ` Javier Martín
2008-08-09 15:33 ` Javier Martín
2008-08-13 10:13 ` Marco Gerards
2008-08-13 12:16 ` Javier Martín
2008-08-13 13:00 ` Robert Millan
2008-08-13 14:28 ` Javier Martín
2008-08-13 14:51 ` Marco Gerards
2008-08-13 15:14 ` Robert Millan
2008-08-13 15:57 ` Marco Gerards
2008-08-13 22:38 ` Javier Martín
2008-08-14 17:15 ` Marco Gerards
2008-08-14 22:17 ` Javier Martín
2008-08-13 13:01 ` Robert Millan
2008-08-05 17:15 ` Colin D Bennett
2008-08-06 14:43 Viswesh S
2008-08-06 17:31 ` Javier Martín
2008-08-08 13:20 ` Felix Zielcke
2008-08-07 12:15 Viswesh S
2008-08-08 13:43 Viswesh S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213318821.20744.12.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.