All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@nokia.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: "Adrian Bunk" <bunk@stusta.de>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: RFC: always enable MAC80211_RC_PID?
Date: Mon, 23 Jun 2008 09:57:30 +0300	[thread overview]
Message-ID: <87d4m88wpx.fsf@nokia.com> (raw)
In-Reply-To: <43e72e890806220804i347b942claae7b725231afcce@mail.gmail.com> (ext Luis R. Rodriguez's message of "Sun\, 22 Jun 2008 20\:34\:10 +0530")

Luis R. Rodriguez <mcgrof@gmail.com> writes:

> On Sun, Jun 22, 2008 at 6:25 PM, Adrian Bunk <bunk@stusta.de> wrote:
>> After the scheduled removal of MAC80211_RC_SIMPLE only
>> MAC80211_RC_DEFAULT_PID and MAC80211_RC_DEFAULT_NONE are
>> left as choices.
>>
>> Does MAC80211_RC_DEFAULT_NONE have any userbase serious enough to
>> justify all the constructs made for this case or could we simply
>> always enable MAC80211_RC_PID?
>
> You can currently only get away living without it if you are just
> using iwl3945 or iwl4965 as they provide their own rate control
> algorithms. In the future if other vendor drivers are added with their
> own rate control algorithm this list grows. Disabling PID will save
> you some space only on some embedded platforms. Although currently its
> not evident people would do this I do see this being a reasonable
> option to keep around for later.

I agree with Luis. There is a need for MAC80211_RC_DEFAULT_NONE,
please do not remove it.

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kalle.valo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: "Luis R. Rodriguez" <mcgrof-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Adrian Bunk" <bunk-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: RFC: always enable MAC80211_RC_PID?
Date: Mon, 23 Jun 2008 09:57:30 +0300	[thread overview]
Message-ID: <87d4m88wpx.fsf@nokia.com> (raw)
In-Reply-To: <43e72e890806220804i347b942claae7b725231afcce-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (ext Luis R. Rodriguez's message of "Sun\, 22 Jun 2008 20\:34\:10 +0530")

Luis R. Rodriguez <mcgrof-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> On Sun, Jun 22, 2008 at 6:25 PM, Adrian Bunk <bunk-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org> wrote:
>> After the scheduled removal of MAC80211_RC_SIMPLE only
>> MAC80211_RC_DEFAULT_PID and MAC80211_RC_DEFAULT_NONE are
>> left as choices.
>>
>> Does MAC80211_RC_DEFAULT_NONE have any userbase serious enough to
>> justify all the constructs made for this case or could we simply
>> always enable MAC80211_RC_PID?
>
> You can currently only get away living without it if you are just
> using iwl3945 or iwl4965 as they provide their own rate control
> algorithms. In the future if other vendor drivers are added with their
> own rate control algorithm this list grows. Disabling PID will save
> you some space only on some embedded platforms. Although currently its
> not evident people would do this I do see this being a reasonable
> option to keep around for later.

I agree with Luis. There is a need for MAC80211_RC_DEFAULT_NONE,
please do not remove it.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-06-23  7:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-22 12:55 RFC: always enable MAC80211_RC_PID? Adrian Bunk
2008-06-22 12:55 ` Adrian Bunk
2008-06-22 15:04 ` Luis R. Rodriguez
2008-06-22 15:04   ` Luis R. Rodriguez
2008-06-23  6:57   ` Kalle Valo [this message]
2008-06-23  6:57     ` Kalle Valo
2008-06-24  9:04   ` Johannes Berg
2008-06-24  9:04     ` Johannes Berg
2008-06-24 12:43     ` Adrian Bunk
2008-06-24 12:43       ` Adrian Bunk
2008-06-24 21:12       ` John W. Linville
2008-06-24 21:12         ` John W. Linville
2008-06-26 10:38         ` [2.6 patch] build algorithms into the mac80211 module Adrian Bunk
2008-06-26 13:46           ` Johannes Berg
2008-06-26 21:35         ` RFC: always enable MAC80211_RC_PID? Luis R. Rodriguez
2008-06-26 21:35           ` Luis R. Rodriguez
2008-06-26 22:37           ` Tomas Winkler
2008-06-26 22:37             ` Tomas Winkler
2008-06-26 17:55       ` Mattias Nissler
2008-06-26 17:55         ` Mattias Nissler
2008-06-26 18:10         ` Adrian Bunk
2008-06-25  0:56     ` Nick Kossifidis
2008-06-25  0:56       ` Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4m88wpx.fsf@nokia.com \
    --to=kalle.valo@nokia.com \
    --cc=bunk@stusta.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.