From: Johannes Weiner <hannes@saeurebad.de>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM Mailing List <linux-mm@kvack.org>
Subject: Re: bootmem: Double freeing a PFN on nodes spanning other nodes
Date: Mon, 19 May 2008 03:31:10 +0200 [thread overview]
Message-ID: <87d4njulk1.fsf@saeurebad.de> (raw)
In-Reply-To: <20080519093525.4867bfb4.kamezawa.hiroyu@jp.fujitsu.com> (KAMEZAWA Hiroyuki's message of "Mon, 19 May 2008 09:35:25 +0900")
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:
> On Sat, 17 May 2008 00:30:55 +0200
> Johannes Weiner <hannes@saeurebad.de> wrote:
>
>> Hi,
>>
>> When memory nodes overlap each other, the bootmem allocator is not aware
>> of this and might pass the same page twice to __free_pages_bootmem().
>>
>
> 1. init_bootmem_node() is called against a node, [start, end). After this,
> all pages are 'allocated'.
> 2. free_bootmem_node() is called against available memory in a node.
> 3. bootmem allocator is ready.
>
> memory overlap seems not to be trouble while an arch's code calls
> free_bootmem_node() correctly.
Ah, I totally overlooked that one. Thank you very much!
Hannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@saeurebad.de>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM Mailing List <linux-mm@kvack.org>
Subject: Re: bootmem: Double freeing a PFN on nodes spanning other nodes
Date: Mon, 19 May 2008 03:31:10 +0200 [thread overview]
Message-ID: <87d4njulk1.fsf@saeurebad.de> (raw)
In-Reply-To: <20080519093525.4867bfb4.kamezawa.hiroyu@jp.fujitsu.com> (KAMEZAWA Hiroyuki's message of "Mon, 19 May 2008 09:35:25 +0900")
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:
> On Sat, 17 May 2008 00:30:55 +0200
> Johannes Weiner <hannes@saeurebad.de> wrote:
>
>> Hi,
>>
>> When memory nodes overlap each other, the bootmem allocator is not aware
>> of this and might pass the same page twice to __free_pages_bootmem().
>>
>
> 1. init_bootmem_node() is called against a node, [start, end). After this,
> all pages are 'allocated'.
> 2. free_bootmem_node() is called against available memory in a node.
> 3. bootmem allocator is ready.
>
> memory overlap seems not to be trouble while an arch's code calls
> free_bootmem_node() correctly.
Ah, I totally overlooked that one. Thank you very much!
Hannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-19 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 22:30 bootmem: Double freeing a PFN on nodes spanning other nodes Johannes Weiner
2008-05-16 22:30 ` Johannes Weiner
2008-05-19 0:35 ` KAMEZAWA Hiroyuki
2008-05-19 0:35 ` KAMEZAWA Hiroyuki
2008-05-19 1:31 ` Johannes Weiner [this message]
2008-05-19 1:31 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4njulk1.fsf@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.