* Re: [PATCH] skip removal of menu.lst in grub-install
[not found] <20060819111637.GA3620@khazad.dyndns.org>
@ 2006-09-14 18:07 ` Robert Millan
2006-09-14 18:36 ` Marco Gerards
0 siblings, 1 reply; 3+ messages in thread
From: Robert Millan @ 2006-09-14 18:07 UTC (permalink / raw)
To: bug-grub, grub-devel
Any comments on this? (resending to grub-devel, previously missed it).
On Sat, Aug 19, 2006 at 01:16:37PM +0200, Robert Millan wrote:
>
> Hi!
>
> grub-install removing menu.lst makes it hard to coexist with grub legacy in
> the same system. Please consider the attached patch.
>
> 2006-08-19 Robert Millan <rmh@aybabtu.com>
>
> * util/i386/pc/grub-install.in: Skip menu.lst when removing
> /boot/grub/*.lst.
>
> --
> Robert Millan
>
> My spam trap is honeypot@aybabtu.com. Note: this address is only intended for
> spam harvesters. Writing to it will get you added to my black list.
> 2006-08-19 Robert Millan <rmh@aybabtu.com>
>
> * util/i386/pc/grub-install.in: Skip menu.lst when removing
> /boot/grub/*.lst.
>
> Index: util/i386/pc/grub-install.in
> ===================================================================
> RCS file: /sources/grub/grub2/util/i386/pc/grub-install.in,v
> retrieving revision 1.8
> diff -u -r1.8 grub-install.in
> --- util/i386/pc/grub-install.in 28 May 2006 23:01:43 -0000 1.8
> +++ util/i386/pc/grub-install.in 19 Aug 2006 11:02:11 -0000
> @@ -198,7 +198,7 @@
>
> # Copy the GRUB images to the GRUB directory.
> for file in ${grubdir}/*.mod ${grubdir}/*.lst ${grubdir}/*.img; do
> - if test -f $file; then
> + if test -f $file && [ "`basename $file`" != menu.lst ]; then
> rm -f $file || exit 1
> fi
> done
> @@ -206,7 +206,7 @@
> cp -f $file ${grubdir} || exit 1
> done
>
> -# Create the core image. First, auto-detect the filesystme module.
> +# Create the core image. First, auto-detect the filesystem module.
> fs_module=`$grub_probefs --device-map=${device_map} ${grubdir}`
> if test "x$fs_module" = x -a "x$modules" = x; then
> echo "Auto-detection of a filesystem module failed." 1>&2
--
Robert Millan
My spam trap is honeypot@aybabtu.com. Note: this address is only intended for
spam harvesters. Writing to it will get you added to my black list.
^ permalink raw reply [flat|nested] 3+ messages in thread