Re: Bug report: slab error at module removal

[Mathieu Segaud <matt@minas-morgul.org>]

Alex Zarochentsev <zam@namesys.com> writes:

> On Sat, Aug 14, 2004 at 06:26:36AM +0200, Mathieu Segaud wrote:

>> slab error in kmem_cache_destroy(): cache `plugin_set': Can't free all objects
>>  [<c0135c41>] kmem_cache_destroy+0xd1/0x130
>>  [<f99bf57a>] plugin_set_done+0xa/0x30 [reiser4]
>>  [<f99b9194>] shutdown_reiser4+0xf4/0x210 [reiser4]
>>  [<c012a004>] sys_delete_module+0x144/0x180
>>  [<c013ea9e>] unmap_vma_list+0xe/0x20
>>  [<c013edcf>] do_munmap+0xef/0x150
>>  [<c0103afd>] sysenter_past_esp+0x52/0x71

This does not seem to fix every leak...
I got the same message at module removal (this time the fs had been mounted,
one of them was used to compile lirc, and each one was then umounted)

> can you try the following patch:
>
> # This is a BitKeeper generated diff -Nru style patch.
> #
> # ChangeSet
> #   2004/08/15 20:07:10+04:00 zam@crimson.namesys.com 
> #   plugin_set_done: first clean the hash table and free all elements, then remove the slab cache.
> # 
> # plugin/plugin_set.c
> #   2004/08/15 20:07:07+04:00 zam@crimson.namesys.com +1 -1
> #   plugin_set_done: first clean the hash table and free all elements, then remove the slab cache.
> # 
> diff -Nru a/plugin/plugin_set.c b/plugin/plugin_set.c
> --- a/plugin/plugin_set.c	Sun Aug 15 20:12:29 2004
> +++ b/plugin/plugin_set.c	Sun Aug 15 20:12:29 2004
> @@ -329,8 +329,8 @@
>  reiser4_internal void plugin_set_done(void)
>  {
>  	/* NOTE: scan hash table and recycle all objects. */
> -	kmem_cache_destroy(plugin_set_slab);
>  	ps_hash_done(&ps_table);
> +	kmem_cache_destroy(plugin_set_slab);
>  }
>  

I forgot again to reenable DEBUG options. I will give it a try this night.

-- 
Mathieu Segaud