From: Markus Armbruster <armbru@pond.sub.org>
To: Elizabeth Ashurov <eashurov@redhat.com>
Cc: qemu-devel@nongnu.org, kkostiuk@redhat.com,
michael.roth@amd.com, dholler@redhat.com, armbru@redhat.com,
fdeutsch@redhat.com, yvugenfi@redhat.com, kramdoss@redhat.com
Subject: Re: [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows
Date: Tue, 17 Nov 2026 07:50:34 +0100 [thread overview]
Message-ID: <87eccklznp.fsf@pond.sub.org> (raw)
In-Reply-To: <20261116161608.1145725-2-eashurov@redhat.com> (Elizabeth Ashurov's message of "Mon, 16 Nov 2026 18:16:07 +0200")
Elizabeth Ashurov <eashurov@redhat.com> writes:
> Add a new guest-get-driver-packages command that returns out-of-box
> driver packages from the Windows Driver Store, enumerated via the
> DISM API (DismGetDrivers). Each entry includes the published INF
> name, original INF name, version, and provider.
>
> Load DismApi.dll dynamically with LoadLibraryExW so that its absence
> does not prevent qemu-ga from starting. Initialize DISM lazily once
> per QGA process and open a separate online DISM session for each
> command invocation, with process cleanup registered through
> ga_command_state_add.
>
> Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
[...]
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 8cd0ba048b..081c99bc74 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -1590,6 +1590,37 @@
> 'returns': ['GuestDeviceInfo'],
> 'if': 'CONFIG_WIN32' }
>
> +##
> +# @GuestDriverPackage:
> +#
> +# An out-of-box driver package installed in the guest.
Excuse my ignorance: what's an "out-of-box driver package"? Is this
established Windows terminology, or something you made up?
Please use the revised syntax for introductions:
##
# @GuestDriverPackage:
# An out-of-box driver package installed in the guest.
Same below.
> +#
> +# @name: published INF name
> +#
> +# @original-name: base name of the original INF file
> +#
> +# @version: four-part version from the package INF DriverVer entry
> +#
> +# @vendor: package provider from the INF metadata
> +#
> +# Since: 11.2
12.0
Same below.
> +##
> +{ 'struct': 'GuestDriverPackage',
> + 'data': { 'name': 'str', '*original-name': 'str', 'version': 'str',
> + '*vendor': 'str' },
> + 'if': 'CONFIG_WIN32' }
> +
> +##
> +# @guest-get-driver-packages:
> +#
> +# Retrieve out-of-box driver packages installed in the guest.
> +#
> +# Since: 11.2
> +##
> +{ 'command': 'guest-get-driver-packages',
> + 'returns': ['GuestDriverPackage'],
> + 'if': 'CONFIG_WIN32' }
> +
> ##
> # @GuestAuthorizedKeys:
> #
next prev parent reply other threads:[~2026-11-17 6:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:16 [PATCH v3 0/2] qga: Add Windows driver information commands Elizabeth Ashurov
2026-11-16 16:16 ` [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows Elizabeth Ashurov
2026-11-17 6:50 ` Markus Armbruster [this message]
2026-11-17 7:49 ` Kostiantyn Kostiuk
2026-11-17 9:51 ` Elizabeth Ashurov
2026-11-17 10:12 ` Markus Armbruster
2026-11-16 16:16 ` [PATCH v3 2/2] qga: Add guest-get-driver-services " Elizabeth Ashurov
2026-11-17 6:55 ` Markus Armbruster
2026-11-17 10:05 ` Elizabeth Ashurov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eccklznp.fsf@pond.sub.org \
--to=armbru@pond.sub.org \
--cc=armbru@redhat.com \
--cc=dholler@redhat.com \
--cc=eashurov@redhat.com \
--cc=fdeutsch@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=kramdoss@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.