All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] qga: Add Windows driver information commands
@ 2026-11-16 16:16 Elizabeth Ashurov
  2026-11-16 16:16 ` [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows Elizabeth Ashurov
  2026-11-16 16:16 ` [PATCH v3 2/2] qga: Add guest-get-driver-services " Elizabeth Ashurov
  0 siblings, 2 replies; 9+ messages in thread
From: Elizabeth Ashurov @ 2026-11-16 16:16 UTC (permalink / raw)
  To: qemu-devel
  Cc: kkostiuk, michael.roth, dholler, armbru, fdeutsch, yvugenfi,
	kramdoss, Elizabeth Ashurov

This series introduces two new QGA commands for Windows:
* guest-get-driver-packages: retrieve out-of-box driver packages from the
  Windows Driver Store.
* guest-get-driver-services: retrieve registered driver services and
  their metadata from the Service Control Manager and driver binaries.

Changes in v3:
Convert the NT path prefix (\??\) to the Win32 prefix (\\?\)
instead of removing it, to preserve volume GUID paths.
Patch 1 remains unchanged.

Elizabeth Ashurov (2):
  qga: Add guest-get-driver-packages command for Windows
  qga: Add guest-get-driver-services command for Windows

 qga/commands-win32.c | 656 +++++++++++++++++++++++++++++++++++++++++++
 qga/meson.build      |   5 +-
 qga/qapi-schema.json |  89 ++++++
 3 files changed, 748 insertions(+), 2 deletions(-)

-- 
2.55.0



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows
  2026-11-16 16:16 [PATCH v3 0/2] qga: Add Windows driver information commands Elizabeth Ashurov
@ 2026-11-16 16:16 ` Elizabeth Ashurov
  2026-11-17  6:50   ` Markus Armbruster
  2026-11-16 16:16 ` [PATCH v3 2/2] qga: Add guest-get-driver-services " Elizabeth Ashurov
  1 sibling, 1 reply; 9+ messages in thread
From: Elizabeth Ashurov @ 2026-11-16 16:16 UTC (permalink / raw)
  To: qemu-devel
  Cc: kkostiuk, michael.roth, dholler, armbru, fdeutsch, yvugenfi,
	kramdoss, Elizabeth Ashurov

Add a new guest-get-driver-packages command that returns out-of-box
driver packages from the Windows Driver Store, enumerated via the
DISM API (DismGetDrivers).  Each entry includes the published INF
name, original INF name, version, and provider.

Load DismApi.dll dynamically with LoadLibraryExW so that its absence
does not prevent qemu-ga from starting.  Initialize DISM lazily once
per QGA process and open a separate online DISM session for each
command invocation, with process cleanup registered through
ga_command_state_add.

Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
---
 qga/commands-win32.c | 292 +++++++++++++++++++++++++++++++++++++++++++
 qga/qapi-schema.json |  31 +++++
 2 files changed, 323 insertions(+)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 2bf5581aaa..e01033d8c5 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -28,6 +28,7 @@
 #include <wtsapi32.h>
 #include <wininet.h>
 #include <pdh.h>
+#include <dismapi.h>
 
 #include "guest-agent-core.h"
 #include "vss-win32.h"
@@ -1981,12 +1982,15 @@ done:
     g_free(rawpasswddata);
 }
 
+static void ga_cleanup_dism_api(void);
+
 /* register init/cleanup routines for stateful command groups */
 void ga_command_state_init(GAState *s, GACommandState *cs)
 {
     if (!vss_initialized()) {
         ga_command_state_add(cs, NULL, guest_fsfreeze_cleanup);
     }
+    ga_command_state_add(cs, NULL, ga_cleanup_dism_api);
 }
 
 /* MINGW is missing two fields: IncomingFrames & OutgoingFrames */
@@ -2455,6 +2459,294 @@ GuestDeviceInfoList *qmp_guest_get_devices(Error **errp)
     return head;
 }
 
+static void error_setg_dism(Error **errp, HRESULT hr, const char *msg)
+{
+    if (HRESULT_FACILITY(hr) == FACILITY_WIN32) {
+        error_setg_win32(errp, HRESULT_CODE(hr), "%s", msg);
+    } else {
+        error_setg(errp, "%s (HRESULT 0x%08" PRIx32 ")", msg,
+                   (uint32_t)hr);
+    }
+}
+
+static void ga_log_dism_error(HRESULT hr, const char *msg)
+{
+    Error *local_err = NULL;
+
+    error_setg_dism(&local_err, hr, msg);
+    slog("%s", error_get_pretty(local_err));
+    error_free(local_err);
+}
+
+typedef HRESULT WINAPI QGADismInitializeFunc(
+    DismLogLevel log_level, PCWSTR log_file_path, PCWSTR scratch_directory);
+typedef HRESULT WINAPI QGADismShutdownFunc(void);
+typedef HRESULT WINAPI QGADismOpenSessionFunc(
+    PCWSTR image_path, PCWSTR windows_directory, PCWSTR system_drive,
+    DismSession *session);
+typedef HRESULT WINAPI QGADismCloseSessionFunc(DismSession session);
+typedef HRESULT WINAPI QGADismGetDriversFunc(
+    DismSession session, WINBOOL all_drivers,
+    DismDriverPackage **driver_package, unsigned int *driver_count);
+typedef HRESULT WINAPI QGADismDeleteFunc(void *dism_structure);
+
+typedef struct QGADismApi {
+    HMODULE module;
+    QGADismInitializeFunc *initialize;
+    QGADismShutdownFunc *shutdown;
+    QGADismOpenSessionFunc *open_session;
+    QGADismCloseSessionFunc *close_session;
+    QGADismGetDriversFunc *get_drivers;
+    QGADismDeleteFunc *delete;
+} QGADismApi;
+
+static QGADismApi dism_api;
+static bool dism_initialized;
+
+static FARPROC ga_get_dism_function(HMODULE module, const char *name,
+                                    Error **errp)
+{
+    FARPROC function = GetProcAddress(module, name);
+
+    if (function == NULL) {
+        error_setg_win32(errp, GetLastError(),
+                         "failed to resolve %s from DismApi.dll", name);
+    }
+    return function;
+}
+
+static void ga_unload_dism_api(QGADismApi *api)
+{
+    if (api->module != NULL && !FreeLibrary(api->module)) {
+        slog("failed to unload DismApi.dll, error=%lu", GetLastError());
+    }
+    memset(api, 0, sizeof(*api));
+}
+
+/*
+ * Load DISM from System32 and resolve its entry points at runtime, so a
+ * missing DismApi.dll prevents only this command rather than QGA startup.
+ */
+static bool ga_load_dism_api(QGADismApi *api, Error **errp)
+{
+    api->module = LoadLibraryExW(L"DismApi.dll", NULL,
+                                 LOAD_LIBRARY_SEARCH_SYSTEM32);
+    if (api->module == NULL) {
+        error_setg_win32(errp, GetLastError(),
+                         "failed to load DismApi.dll");
+        return false;
+    }
+
+    api->initialize = (QGADismInitializeFunc *)
+        ga_get_dism_function(api->module, "DismInitialize", errp);
+    if (api->initialize == NULL) {
+        goto fail;
+    }
+    api->shutdown = (QGADismShutdownFunc *)
+        ga_get_dism_function(api->module, "DismShutdown", errp);
+    if (api->shutdown == NULL) {
+        goto fail;
+    }
+    api->open_session = (QGADismOpenSessionFunc *)
+        ga_get_dism_function(api->module, "DismOpenSession", errp);
+    if (api->open_session == NULL) {
+        goto fail;
+    }
+    api->close_session = (QGADismCloseSessionFunc *)
+        ga_get_dism_function(api->module, "DismCloseSession", errp);
+    if (api->close_session == NULL) {
+        goto fail;
+    }
+    api->get_drivers = (QGADismGetDriversFunc *)
+        ga_get_dism_function(api->module, "DismGetDrivers", errp);
+    if (api->get_drivers == NULL) {
+        goto fail;
+    }
+    api->delete = (QGADismDeleteFunc *)
+        ga_get_dism_function(api->module, "DismDelete", errp);
+    if (api->delete == NULL) {
+        goto fail;
+    }
+
+    return true;
+
+fail:
+    ga_unload_dism_api(api);
+    return false;
+}
+
+static bool ga_ensure_dism_api(Error **errp)
+{
+    HRESULT hr;
+
+    if (dism_initialized) {
+        return true;
+    }
+
+    if (!ga_load_dism_api(&dism_api, errp)) {
+        return false;
+    }
+
+    hr = dism_api.initialize(DismLogErrors, NULL, NULL);
+    if (FAILED(hr)) {
+        error_setg_dism(errp, hr, "failed to initialize DISM");
+        ga_unload_dism_api(&dism_api);
+        return false;
+    }
+
+    dism_initialized = true;
+    return true;
+}
+
+static void ga_cleanup_dism_api(void)
+{
+    HRESULT hr;
+
+    if (dism_initialized) {
+        hr = dism_api.shutdown();
+        if (FAILED(hr)) {
+            ga_log_dism_error(hr, "failed to shut down DISM");
+        }
+        dism_initialized = false;
+    }
+
+    ga_unload_dism_api(&dism_api);
+}
+
+static char *ga_utf16_to_utf8_required(const WCHAR *str, const char *name,
+                                       Error **errp)
+{
+    g_autoptr(GError) gerr = NULL;
+    char *ret;
+
+    if (str == NULL || str[0] == L'\0') {
+        error_setg(errp, "driver %s is missing", name);
+        return NULL;
+    }
+
+    ret = g_utf16_to_utf8(str, -1, NULL, NULL, &gerr);
+    if (ret == NULL) {
+        error_setg(errp, "failed to convert driver %s to UTF-8: %s",
+                   name, gerr->message);
+    }
+    return ret;
+}
+
+static const WCHAR *ga_windows_path_basename(const WCHAR *path)
+{
+    const WCHAR *name = path;
+
+    while (*path != L'\0') {
+        if (*path == L'\\' || *path == L'/') {
+            name = path + 1;
+        }
+        path++;
+    }
+    return name;
+}
+
+GuestDriverPackageList *qmp_guest_get_driver_packages(Error **errp)
+{
+    GuestDriverPackageList *head = NULL, **tail = &head;
+    DismSession session = DISM_SESSION_DEFAULT;
+    DismDriverPackage *drivers = NULL;
+    Error *local_err = NULL;
+    HRESULT hr;
+    UINT count = 0;
+    UINT i;
+
+    if (!ga_ensure_dism_api(&local_err)) {
+        goto out;
+    }
+
+    hr = dism_api.open_session(DISM_ONLINE_IMAGE, NULL, NULL, &session);
+    if (FAILED(hr)) {
+        error_setg_dism(&local_err, hr,
+                        "failed to open online DISM session");
+        goto out;
+    }
+
+    /*
+     * FALSE retrieves only out-of-box drivers, meaning drivers that were
+     * not originally included in the Windows image. See:
+     * https://learn.microsoft.com/en-us/windows-hardware/manufacture/desktop/dism/dismgetdrivers-function
+     */
+    hr = dism_api.get_drivers(session, FALSE, &drivers, &count);
+    if (FAILED(hr)) {
+        error_setg_dism(&local_err, hr,
+                        "failed to enumerate driver packages");
+        goto out;
+    }
+
+    for (i = 0; i < count; i++) {
+        g_autoptr(GuestDriverPackage) package = NULL;
+
+        package = g_new0(GuestDriverPackage, 1);
+        package->name = ga_utf16_to_utf8_required(drivers[i].PublishedName,
+                                                  "package name", &local_err);
+        if (package->name == NULL) {
+            goto out;
+        }
+
+        if (drivers[i].OriginalFileName != NULL &&
+            drivers[i].OriginalFileName[0] != L'\0') {
+            const WCHAR *original_name = ga_windows_path_basename(
+                drivers[i].OriginalFileName);
+
+            if (original_name[0] != L'\0') {
+                package->original_name = g_utf16_to_utf8(
+                    original_name, -1, NULL, NULL, NULL);
+            }
+        }
+
+        package->version = g_strdup_printf("%u.%u.%u.%u",
+                                           drivers[i].MajorVersion,
+                                           drivers[i].MinorVersion,
+                                           drivers[i].Build,
+                                           drivers[i].Revision);
+
+        if (drivers[i].ProviderName != NULL &&
+            drivers[i].ProviderName[0] != L'\0') {
+            package->vendor = g_utf16_to_utf8(drivers[i].ProviderName, -1,
+                                              NULL, NULL, NULL);
+        }
+
+        QAPI_LIST_APPEND(tail, g_steal_pointer(&package));
+    }
+
+out:
+    if (drivers != NULL) {
+        hr = dism_api.delete(drivers);
+        if (FAILED(hr)) {
+            if (local_err == NULL) {
+                error_setg_dism(&local_err, hr,
+                                "failed to release driver package data");
+            } else {
+                ga_log_dism_error(hr,
+                                  "failed to release driver package data");
+            }
+        }
+    }
+    if (session != DISM_SESSION_DEFAULT) {
+        hr = dism_api.close_session(session);
+        if (FAILED(hr)) {
+            if (local_err == NULL) {
+                error_setg_dism(&local_err, hr,
+                                "failed to close online DISM session");
+            } else {
+                ga_log_dism_error(hr,
+                                  "failed to close online DISM session");
+            }
+        }
+    }
+    if (local_err != NULL) {
+        qapi_free_GuestDriverPackageList(head);
+        head = NULL;
+        error_propagate(errp, local_err);
+    }
+    return head;
+}
+
 char *qga_get_host_name(Error **errp)
 {
     wchar_t tmp[MAX_COMPUTERNAME_LENGTH + 1];
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 8cd0ba048b..081c99bc74 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -1590,6 +1590,37 @@
   'returns': ['GuestDeviceInfo'],
   'if': 'CONFIG_WIN32' }
 
+##
+# @GuestDriverPackage:
+#
+# An out-of-box driver package installed in the guest.
+#
+# @name: published INF name
+#
+# @original-name: base name of the original INF file
+#
+# @version: four-part version from the package INF DriverVer entry
+#
+# @vendor: package provider from the INF metadata
+#
+# Since: 11.2
+##
+{ 'struct': 'GuestDriverPackage',
+  'data': { 'name': 'str', '*original-name': 'str', 'version': 'str',
+            '*vendor': 'str' },
+  'if': 'CONFIG_WIN32' }
+
+##
+# @guest-get-driver-packages:
+#
+# Retrieve out-of-box driver packages installed in the guest.
+#
+# Since: 11.2
+##
+{ 'command': 'guest-get-driver-packages',
+  'returns': ['GuestDriverPackage'],
+  'if': 'CONFIG_WIN32' }
+
 ##
 # @GuestAuthorizedKeys:
 #
-- 
2.55.0



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v3 2/2] qga: Add guest-get-driver-services command for Windows
  2026-11-16 16:16 [PATCH v3 0/2] qga: Add Windows driver information commands Elizabeth Ashurov
  2026-11-16 16:16 ` [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows Elizabeth Ashurov
@ 2026-11-16 16:16 ` Elizabeth Ashurov
  2026-11-17  6:55   ` Markus Armbruster
  1 sibling, 1 reply; 9+ messages in thread
From: Elizabeth Ashurov @ 2026-11-16 16:16 UTC (permalink / raw)
  To: qemu-devel
  Cc: kkostiuk, michael.roth, dholler, armbru, fdeutsch, yvugenfi,
	kramdoss, Elizabeth Ashurov

Add a new guest-get-driver-services command that returns registered
driver services from the Service Control Manager
(EnumServicesStatusExW).  Each entry includes the service name,
configured binary path, current SCM status, and FileVersion and
CompanyName metadata extracted from the driver binary.

Normalize driver binary paths from the service database before
reading version resources, including SystemRoot,
environment-variable, NT-prefix, and relative path forms.

Unrecognized SCM service states are reported as "unknown" with a
log message rather than aborting the enumeration, so that future
Windows versions do not break the command.

Link against version.dll (-lversion) for the GetFileVersionInfo
and VerQueryValue APIs.

Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
---
 qga/commands-win32.c | 364 +++++++++++++++++++++++++++++++++++++++++++
 qga/meson.build      |   5 +-
 qga/qapi-schema.json |  58 +++++++
 3 files changed, 425 insertions(+), 2 deletions(-)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index e01033d8c5..e11260c8f0 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -29,6 +29,7 @@
 #include <wininet.h>
 #include <pdh.h>
 #include <dismapi.h>
+#include <winver.h>
 
 #include "guest-agent-core.h"
 #include "vss-win32.h"
@@ -2747,6 +2748,369 @@ out:
     return head;
 }
 
+static GuestDriverServiceStatus ga_driver_service_status(DWORD state)
+{
+    switch (state) {
+    case SERVICE_STOPPED:
+        return GUEST_DRIVER_SERVICE_STATUS_STOPPED;
+    case SERVICE_START_PENDING:
+        return GUEST_DRIVER_SERVICE_STATUS_START_PENDING;
+    case SERVICE_STOP_PENDING:
+        return GUEST_DRIVER_SERVICE_STATUS_STOP_PENDING;
+    case SERVICE_RUNNING:
+        return GUEST_DRIVER_SERVICE_STATUS_RUNNING;
+    case SERVICE_CONTINUE_PENDING:
+        return GUEST_DRIVER_SERVICE_STATUS_CONTINUE_PENDING;
+    case SERVICE_PAUSE_PENDING:
+        return GUEST_DRIVER_SERVICE_STATUS_PAUSE_PENDING;
+    case SERVICE_PAUSED:
+        return GUEST_DRIVER_SERVICE_STATUS_PAUSED;
+    default:
+        return GUEST_DRIVER_SERVICE_STATUS_UNKNOWN;
+    }
+}
+
+/* Convert an SCM driver path into a path usable by Win32 file APIs. */
+static WCHAR *ga_resolve_driver_path(const WCHAR *path)
+{
+    WCHAR windows_dir[MAX_PATH + 1];
+    g_autofree WCHAR *trimmed = NULL;
+    g_autofree WCHAR *expanded = NULL;
+    const WCHAR *start = path;
+    const WCHAR *end;
+    const WCHAR *remainder = NULL;
+    size_t prefix_len;
+    size_t path_len;
+    size_t windows_len;
+    DWORD expanded_len;
+    UINT windows_dir_len;
+
+    while (*start != L'\0' && iswspace(*start)) {
+        start++;
+    }
+    end = start + wcslen(start);
+    while (end > start && iswspace(end[-1])) {
+        end--;
+    }
+    if (end - start >= 2 && start[0] == L'"' && end[-1] == L'"') {
+        start++;
+        end--;
+    }
+    if (end == start) {
+        return NULL;
+    }
+
+    path_len = end - start;
+    trimmed = g_new(WCHAR, path_len + 1);
+    memcpy(trimmed, start, path_len * sizeof(WCHAR));
+    trimmed[path_len] = L'\0';
+
+    expanded_len = ExpandEnvironmentStringsW(trimmed, NULL, 0);
+    if (expanded_len == 0) {
+        return NULL;
+    }
+    expanded = g_new(WCHAR, expanded_len);
+    path_len = ExpandEnvironmentStringsW(trimmed, expanded, expanded_len);
+    if (path_len == 0 || path_len > expanded_len) {
+        return NULL;
+    }
+
+    prefix_len = wcslen(L"\\SystemRoot");
+    if (_wcsnicmp(expanded, L"\\SystemRoot", prefix_len) == 0 &&
+        (expanded[prefix_len] == L'\0' ||
+         expanded[prefix_len] == L'\\' ||
+         expanded[prefix_len] == L'/')) {
+        remainder = expanded + prefix_len;
+    } else {
+        prefix_len = wcslen(L"SystemRoot");
+        if (_wcsnicmp(expanded, L"SystemRoot", prefix_len) == 0 &&
+            (expanded[prefix_len] == L'\0' ||
+             expanded[prefix_len] == L'\\' ||
+             expanded[prefix_len] == L'/')) {
+            remainder = expanded + prefix_len;
+        }
+    }
+
+    windows_dir_len = GetWindowsDirectoryW(windows_dir,
+                                            ARRAY_SIZE(windows_dir));
+    if (windows_dir_len == 0 || windows_dir_len >= ARRAY_SIZE(windows_dir)) {
+        return NULL;
+    }
+    windows_len = windows_dir_len;
+
+    if (remainder != NULL) {
+        WCHAR *ret = g_new(WCHAR, windows_len + wcslen(remainder) + 1);
+
+        memcpy(ret, windows_dir, windows_len * sizeof(WCHAR));
+        wcscpy(ret + windows_len, remainder);
+        return ret;
+    }
+
+    if (wcsncmp(expanded, L"\\??\\", 4) == 0) {
+        expanded[1] = L'\\';
+
+        return g_steal_pointer(&expanded);
+    }
+
+    if ((iswalpha(expanded[0]) && expanded[1] == L':') ||
+        expanded[0] == L'\\') {
+        return g_steal_pointer(&expanded);
+    }
+
+    path_len = wcslen(expanded);
+    start = expanded;
+    while (*start == L'\\' || *start == L'/') {
+        start++;
+        path_len--;
+    }
+    {
+        WCHAR *ret = g_new(WCHAR, windows_len + path_len + 2);
+
+        memcpy(ret, windows_dir, windows_len * sizeof(WCHAR));
+        ret[windows_len] = L'\\';
+        wcscpy(ret + windows_len + 1, start);
+        return ret;
+    }
+}
+
+typedef struct QGAVersionTranslation {
+    WORD language;
+    WORD code_page;
+} QGAVersionTranslation;
+
+/* Return CompanyName from a localized file-version string table. */
+static char *ga_get_file_vendor(const void *version_info)
+{
+    QGAVersionTranslation *translations = NULL;
+    static const QGAVersionTranslation fallback = { 0x0409, 0x04b0 };
+    UINT translations_len = 0;
+    UINT count = 0;
+    UINT i;
+
+    if (VerQueryValueW(version_info, L"\\VarFileInfo\\Translation",
+                       (void **)&translations, &translations_len) &&
+        translations != NULL) {
+        count = translations_len / sizeof(*translations);
+    }
+
+    for (i = 0; i <= count; i++) {
+        const QGAVersionTranslation *translation;
+        WCHAR query[64];
+        WCHAR *company = NULL;
+        UINT company_len = 0;
+        char *vendor;
+
+        translation = i < count ? &translations[i] : &fallback;
+        swprintf(query, ARRAY_SIZE(query),
+                 L"\\StringFileInfo\\%04x%04x\\CompanyName",
+                 translation->language, translation->code_page);
+        if (!VerQueryValueW(version_info, query, (void **)&company,
+                            &company_len) || company_len <= 1) {
+            continue;
+        }
+        vendor = g_utf16_to_utf8(company, -1, NULL, NULL, NULL);
+        if (vendor != NULL && vendor[0] != '\0') {
+            return vendor;
+        }
+        g_free(vendor);
+    }
+    return NULL;
+}
+
+/* Add optional FileVersion and CompanyName data from a driver binary. */
+static bool ga_get_driver_file_metadata(const WCHAR *path,
+                                        GuestDriverService *service,
+                                        Error **errp)
+{
+    g_autofree void *version_info = NULL;
+    VS_FIXEDFILEINFO *fixed_info = NULL;
+    PVOID old_redirection = NULL;
+    DWORD ignored;
+    DWORD version_size;
+    UINT fixed_info_len;
+    bool redirection_disabled;
+    bool version_loaded = false;
+
+    redirection_disabled =
+        Wow64DisableWow64FsRedirection(&old_redirection);
+
+    version_size = GetFileVersionInfoSizeW(path, &ignored);
+    if (version_size != 0) {
+        version_info = g_malloc(version_size);
+        version_loaded = GetFileVersionInfoW(path, 0, version_size,
+                                             version_info);
+    }
+
+    if (redirection_disabled &&
+        !Wow64RevertWow64FsRedirection(old_redirection)) {
+        error_setg_win32(errp, GetLastError(),
+                         "failed to restore WOW64 filesystem redirection "
+                         "for driver service '%s'", service->name);
+        return false;
+    }
+
+    if (!version_loaded) {
+        return true;
+    }
+
+    if (VerQueryValueW(version_info, L"\\", (void **)&fixed_info,
+                       &fixed_info_len) &&
+        fixed_info_len >= sizeof(*fixed_info) &&
+        fixed_info->dwSignature == VS_FFI_SIGNATURE) {
+        service->version = g_strdup_printf(
+            "%u.%u.%u.%u",
+            HIWORD(fixed_info->dwFileVersionMS),
+            LOWORD(fixed_info->dwFileVersionMS),
+            HIWORD(fixed_info->dwFileVersionLS),
+            LOWORD(fixed_info->dwFileVersionLS));
+    }
+
+    service->vendor = ga_get_file_vendor(version_info);
+    return true;
+}
+
+/*
+ * Add optional configuration and binary metadata for one driver service.
+ * Ordinary per-service lookup failures leave optional fields unset.
+ */
+static bool ga_get_driver_service_config(SC_HANDLE manager,
+                                         const WCHAR *name,
+                                         GuestDriverService *service,
+                                         Error **errp)
+{
+    SC_HANDLE handle;
+    g_autofree QUERY_SERVICE_CONFIGW *config = NULL;
+    g_autofree WCHAR *resolved_path = NULL;
+    DWORD size = 0;
+    DWORD err;
+    bool success = true;
+
+    handle = OpenServiceW(manager, name, SERVICE_QUERY_CONFIG);
+    if (handle == NULL) {
+        slog("failed to open configuration for driver service '%s', "
+             "error=%lu", service->name, GetLastError());
+        return true;
+    }
+
+    QueryServiceConfigW(handle, NULL, 0, &size);
+    err = GetLastError();
+    if (err != ERROR_INSUFFICIENT_BUFFER) {
+        slog("failed to get configuration size for driver service '%s', "
+             "error=%lu", service->name, err);
+        goto out;
+    }
+
+    config = g_malloc(size);
+    if (!QueryServiceConfigW(handle, config, size, &size)) {
+        slog("failed to get configuration for driver service '%s', "
+             "error=%lu", service->name, GetLastError());
+        goto out;
+    }
+
+    if (config->lpBinaryPathName == NULL ||
+        config->lpBinaryPathName[0] == L'\0') {
+        goto out;
+    }
+
+    service->driver_path = g_utf16_to_utf8(config->lpBinaryPathName, -1,
+                                           NULL, NULL, NULL);
+
+    resolved_path = ga_resolve_driver_path(config->lpBinaryPathName);
+    if (resolved_path != NULL &&
+        !ga_get_driver_file_metadata(resolved_path, service, errp)) {
+        success = false;
+    }
+
+out:
+    CloseServiceHandle(handle);
+    return success;
+}
+
+GuestDriverServiceList *qmp_guest_get_driver_services(Error **errp)
+{
+    GuestDriverServiceList *head = NULL, **tail = &head;
+    g_autofree BYTE *buffer = NULL;
+    SC_HANDLE manager = NULL;
+    DWORD buffer_size = 256 * 1024;
+    DWORD bytes_needed;
+    DWORD services_returned;
+    DWORD resume = 0;
+    DWORD err;
+    bool complete;
+    bool success = false;
+
+    manager = OpenSCManagerW(NULL, NULL, SC_MANAGER_ENUMERATE_SERVICE);
+    if (manager == NULL) {
+        error_setg_win32(errp, GetLastError(),
+                         "failed to open service control manager");
+        goto out;
+    }
+
+    buffer = g_malloc(buffer_size);
+    do {
+        ENUM_SERVICE_STATUS_PROCESSW *services;
+        DWORD i;
+
+        bytes_needed = 0;
+        services_returned = 0;
+        complete = EnumServicesStatusExW(manager, SC_ENUM_PROCESS_INFO,
+                                         SERVICE_DRIVER, SERVICE_STATE_ALL,
+                                         buffer, buffer_size, &bytes_needed,
+                                         &services_returned, &resume, NULL);
+        if (!complete) {
+            err = GetLastError();
+            if (err != ERROR_MORE_DATA) {
+                error_setg_win32(errp, err,
+                                 "failed to enumerate driver services");
+                goto out;
+            }
+            if (services_returned == 0) {
+                error_setg(errp, "driver service enumeration made no "
+                           "progress (buffer needs %lu bytes)", bytes_needed);
+                goto out;
+            }
+        }
+
+        services = (ENUM_SERVICE_STATUS_PROCESSW *)buffer;
+        for (i = 0; i < services_returned; i++) {
+            g_autoptr(GuestDriverService) service = NULL;
+
+            service = g_new0(GuestDriverService, 1);
+            service->name = ga_utf16_to_utf8_required(
+                services[i].lpServiceName, "service name", errp);
+            if (service->name == NULL) {
+                goto out;
+            }
+            service->status = ga_driver_service_status(
+                services[i].ServiceStatusProcess.dwCurrentState);
+            if (service->status == GUEST_DRIVER_SERVICE_STATUS_UNKNOWN) {
+                slog("driver service '%s' has unknown state %lu",
+                     service->name,
+                     services[i].ServiceStatusProcess.dwCurrentState);
+            }
+
+            if (!ga_get_driver_service_config(manager,
+                                              services[i].lpServiceName,
+                                              service, errp)) {
+                goto out;
+            }
+            QAPI_LIST_APPEND(tail, g_steal_pointer(&service));
+        }
+    } while (!complete);
+    success = true;
+
+out:
+    if (manager != NULL) {
+        CloseServiceHandle(manager);
+    }
+    if (!success) {
+        qapi_free_GuestDriverServiceList(head);
+        head = NULL;
+    }
+    return head;
+}
+
+
 char *qga_get_host_name(Error **errp)
 {
     wchar_t tmp[MAX_COMPUTERNAME_LENGTH + 1];
diff --git a/qga/meson.build b/qga/meson.build
index cfa2157efb..15860d938d 100644
--- a/qga/meson.build
+++ b/qga/meson.build
@@ -94,8 +94,9 @@ qga_ss = qga_ss.apply({})
 gen_tlb = []
 qga_libs = []
 if host_os == 'windows'
-  qga_libs += ['-lws2_32', '-lwinmm', '-lpowrprof', '-lwtsapi32', '-lwininet', '-liphlpapi', '-lnetapi32',
-               '-lsetupapi', '-lcfgmgr32', '-luserenv', '-lpdh' ]
+  qga_libs += ['-lws2_32', '-lwinmm', '-lpowrprof', '-lwtsapi32',
+               '-lwininet', '-liphlpapi', '-lnetapi32', '-lsetupapi',
+               '-lcfgmgr32', '-luserenv', '-lpdh', '-lversion' ]
   if have_qga_vss
     qga_libs += ['-lole32', '-loleaut32', '-lshlwapi', '-Wl,--enable-stdcall-fixup']
     subdir('vss-win32')
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 081c99bc74..913fe25924 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -1590,6 +1590,33 @@
   'returns': ['GuestDeviceInfo'],
   'if': 'CONFIG_WIN32' }
 
+##
+# @GuestDriverServiceStatus:
+#
+# @stopped: the service is stopped
+#
+# @start-pending: the service is starting
+#
+# @stop-pending: the service is stopping
+#
+# @running: the service is running
+#
+# @continue-pending: the service is resuming
+#
+# @pause-pending: the service is pausing
+#
+# @paused: the service is paused
+#
+# @unknown: SCM returned a service state not recognized by this
+#     QGA version
+#
+# Since: 11.2
+##
+{ 'enum': 'GuestDriverServiceStatus',
+  'data': [ 'stopped', 'start-pending', 'stop-pending', 'running',
+            'continue-pending', 'pause-pending', 'paused', 'unknown' ],
+  'if': 'CONFIG_WIN32' }
+
 ##
 # @GuestDriverPackage:
 #
@@ -1610,6 +1637,26 @@
             '*vendor': 'str' },
   'if': 'CONFIG_WIN32' }
 
+##
+# @GuestDriverService:
+#
+# @name: service name
+#
+# @driver-path: driver binary path configured in the service database
+#
+# @version: four-part FileVersion from the driver binary
+#
+# @vendor: CompanyName from the driver binary
+#
+# @status: current service status
+#
+# Since: 11.2
+##
+{ 'struct': 'GuestDriverService',
+  'data': { 'name': 'str', '*driver-path': 'str', '*version': 'str',
+            '*vendor': 'str', 'status': 'GuestDriverServiceStatus' },
+  'if': 'CONFIG_WIN32' }
+
 ##
 # @guest-get-driver-packages:
 #
@@ -1621,6 +1668,17 @@
   'returns': ['GuestDriverPackage'],
   'if': 'CONFIG_WIN32' }
 
+##
+# @guest-get-driver-services:
+#
+# Retrieve registered driver services in the guest.
+#
+# Since: 11.2
+##
+{ 'command': 'guest-get-driver-services',
+  'returns': ['GuestDriverService'],
+  'if': 'CONFIG_WIN32' }
+
 ##
 # @GuestAuthorizedKeys:
 #
-- 
2.55.0



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows
  2026-11-16 16:16 ` [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows Elizabeth Ashurov
@ 2026-11-17  6:50   ` Markus Armbruster
  2026-11-17  7:49     ` Kostiantyn Kostiuk
  0 siblings, 1 reply; 9+ messages in thread
From: Markus Armbruster @ 2026-11-17  6:50 UTC (permalink / raw)
  To: Elizabeth Ashurov
  Cc: qemu-devel, kkostiuk, michael.roth, dholler, armbru, fdeutsch,
	yvugenfi, kramdoss

Elizabeth Ashurov <eashurov@redhat.com> writes:

> Add a new guest-get-driver-packages command that returns out-of-box
> driver packages from the Windows Driver Store, enumerated via the
> DISM API (DismGetDrivers).  Each entry includes the published INF
> name, original INF name, version, and provider.
>
> Load DismApi.dll dynamically with LoadLibraryExW so that its absence
> does not prevent qemu-ga from starting.  Initialize DISM lazily once
> per QGA process and open a separate online DISM session for each
> command invocation, with process cleanup registered through
> ga_command_state_add.
>
> Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>

[...]

> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 8cd0ba048b..081c99bc74 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -1590,6 +1590,37 @@
>    'returns': ['GuestDeviceInfo'],
>    'if': 'CONFIG_WIN32' }
>  
> +##
> +# @GuestDriverPackage:
> +#
> +# An out-of-box driver package installed in the guest.

Excuse my ignorance: what's an "out-of-box driver package"?  Is this
established Windows terminology, or something you made up?

Please use the revised syntax for introductions:

   ##
   # @GuestDriverPackage:
   #     An out-of-box driver package installed in the guest.

Same below.

> +#
> +# @name: published INF name
> +#
> +# @original-name: base name of the original INF file
> +#
> +# @version: four-part version from the package INF DriverVer entry
> +#
> +# @vendor: package provider from the INF metadata
> +#
> +# Since: 11.2

12.0

Same below.

> +##
> +{ 'struct': 'GuestDriverPackage',
> +  'data': { 'name': 'str', '*original-name': 'str', 'version': 'str',
> +            '*vendor': 'str' },
> +  'if': 'CONFIG_WIN32' }
> +
> +##
> +# @guest-get-driver-packages:
> +#
> +# Retrieve out-of-box driver packages installed in the guest.
> +#
> +# Since: 11.2
> +##
> +{ 'command': 'guest-get-driver-packages',
> +  'returns': ['GuestDriverPackage'],
> +  'if': 'CONFIG_WIN32' }
> +
>  ##
>  # @GuestAuthorizedKeys:
>  #


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/2] qga: Add guest-get-driver-services command for Windows
  2026-11-16 16:16 ` [PATCH v3 2/2] qga: Add guest-get-driver-services " Elizabeth Ashurov
@ 2026-11-17  6:55   ` Markus Armbruster
  2026-11-17 10:05     ` Elizabeth Ashurov
  0 siblings, 1 reply; 9+ messages in thread
From: Markus Armbruster @ 2026-11-17  6:55 UTC (permalink / raw)
  To: Elizabeth Ashurov
  Cc: qemu-devel, kkostiuk, michael.roth, dholler, armbru, fdeutsch,
	yvugenfi, kramdoss

Elizabeth Ashurov <eashurov@redhat.com> writes:

> Add a new guest-get-driver-services command that returns registered
> driver services from the Service Control Manager
> (EnumServicesStatusExW).  Each entry includes the service name,
> configured binary path, current SCM status, and FileVersion and
> CompanyName metadata extracted from the driver binary.
>
> Normalize driver binary paths from the service database before
> reading version resources, including SystemRoot,
> environment-variable, NT-prefix, and relative path forms.
>
> Unrecognized SCM service states are reported as "unknown" with a
> log message rather than aborting the enumeration, so that future
> Windows versions do not break the command.
>
> Link against version.dll (-lversion) for the GetFileVersionInfo
> and VerQueryValue APIs.
>
> Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>

[...]

> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 081c99bc74..913fe25924 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -1590,6 +1590,33 @@
>    'returns': ['GuestDeviceInfo'],
>    'if': 'CONFIG_WIN32' }
>  
> +##
> +# @GuestDriverServiceStatus:
> +#
> +# @stopped: the service is stopped
> +#
> +# @start-pending: the service is starting
> +#
> +# @stop-pending: the service is stopping
> +#
> +# @running: the service is running
> +#
> +# @continue-pending: the service is resuming
> +#
> +# @pause-pending: the service is pausing
> +#
> +# @paused: the service is paused
> +#
> +# @unknown: SCM returned a service state not recognized by this
> +#     QGA version
> +#
> +# Since: 11.2

12.0

More of the same below.

> +##
> +{ 'enum': 'GuestDriverServiceStatus',
> +  'data': [ 'stopped', 'start-pending', 'stop-pending', 'running',
> +            'continue-pending', 'pause-pending', 'paused', 'unknown' ],
> +  'if': 'CONFIG_WIN32' }
> +
>  ##
>  # @GuestDriverPackage:
>  #
> @@ -1610,6 +1637,26 @@
>              '*vendor': 'str' },
>    'if': 'CONFIG_WIN32' }
>  
> +##
> +# @GuestDriverService:
> +#
> +# @name: service name
> +#
> +# @driver-path: driver binary path configured in the service database
> +#
> +# @version: four-part FileVersion from the driver binary
> +#
> +# @vendor: CompanyName from the driver binary

Are "FileVersion" and "CompanyName" established technical terms?

Are they necessary here, or could we simply say something like "driver
version" and "driver vendor name"?

> +#
> +# @status: current service status
> +#
> +# Since: 11.2
> +##
> +{ 'struct': 'GuestDriverService',
> +  'data': { 'name': 'str', '*driver-path': 'str', '*version': 'str',
> +            '*vendor': 'str', 'status': 'GuestDriverServiceStatus' },
> +  'if': 'CONFIG_WIN32' }
> +
>  ##
>  # @guest-get-driver-packages:
>  #
> @@ -1621,6 +1668,17 @@
>    'returns': ['GuestDriverPackage'],
>    'if': 'CONFIG_WIN32' }
>  
> +##
> +# @guest-get-driver-services:
> +#
> +# Retrieve registered driver services in the guest.

Please use the revised syntax for introductions:

   ##
   # @guest-get-driver-services:
   #     Retrieve registered driver services in the guest.

> +#
> +# Since: 11.2
> +##
> +{ 'command': 'guest-get-driver-services',
> +  'returns': ['GuestDriverService'],
> +  'if': 'CONFIG_WIN32' }
> +
>  ##
>  # @GuestAuthorizedKeys:
>  #


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows
  2026-11-17  6:50   ` Markus Armbruster
@ 2026-11-17  7:49     ` Kostiantyn Kostiuk
  2026-11-17  9:51       ` Elizabeth Ashurov
  2026-11-17 10:12       ` Markus Armbruster
  0 siblings, 2 replies; 9+ messages in thread
From: Kostiantyn Kostiuk @ 2026-11-17  7:49 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: Elizabeth Ashurov, qemu-devel, michael.roth, dholler, fdeutsch,
	yvugenfi, kramdoss

[-- Attachment #1: Type: text/plain, Size: 2532 bytes --]

On Tue, Nov 17, 2026 at 8:50 AM Markus Armbruster <armbru@redhat.com> wrote:

> Elizabeth Ashurov <eashurov@redhat.com> writes:
>
> > Add a new guest-get-driver-packages command that returns out-of-box
> > driver packages from the Windows Driver Store, enumerated via the
> > DISM API (DismGetDrivers).  Each entry includes the published INF
> > name, original INF name, version, and provider.
> >
> > Load DismApi.dll dynamically with LoadLibraryExW so that its absence
> > does not prevent qemu-ga from starting.  Initialize DISM lazily once
> > per QGA process and open a separate online DISM session for each
> > command invocation, with process cleanup registered through
> > ga_command_state_add.
> >
> > Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
>
> [...]
>
> > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> > index 8cd0ba048b..081c99bc74 100644
> > --- a/qga/qapi-schema.json
> > +++ b/qga/qapi-schema.json
> > @@ -1590,6 +1590,37 @@
> >    'returns': ['GuestDeviceInfo'],
> >    'if': 'CONFIG_WIN32' }
> >
> > +##
> > +# @GuestDriverPackage:
> > +#
> > +# An out-of-box driver package installed in the guest.
>
> Excuse my ignorance: what's an "out-of-box driver package"?  Is this
> established Windows terminology, or something you made up?
>

Inbox drivers and Out-of-Box drivers are MSFT terminology.
Inbox - preinstalled in Windows, built-in
Out-of-Box - OEM, Vendors drivers that should be installed manually


>
> Please use the revised syntax for introductions:
>
>    ##
>    # @GuestDriverPackage:
>    #     An out-of-box driver package installed in the guest.
>
> Same below.
>
> > +#
> > +# @name: published INF name
> > +#
> > +# @original-name: base name of the original INF file
> > +#
> > +# @version: four-part version from the package INF DriverVer entry
> > +#
> > +# @vendor: package provider from the INF metadata
> > +#
> > +# Since: 11.2
>
> 12.0
>
> Same below.
>
> > +##
> > +{ 'struct': 'GuestDriverPackage',
> > +  'data': { 'name': 'str', '*original-name': 'str', 'version': 'str',
> > +            '*vendor': 'str' },
> > +  'if': 'CONFIG_WIN32' }
> > +
> > +##
> > +# @guest-get-driver-packages:
> > +#
> > +# Retrieve out-of-box driver packages installed in the guest.
> > +#
> > +# Since: 11.2
> > +##
> > +{ 'command': 'guest-get-driver-packages',
> > +  'returns': ['GuestDriverPackage'],
> > +  'if': 'CONFIG_WIN32' }
> > +
> >  ##
> >  # @GuestAuthorizedKeys:
> >  #
>
>

[-- Attachment #2: Type: text/html, Size: 3718 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows
  2026-11-17  7:49     ` Kostiantyn Kostiuk
@ 2026-11-17  9:51       ` Elizabeth Ashurov
  2026-11-17 10:12       ` Markus Armbruster
  1 sibling, 0 replies; 9+ messages in thread
From: Elizabeth Ashurov @ 2026-11-17  9:51 UTC (permalink / raw)
  To: Kostiantyn Kostiuk
  Cc: Markus Armbruster, qemu-devel, michael.roth, dholler, fdeutsch,
	yvugenfi, kramdoss

[-- Attachment #1: Type: text/plain, Size: 2847 bytes --]

As Kostiantyn mentioned, this is indeed Microsoft terminology. I'll add a
brief explanation in v4.

Thanks for the review!

On Tue, Nov 17, 2026 at 9:49 AM Kostiantyn Kostiuk <kkostiuk@redhat.com>
wrote:

>
>
> On Tue, Nov 17, 2026 at 8:50 AM Markus Armbruster <armbru@redhat.com>
> wrote:
>
>> Elizabeth Ashurov <eashurov@redhat.com> writes:
>>
>> > Add a new guest-get-driver-packages command that returns out-of-box
>> > driver packages from the Windows Driver Store, enumerated via the
>> > DISM API (DismGetDrivers).  Each entry includes the published INF
>> > name, original INF name, version, and provider.
>> >
>> > Load DismApi.dll dynamically with LoadLibraryExW so that its absence
>> > does not prevent qemu-ga from starting.  Initialize DISM lazily once
>> > per QGA process and open a separate online DISM session for each
>> > command invocation, with process cleanup registered through
>> > ga_command_state_add.
>> >
>> > Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
>>
>> [...]
>>
>> > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
>> > index 8cd0ba048b..081c99bc74 100644
>> > --- a/qga/qapi-schema.json
>> > +++ b/qga/qapi-schema.json
>> > @@ -1590,6 +1590,37 @@
>> >    'returns': ['GuestDeviceInfo'],
>> >    'if': 'CONFIG_WIN32' }
>> >
>> > +##
>> > +# @GuestDriverPackage:
>> > +#
>> > +# An out-of-box driver package installed in the guest.
>>
>> Excuse my ignorance: what's an "out-of-box driver package"?  Is this
>> established Windows terminology, or something you made up?
>>
>
> Inbox drivers and Out-of-Box drivers are MSFT terminology.
> Inbox - preinstalled in Windows, built-in
> Out-of-Box - OEM, Vendors drivers that should be installed manually
>
>
>>
>> Please use the revised syntax for introductions:
>>
>>    ##
>>    # @GuestDriverPackage:
>>    #     An out-of-box driver package installed in the guest.
>>
>> Same below.
>>
>> > +#
>> > +# @name: published INF name
>> > +#
>> > +# @original-name: base name of the original INF file
>> > +#
>> > +# @version: four-part version from the package INF DriverVer entry
>> > +#
>> > +# @vendor: package provider from the INF metadata
>> > +#
>> > +# Since: 11.2
>>
>> 12.0
>>
>> Same below.
>>
>> > +##
>> > +{ 'struct': 'GuestDriverPackage',
>> > +  'data': { 'name': 'str', '*original-name': 'str', 'version': 'str',
>> > +            '*vendor': 'str' },
>> > +  'if': 'CONFIG_WIN32' }
>> > +
>> > +##
>> > +# @guest-get-driver-packages:
>> > +#
>> > +# Retrieve out-of-box driver packages installed in the guest.
>> > +#
>> > +# Since: 11.2
>> > +##
>> > +{ 'command': 'guest-get-driver-packages',
>> > +  'returns': ['GuestDriverPackage'],
>> > +  'if': 'CONFIG_WIN32' }
>> > +
>> >  ##
>> >  # @GuestAuthorizedKeys:
>> >  #
>>
>>

[-- Attachment #2: Type: text/html, Size: 4236 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/2] qga: Add guest-get-driver-services command for Windows
  2026-11-17  6:55   ` Markus Armbruster
@ 2026-11-17 10:05     ` Elizabeth Ashurov
  0 siblings, 0 replies; 9+ messages in thread
From: Elizabeth Ashurov @ 2026-11-17 10:05 UTC (permalink / raw)
  To: Markus Armbruster
  Cc: qemu-devel, kkostiuk, michael.roth, dholler, fdeutsch, yvugenfi,
	kramdoss

[-- Attachment #1: Type: text/plain, Size: 3861 bytes --]

Yes, we can simplify the descriptions to "four-part version of the driver
binary" and "driver vendor name from the driver binary".

On Tue, Nov 17, 2026 at 8:55 AM Markus Armbruster <armbru@redhat.com> wrote:

> Elizabeth Ashurov <eashurov@redhat.com> writes:
>
> > Add a new guest-get-driver-services command that returns registered
> > driver services from the Service Control Manager
> > (EnumServicesStatusExW).  Each entry includes the service name,
> > configured binary path, current SCM status, and FileVersion and
> > CompanyName metadata extracted from the driver binary.
> >
> > Normalize driver binary paths from the service database before
> > reading version resources, including SystemRoot,
> > environment-variable, NT-prefix, and relative path forms.
> >
> > Unrecognized SCM service states are reported as "unknown" with a
> > log message rather than aborting the enumeration, so that future
> > Windows versions do not break the command.
> >
> > Link against version.dll (-lversion) for the GetFileVersionInfo
> > and VerQueryValue APIs.
> >
> > Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
>
> [...]
>
> > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> > index 081c99bc74..913fe25924 100644
> > --- a/qga/qapi-schema.json
> > +++ b/qga/qapi-schema.json
> > @@ -1590,6 +1590,33 @@
> >    'returns': ['GuestDeviceInfo'],
> >    'if': 'CONFIG_WIN32' }
> >
> > +##
> > +# @GuestDriverServiceStatus:
> > +#
> > +# @stopped: the service is stopped
> > +#
> > +# @start-pending: the service is starting
> > +#
> > +# @stop-pending: the service is stopping
> > +#
> > +# @running: the service is running
> > +#
> > +# @continue-pending: the service is resuming
> > +#
> > +# @pause-pending: the service is pausing
> > +#
> > +# @paused: the service is paused
> > +#
> > +# @unknown: SCM returned a service state not recognized by this
> > +#     QGA version
> > +#
> > +# Since: 11.2
>
> 12.0
>
> More of the same below.
>
> > +##
> > +{ 'enum': 'GuestDriverServiceStatus',
> > +  'data': [ 'stopped', 'start-pending', 'stop-pending', 'running',
> > +            'continue-pending', 'pause-pending', 'paused', 'unknown' ],
> > +  'if': 'CONFIG_WIN32' }
> > +
> >  ##
> >  # @GuestDriverPackage:
> >  #
> > @@ -1610,6 +1637,26 @@
> >              '*vendor': 'str' },
> >    'if': 'CONFIG_WIN32' }
> >
> > +##
> > +# @GuestDriverService:
> > +#
> > +# @name: service name
> > +#
> > +# @driver-path: driver binary path configured in the service database
> > +#
> > +# @version: four-part FileVersion from the driver binary
> > +#
> > +# @vendor: CompanyName from the driver binary
>
> Are "FileVersion" and "CompanyName" established technical terms?
>
> Are they necessary here, or could we simply say something like "driver
> version" and "driver vendor name"?
>
> > +#
> > +# @status: current service status
> > +#
> > +# Since: 11.2
> > +##
> > +{ 'struct': 'GuestDriverService',
> > +  'data': { 'name': 'str', '*driver-path': 'str', '*version': 'str',
> > +            '*vendor': 'str', 'status': 'GuestDriverServiceStatus' },
> > +  'if': 'CONFIG_WIN32' }
> > +
> >  ##
> >  # @guest-get-driver-packages:
> >  #
> > @@ -1621,6 +1668,17 @@
> >    'returns': ['GuestDriverPackage'],
> >    'if': 'CONFIG_WIN32' }
> >
> > +##
> > +# @guest-get-driver-services:
> > +#
> > +# Retrieve registered driver services in the guest.
>
> Please use the revised syntax for introductions:
>
>    ##
>    # @guest-get-driver-services:
>    #     Retrieve registered driver services in the guest.
>
> > +#
> > +# Since: 11.2
> > +##
> > +{ 'command': 'guest-get-driver-services',
> > +  'returns': ['GuestDriverService'],
> > +  'if': 'CONFIG_WIN32' }
> > +
> >  ##
> >  # @GuestAuthorizedKeys:
> >  #
>
>

[-- Attachment #2: Type: text/html, Size: 5355 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows
  2026-11-17  7:49     ` Kostiantyn Kostiuk
  2026-11-17  9:51       ` Elizabeth Ashurov
@ 2026-11-17 10:12       ` Markus Armbruster
  1 sibling, 0 replies; 9+ messages in thread
From: Markus Armbruster @ 2026-11-17 10:12 UTC (permalink / raw)
  To: Kostiantyn Kostiuk
  Cc: Elizabeth Ashurov, qemu-devel, michael.roth, dholler, fdeutsch,
	yvugenfi, kramdoss

Kostiantyn Kostiuk <kkostiuk@redhat.com> writes:

> On Tue, Nov 17, 2026 at 8:50 AM Markus Armbruster <armbru@redhat.com> wrote:
>
>> Elizabeth Ashurov <eashurov@redhat.com> writes:
>>
>> > Add a new guest-get-driver-packages command that returns out-of-box
>> > driver packages from the Windows Driver Store, enumerated via the
>> > DISM API (DismGetDrivers).  Each entry includes the published INF
>> > name, original INF name, version, and provider.
>> >
>> > Load DismApi.dll dynamically with LoadLibraryExW so that its absence
>> > does not prevent qemu-ga from starting.  Initialize DISM lazily once
>> > per QGA process and open a separate online DISM session for each
>> > command invocation, with process cleanup registered through
>> > ga_command_state_add.
>> >
>> > Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
>>
>> [...]
>>
>> > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
>> > index 8cd0ba048b..081c99bc74 100644
>> > --- a/qga/qapi-schema.json
>> > +++ b/qga/qapi-schema.json
>> > @@ -1590,6 +1590,37 @@
>> >    'returns': ['GuestDeviceInfo'],
>> >    'if': 'CONFIG_WIN32' }
>> >
>> > +##
>> > +# @GuestDriverPackage:
>> > +#
>> > +# An out-of-box driver package installed in the guest.
>>
>> Excuse my ignorance: what's an "out-of-box driver package"?  Is this
>> established Windows terminology, or something you made up?
>>
>
> Inbox drivers and Out-of-Box drivers are MSFT terminology.
> Inbox - preinstalled in Windows, built-in
> Out-of-Box - OEM, Vendors drivers that should be installed manually

No objection then :)

Thanks!

[...]


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-11-17 10:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 16:16 [PATCH v3 0/2] qga: Add Windows driver information commands Elizabeth Ashurov
2026-11-16 16:16 ` [PATCH v3 1/2] qga: Add guest-get-driver-packages command for Windows Elizabeth Ashurov
2026-11-17  6:50   ` Markus Armbruster
2026-11-17  7:49     ` Kostiantyn Kostiuk
2026-11-17  9:51       ` Elizabeth Ashurov
2026-11-17 10:12       ` Markus Armbruster
2026-11-16 16:16 ` [PATCH v3 2/2] qga: Add guest-get-driver-services " Elizabeth Ashurov
2026-11-17  6:55   ` Markus Armbruster
2026-11-17 10:05     ` Elizabeth Ashurov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.