From: John Ogness <john.ogness@linutronix.de>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Breno Leitao <leitao@debian.org>,
printk@lists.linux.dev, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH printk 2/6] console: Introduce unsafe flush policy flags
Date: Tue, 10 Nov 2026 09:55:15 +0106 [thread overview]
Message-ID: <87eccthy0k.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <avJDvDl0Hcx_CEGY@ashevche-desk.local>
On 2026-11-10, Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, Nov 09, 2026 at 01:37:19PM +0106, John Ogness wrote:
>> Prepare for per-console atomic flushing policies by introducing a
>> new nbcon-specific console field @unsafe_flush_flags to store the
>> unsafe flush policies for a console. The policies are represented
>> by bits, specified by enum nbcon_unsafe_flush_flags.
>>
>> Currently it is expected that any @unsafe_flush_flags bits are set
>> prior to console registration and do not change while registered.
>>
>> No functional change.
>
> ...
>
>> + int unsafe_flush_flags;
>
> Why are flags signed?
It is not relevant and all other flags in struct console are signed, so
I figured it would blend in. I will change it to unsigned for v2.
Thanks for taking a look.
John
next prev parent reply other threads:[~2026-11-10 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 12:31 [PATCH printk 0/6] Introduce policies for unsafe flushing John Ogness
2026-11-09 12:31 ` [PATCH printk 1/6] printk: Introduce and specify flush reasons John Ogness
2026-11-09 16:37 ` kernel test robot
2026-11-09 12:31 ` [PATCH printk 2/6] console: Introduce unsafe flush policy flags John Ogness
2026-11-09 22:05 ` Andy Shevchenko
2026-11-10 8:49 ` John Ogness [this message]
2026-11-09 12:31 ` [PATCH printk 3/6] printk: Evaluate flush policy in nbcon_allow_unsafe_takeover() John Ogness
2026-11-09 14:08 ` Breno Leitao
2026-11-09 14:28 ` John Ogness
2026-11-09 16:47 ` Breno Leitao
2026-11-09 12:31 ` [PATCH printk 4/6] printk: Remove nbcon_atomic_flush_unsafe() John Ogness
2026-11-09 12:31 ` [PATCH printk 5/6] printk: Add panic+kexec flush point John Ogness
2026-11-10 12:31 ` sashiko-bot
2026-11-09 12:31 ` [PATCH printk 6/6] netconsole: Always perform unsafe flushing on panic/kdb/restart John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eccthy0k.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=printk@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=ryan.roberts@arm.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.