[PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[Shekhar Chauhan]

igt_has_intel_wa() returns 0, 1, or -1, but there is no point
distinguishing the error and no-workaround cases for callers. Replace
the error return with igt_assert() and simplify debugfs_file_has_wa() by
dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
NULL for missing files anyway.

v2: Make the func as bool instead of int.

Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
---
 lib/intel_wa.c | 19 +++++++++----------
 lib/intel_wa.h |  2 +-
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/lib/intel_wa.c b/lib/intel_wa.c
index 727dd6c98..e4fe7b0ee 100644
--- a/lib/intel_wa.c
+++ b/lib/intel_wa.c
@@ -7,18 +7,18 @@
 #include <stdint.h>
 #include <stdio.h>
 
+#include "igt_core.h"
 #include "igt_debugfs.h"
 #include "igt_sysfs.h"
 #include "intel_wa.h"
 #include "xe/xe_query.h"
 
-static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
+static bool debugfs_file_has_wa(int drm_fd, int debugfs_fd,
 			       const char *debugfs_name, const char *wa)
 {
 	char *debugfs_dump;
 
-	if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
-		return -1;
+	igt_assert(igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY));
 
 	debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
 	if (debugfs_dump) {
@@ -27,10 +27,10 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
 		free(debugfs_dump);
 
 		if (has_wa)
-			return 1;
+			return true;
 	}
 
-	return 0;
+	return false;
 }
 
 /**
@@ -38,18 +38,17 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
  * @drm_fd:	A drm file descriptor
  * @check_wa:	Workaround to be checked
  *
- * Returns:	0 if no WA, 1 if WA present, -1 on error
+ * Returns:	true if WA present, false otherwise
  */
-int igt_has_intel_wa(int drm_fd, const char *check_wa)
+bool igt_has_intel_wa(int drm_fd, const char *check_wa)
 {
-	int ret = 0;
+	bool ret = 0;
 	int debugfs_fd;
 	unsigned int xe;
 	char name[256];
 
 	debugfs_fd = igt_debugfs_dir(drm_fd);
-	if (debugfs_fd == -1)
-		return -1;
+	igt_assert(debugfs_fd >= 0);
 
 	xe_for_each_gt(drm_fd, xe) {
 		sprintf(name, "gt%d/workarounds", xe);
diff --git a/lib/intel_wa.h b/lib/intel_wa.h
index 765a5948e..34cafecc4 100644
--- a/lib/intel_wa.h
+++ b/lib/intel_wa.h
@@ -6,6 +6,6 @@
 #ifndef __INTEL_WA_H__
 #define __INTEL_WA_H__
 
-int igt_has_intel_wa(int drm_fd, const char *check_wa);
+bool igt_has_intel_wa(int drm_fd, const char *check_wa);
 
 #endif /* __INTEL_WA_H__ */
-- 
2.53.0

Re: [PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[Dixit, Ashutosh]

On Wed, 13 May 2026 23:36:55 -0700, Shekhar Chauhan wrote:
>
> igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> distinguishing the error and no-workaround cases for callers. Replace
> the error return with igt_assert() and simplify debugfs_file_has_wa() by
> dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> NULL for missing files anyway.
>
> v2: Make the func as bool instead of int.

LGTM now:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> ---
>  lib/intel_wa.c | 19 +++++++++----------
>  lib/intel_wa.h |  2 +-
>  2 files changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> index 727dd6c98..e4fe7b0ee 100644
> --- a/lib/intel_wa.c
> +++ b/lib/intel_wa.c
> @@ -7,18 +7,18 @@
>  #include <stdint.h>
>  #include <stdio.h>
>
> +#include "igt_core.h"
>  #include "igt_debugfs.h"
>  #include "igt_sysfs.h"
>  #include "intel_wa.h"
>  #include "xe/xe_query.h"
>
> -static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> +static bool debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>			       const char *debugfs_name, const char *wa)
>  {
>	char *debugfs_dump;
>
> -	if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> -		return -1;
> +	igt_assert(igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY));
>
>	debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
>	if (debugfs_dump) {
> @@ -27,10 +27,10 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>		free(debugfs_dump);
>
>		if (has_wa)
> -			return 1;
> +			return true;
>	}
>
> -	return 0;
> +	return false;
>  }
>
>  /**
> @@ -38,18 +38,17 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>   * @drm_fd:	A drm file descriptor
>   * @check_wa:	Workaround to be checked
>   *
> - * Returns:	0 if no WA, 1 if WA present, -1 on error
> + * Returns:	true if WA present, false otherwise
>   */
> -int igt_has_intel_wa(int drm_fd, const char *check_wa)
> +bool igt_has_intel_wa(int drm_fd, const char *check_wa)
>  {
> -	int ret = 0;
> +	bool ret = 0;
>	int debugfs_fd;
>	unsigned int xe;
>	char name[256];
>
>	debugfs_fd = igt_debugfs_dir(drm_fd);
> -	if (debugfs_fd == -1)
> -		return -1;
> +	igt_assert(debugfs_fd >= 0);
>
>	xe_for_each_gt(drm_fd, xe) {
>		sprintf(name, "gt%d/workarounds", xe);
> diff --git a/lib/intel_wa.h b/lib/intel_wa.h
> index 765a5948e..34cafecc4 100644
> --- a/lib/intel_wa.h
> +++ b/lib/intel_wa.h
> @@ -6,6 +6,6 @@
>  #ifndef __INTEL_WA_H__
>  #define __INTEL_WA_H__
>
> -int igt_has_intel_wa(int drm_fd, const char *check_wa);
> +bool igt_has_intel_wa(int drm_fd, const char *check_wa);
>
>  #endif /* __INTEL_WA_H__ */
> --
> 2.53.0
>

✗ i915.CI.BAT: failure for lib/intel_wa: Assert on error instead of returning -1

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2793 bytes --]

== Series Details ==

Series: lib/intel_wa: Assert on error instead of returning -1
URL   : https://patchwork.freedesktop.org/series/166558/
State : failure

== Summary ==

CI Bug Log - changes from IGT_8911 -> IGTPW_15183
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_15183 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_15183, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15183/index.html

Participating hosts (41 -> 39)
------------------------------

  Missing    (2): bat-dg2-13 bat-adls-6 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_15183:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_flip@basic-flip-vs-dpms@c-dp1:
    - bat-adlp-9:         [PASS][1] -> [FAIL][2] +2 other tests fail
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8911/bat-adlp-9/igt@kms_flip@basic-flip-vs-dpms@c-dp1.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15183/bat-adlp-9/igt@kms_flip@basic-flip-vs-dpms@c-dp1.html

  
Known issues
------------

  Here are the changes found in IGTPW_15183 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_selftest@live@workarounds:
    - bat-dg2-14:         [DMESG-FAIL][3] ([i915#12061]) -> [PASS][4] +1 other test pass
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8911/bat-dg2-14/igt@i915_selftest@live@workarounds.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15183/bat-dg2-14/igt@i915_selftest@live@workarounds.html
    - bat-mtlp-9:         [DMESG-FAIL][5] ([i915#12061]) -> [PASS][6] +1 other test pass
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8911/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15183/bat-mtlp-9/igt@i915_selftest@live@workarounds.html

  
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_8911 -> IGTPW_15183

  CI-20190529: 20190529
  CI_DRM_18488: dee34cfbffbfe2196a9332f966b006cd2e54e976 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_15183: 8c06dc420933d6e73f9bd4f7cad0f4281e94ad0c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  IGT_8911: c7f4a459bf125a487220a0b56f5f17cc0721c541 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15183/index.html

[-- Attachment #2: Type: text/html, Size: 3502 bytes --]

✓ Xe.CI.BAT: success for lib/intel_wa: Assert on error instead of returning -1

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

== Series Details ==

Series: lib/intel_wa: Assert on error instead of returning -1
URL   : https://patchwork.freedesktop.org/series/166558/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_8911_BAT -> XEIGTPW_15183_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (13 -> 12)
------------------------------

  Missing    (1): bat-atsm-2 


Changes
-------

  No changes found


Build changes
-------------

  * IGT: IGT_8911 -> IGTPW_15183

  IGTPW_15183: 8c06dc420933d6e73f9bd4f7cad0f4281e94ad0c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  IGT_8911: c7f4a459bf125a487220a0b56f5f17cc0721c541 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-5062-dee34cfbffbfe2196a9332f966b006cd2e54e976: dee34cfbffbfe2196a9332f966b006cd2e54e976

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/index.html

[-- Attachment #2: Type: text/html, Size: 1503 bytes --]

✗ Xe.CI.FULL: failure for lib/intel_wa: Assert on error instead of returning -1

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 30712 bytes --]

== Series Details ==

Series: lib/intel_wa: Assert on error instead of returning -1
URL   : https://patchwork.freedesktop.org/series/166558/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_8911_FULL -> XEIGTPW_15183_FULL
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with XEIGTPW_15183_FULL absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in XEIGTPW_15183_FULL, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (2 -> 2)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in XEIGTPW_15183_FULL:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_plane_scaling@plane-scaler-unity-scaling-with-modifiers@pipe-a:
    - shard-bmg:          [PASS][1] -> [ABORT][2] +1 other test abort
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-4/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-modifiers@pipe-a.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-2/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-modifiers@pipe-a.html
    - shard-lnl:          [PASS][3] -> [ABORT][4] +1 other test abort
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-lnl-8/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-modifiers@pipe-a.html
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-7/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-modifiers@pipe-a.html

  
Known issues
------------

  Here are the changes found in XEIGTPW_15183_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
    - shard-lnl:          NOTRUN -> [SKIP][5] ([Intel XE#3658] / [Intel XE#7360])
   [5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-270:
    - shard-bmg:          NOTRUN -> [SKIP][6] ([Intel XE#2327]) +1 other test skip
   [6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-9/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
    - shard-lnl:          NOTRUN -> [SKIP][7] ([Intel XE#1124]) +1 other test skip
   [7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html

  * igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
    - shard-bmg:          NOTRUN -> [SKIP][8] ([Intel XE#1124]) +2 other tests skip
   [8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-9/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html

  * igt@kms_big_fb@yf-tiled-addfb-size-overflow:
    - shard-lnl:          NOTRUN -> [SKIP][9] ([Intel XE#1428] / [Intel XE#7387])
   [9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@kms_big_fb@yf-tiled-addfb-size-overflow.html

  * igt@kms_bw@connected-linear-tiling-2-displays-target-1920x1080p:
    - shard-lnl:          NOTRUN -> [SKIP][10] ([Intel XE#7679])
   [10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-7/igt@kms_bw@connected-linear-tiling-2-displays-target-1920x1080p.html

  * igt@kms_bw@linear-tiling-2-displays-target-2560x1440p:
    - shard-lnl:          NOTRUN -> [SKIP][11] ([Intel XE#367])
   [11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-5/igt@kms_bw@linear-tiling-2-displays-target-2560x1440p.html

  * igt@kms_ccs@ccs-on-another-bo-4-tiled-mtl-rc-ccs-cc:
    - shard-lnl:          NOTRUN -> [SKIP][12] ([Intel XE#2887]) +3 other tests skip
   [12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@kms_ccs@ccs-on-another-bo-4-tiled-mtl-rc-ccs-cc.html

  * igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs:
    - shard-bmg:          [PASS][13] -> [INCOMPLETE][14] ([Intel XE#7084]) +1 other test incomplete
   [13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-8/igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs.html
   [14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-1/igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs.html

  * igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs:
    - shard-bmg:          NOTRUN -> [SKIP][15] ([Intel XE#2887]) +2 other tests skip
   [15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-5/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs.html

  * igt@kms_chamelium_edid@dp-edid-stress-resolution-4k:
    - shard-bmg:          NOTRUN -> [SKIP][16] ([Intel XE#2252])
   [16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-9/igt@kms_chamelium_edid@dp-edid-stress-resolution-4k.html

  * igt@kms_chamelium_hpd@hdmi-hpd-storm:
    - shard-lnl:          NOTRUN -> [SKIP][17] ([Intel XE#373])
   [17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@kms_chamelium_hpd@hdmi-hpd-storm.html

  * igt@kms_cursor_crc@cursor-random-128x42:
    - shard-bmg:          NOTRUN -> [SKIP][18] ([Intel XE#2320])
   [18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-9/igt@kms_cursor_crc@cursor-random-128x42.html

  * igt@kms_cursor_crc@cursor-random-32x32:
    - shard-lnl:          NOTRUN -> [SKIP][19] ([Intel XE#1424])
   [19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@kms_cursor_crc@cursor-random-32x32.html

  * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
    - shard-bmg:          [PASS][20] -> [FAIL][21] ([Intel XE#7571])
   [20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-3/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
   [21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-9/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html

  * igt@kms_dsc@dsc-basic:
    - shard-bmg:          NOTRUN -> [SKIP][22] ([Intel XE#2244])
   [22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-5/igt@kms_dsc@dsc-basic.html

  * igt@kms_fbc_dirty_rect@fbc-dirty-rectangle-different-formats:
    - shard-lnl:          NOTRUN -> [SKIP][23] ([Intel XE#4422] / [Intel XE#7442])
   [23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-7/igt@kms_fbc_dirty_rect@fbc-dirty-rectangle-different-formats.html

  * igt@kms_flip@2x-flip-vs-dpms-on-nop:
    - shard-lnl:          NOTRUN -> [SKIP][24] ([Intel XE#1421])
   [24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@kms_flip@2x-flip-vs-dpms-on-nop.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
    - shard-lnl:          [PASS][25] -> [FAIL][26] ([Intel XE#301]) +1 other test fail
   [25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-lnl-3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
   [26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
    - shard-bmg:          NOTRUN -> [SKIP][27] ([Intel XE#7178] / [Intel XE#7351])
   [27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html

  * igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling:
    - shard-lnl:          NOTRUN -> [SKIP][28] ([Intel XE#7178] / [Intel XE#7351])
   [28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-7/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling.html

  * igt@kms_frontbuffer_tracking@drrshdr-suspend:
    - shard-bmg:          NOTRUN -> [SKIP][29] ([Intel XE#2311]) +11 other tests skip
   [29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-5/igt@kms_frontbuffer_tracking@drrshdr-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
    - shard-lnl:          NOTRUN -> [SKIP][30] ([Intel XE#656] / [Intel XE#7905]) +9 other tests skip
   [30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - shard-bmg:          NOTRUN -> [SKIP][31] ([Intel XE#4141]) +2 other tests skip
   [31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-2/igt@kms_frontbuffer_tracking@fbc-stridechange.html

  * igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-pri-shrfb-draw-blt:
    - shard-lnl:          NOTRUN -> [SKIP][32] ([Intel XE#6312] / [Intel XE#651]) +1 other test skip
   [32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-pri-shrfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcdrrshdr-1p-primscrn-indfb-plflip-blt:
    - shard-lnl:          NOTRUN -> [SKIP][33] ([Intel XE#6312]) +2 other tests skip
   [33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@kms_frontbuffer_tracking@fbcdrrshdr-1p-primscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcdrrshdr-abgr161616f-draw-blt:
    - shard-lnl:          NOTRUN -> [SKIP][34] ([Intel XE#7061])
   [34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@kms_frontbuffer_tracking@fbcdrrshdr-abgr161616f-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-argb161616f-draw-render:
    - shard-lnl:          NOTRUN -> [SKIP][35] ([Intel XE#7061] / [Intel XE#7356])
   [35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-4/igt@kms_frontbuffer_tracking@fbcpsr-argb161616f-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsrhdr-2p-primscrn-pri-indfb-draw-mmap-wc:
    - shard-bmg:          NOTRUN -> [SKIP][36] ([Intel XE#2313]) +12 other tests skip
   [36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-9/igt@kms_frontbuffer_tracking@fbcpsrhdr-2p-primscrn-pri-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@hdr-2p-scndscrn-indfb-msflip-blt:
    - shard-lnl:          NOTRUN -> [SKIP][37] ([Intel XE#7905]) +9 other tests skip
   [37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@kms_frontbuffer_tracking@hdr-2p-scndscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@psrhdr-1p-primscrn-pri-indfb-draw-render:
    - shard-lnl:          NOTRUN -> [SKIP][38] ([Intel XE#7865]) +3 other tests skip
   [38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-4/igt@kms_frontbuffer_tracking@psrhdr-1p-primscrn-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psrhdr-argb161616f-draw-mmap-wc:
    - shard-bmg:          NOTRUN -> [SKIP][39] ([Intel XE#7061])
   [39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-3/igt@kms_frontbuffer_tracking@psrhdr-argb161616f-draw-mmap-wc.html

  * igt@kms_hdr@invalid-hdr:
    - shard-bmg:          [PASS][40] -> [SKIP][41] ([Intel XE#1503])
   [40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-8/igt@kms_hdr@invalid-hdr.html
   [41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-5/igt@kms_hdr@invalid-hdr.html

  * igt@kms_hdr@invalid-hdr@pipe-a-hdmi-a-3-xrgb2101010:
    - shard-bmg:          [PASS][42] -> [SKIP][43] ([Intel XE#7922]) +1 other test skip
   [42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-8/igt@kms_hdr@invalid-hdr@pipe-a-hdmi-a-3-xrgb2101010.html
   [43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-5/igt@kms_hdr@invalid-hdr@pipe-a-hdmi-a-3-xrgb2101010.html

  * igt@kms_hdr@static-toggle@pipe-a-hdmi-a-3-xrgb16161616f:
    - shard-bmg:          [PASS][44] -> [SKIP][45] ([Intel XE#7915]) +3 other tests skip
   [44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-2/igt@kms_hdr@static-toggle@pipe-a-hdmi-a-3-xrgb16161616f.html
   [45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-7/igt@kms_hdr@static-toggle@pipe-a-hdmi-a-3-xrgb16161616f.html

  * igt@kms_joiner@basic-force-ultra-joiner:
    - shard-bmg:          NOTRUN -> [SKIP][46] ([Intel XE#6911] / [Intel XE#7466])
   [46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-6/igt@kms_joiner@basic-force-ultra-joiner.html

  * igt@kms_joiner@basic-max-non-joiner:
    - shard-lnl:          NOTRUN -> [SKIP][47] ([Intel XE#4298] / [Intel XE#5873])
   [47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@kms_joiner@basic-max-non-joiner.html

  * igt@kms_plane_multiple@tiling-y:
    - shard-bmg:          NOTRUN -> [SKIP][48] ([Intel XE#5020] / [Intel XE#7348])
   [48]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-8/igt@kms_plane_multiple@tiling-y.html

  * igt@kms_pm_dc@dc6-psr:
    - shard-bmg:          NOTRUN -> [SKIP][49] ([Intel XE#7794])
   [49]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-8/igt@kms_pm_dc@dc6-psr.html

  * igt@kms_psr2_sf@fbc-pr-overlay-plane-move-continuous-exceed-fully-sf:
    - shard-lnl:          NOTRUN -> [SKIP][50] ([Intel XE#2893] / [Intel XE#7304])
   [50]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@kms_psr2_sf@fbc-pr-overlay-plane-move-continuous-exceed-fully-sf.html

  * igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf:
    - shard-bmg:          NOTRUN -> [SKIP][51] ([Intel XE#1489]) +2 other tests skip
   [51]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-8/igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf.html

  * igt@kms_psr@fbc-pr-cursor-plane-move:
    - shard-lnl:          NOTRUN -> [SKIP][52] ([Intel XE#1406]) +2 other tests skip
   [52]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@kms_psr@fbc-pr-cursor-plane-move.html

  * igt@kms_psr@fbc-pr-sprite-plane-onoff:
    - shard-bmg:          NOTRUN -> [SKIP][53] ([Intel XE#2234] / [Intel XE#2850]) +1 other test skip
   [53]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-7/igt@kms_psr@fbc-pr-sprite-plane-onoff.html

  * igt@kms_rotation_crc@sprite-rotation-90:
    - shard-lnl:          NOTRUN -> [SKIP][54] ([Intel XE#3414] / [Intel XE#3904] / [Intel XE#7342])
   [54]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-4/igt@kms_rotation_crc@sprite-rotation-90.html

  * igt@kms_sharpness_filter@invalid-filter-with-scaling-mode:
    - shard-bmg:          NOTRUN -> [SKIP][55] ([Intel XE#6503]) +1 other test skip
   [55]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-10/igt@kms_sharpness_filter@invalid-filter-with-scaling-mode.html

  * igt@kms_vrr@flipline:
    - shard-lnl:          [PASS][56] -> [FAIL][57] ([Intel XE#4227] / [Intel XE#7397]) +1 other test fail
   [56]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-lnl-5/igt@kms_vrr@flipline.html
   [57]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-7/igt@kms_vrr@flipline.html

  * igt@kms_vrr@seamless-rr-switch-virtual@pipe-a-edp-1:
    - shard-lnl:          [PASS][58] -> [FAIL][59] ([Intel XE#2142]) +1 other test fail
   [58]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-lnl-3/igt@kms_vrr@seamless-rr-switch-virtual@pipe-a-edp-1.html
   [59]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@kms_vrr@seamless-rr-switch-virtual@pipe-a-edp-1.html

  * igt@xe_eudebug_online@breakpoint-many-sessions-tiles:
    - shard-bmg:          NOTRUN -> [SKIP][60] ([Intel XE#7636]) +1 other test skip
   [60]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-4/igt@xe_eudebug_online@breakpoint-many-sessions-tiles.html

  * igt@xe_eudebug_online@pagefault-write:
    - shard-lnl:          NOTRUN -> [SKIP][61] ([Intel XE#7636])
   [61]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@xe_eudebug_online@pagefault-write.html

  * igt@xe_evict@evict-beng-mixed-many-threads-small:
    - shard-bmg:          [PASS][62] -> [INCOMPLETE][63] ([Intel XE#6321])
   [62]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-10/igt@xe_evict@evict-beng-mixed-many-threads-small.html
   [63]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-1/igt@xe_evict@evict-beng-mixed-many-threads-small.html

  * igt@xe_evict@evict-cm-threads-small-multi-queue:
    - shard-bmg:          NOTRUN -> [SKIP][64] ([Intel XE#7140])
   [64]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-1/igt@xe_evict@evict-cm-threads-small-multi-queue.html

  * igt@xe_evict@evict-threads-small-multi-vm:
    - shard-lnl:          NOTRUN -> [SKIP][65] ([Intel XE#6540] / [Intel XE#688]) +1 other test skip
   [65]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@xe_evict@evict-threads-small-multi-vm.html

  * igt@xe_exec_balancer@many-execqueues-cm-parallel-userptr-rebind:
    - shard-lnl:          NOTRUN -> [SKIP][66] ([Intel XE#7482]) +3 other tests skip
   [66]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@xe_exec_balancer@many-execqueues-cm-parallel-userptr-rebind.html

  * igt@xe_exec_basic@multigpu-no-exec-basic:
    - shard-bmg:          NOTRUN -> [SKIP][67] ([Intel XE#2322] / [Intel XE#7372]) +1 other test skip
   [67]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-10/igt@xe_exec_basic@multigpu-no-exec-basic.html

  * igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-invalidate-race:
    - shard-lnl:          NOTRUN -> [SKIP][68] ([Intel XE#1392]) +1 other test skip
   [68]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-8/igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-invalidate-race.html

  * igt@xe_exec_fault_mode@many-execqueues-multi-queue-userptr-invalidate-race-prefetch:
    - shard-bmg:          NOTRUN -> [SKIP][69] ([Intel XE#7136]) +2 other tests skip
   [69]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-5/igt@xe_exec_fault_mode@many-execqueues-multi-queue-userptr-invalidate-race-prefetch.html

  * igt@xe_exec_fault_mode@once-multi-queue-userptr-rebind:
    - shard-lnl:          NOTRUN -> [SKIP][70] ([Intel XE#7136]) +2 other tests skip
   [70]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@xe_exec_fault_mode@once-multi-queue-userptr-rebind.html

  * igt@xe_exec_multi_queue@many-queues-preempt-mode-dyn-priority-smem:
    - shard-bmg:          NOTRUN -> [SKIP][71] ([Intel XE#6874]) +3 other tests skip
   [71]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-2/igt@xe_exec_multi_queue@many-queues-preempt-mode-dyn-priority-smem.html

  * igt@xe_exec_multi_queue@one-queue-preempt-mode-fault-dyn-priority-smem:
    - shard-lnl:          NOTRUN -> [SKIP][72] ([Intel XE#6874]) +3 other tests skip
   [72]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-5/igt@xe_exec_multi_queue@one-queue-preempt-mode-fault-dyn-priority-smem.html

  * igt@xe_exec_threads@threads-multi-queue-mixed-userptr-invalidate-race:
    - shard-bmg:          NOTRUN -> [SKIP][73] ([Intel XE#7138])
   [73]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-8/igt@xe_exec_threads@threads-multi-queue-mixed-userptr-invalidate-race.html

  * igt@xe_mmap@pci-membarrier-bad-object:
    - shard-lnl:          NOTRUN -> [SKIP][74] ([Intel XE#5100] / [Intel XE#7322] / [Intel XE#7408])
   [74]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-5/igt@xe_mmap@pci-membarrier-bad-object.html

  * igt@xe_pat@xa-app-transient-media-off:
    - shard-lnl:          NOTRUN -> [SKIP][75] ([Intel XE#7590] / [Intel XE#7772])
   [75]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@xe_pat@xa-app-transient-media-off.html

  * igt@xe_pxp@pxp-stale-queue-post-suspend:
    - shard-bmg:          NOTRUN -> [SKIP][76] ([Intel XE#4733] / [Intel XE#7417])
   [76]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-3/igt@xe_pxp@pxp-stale-queue-post-suspend.html

  * igt@xe_query@multigpu-query-topology:
    - shard-bmg:          NOTRUN -> [SKIP][77] ([Intel XE#944])
   [77]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-4/igt@xe_query@multigpu-query-topology.html

  * igt@xe_sriov_admin@preempt-timeout-write-readback-vfs-disabled:
    - shard-lnl:          NOTRUN -> [SKIP][78] ([Intel XE#7174])
   [78]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-1/igt@xe_sriov_admin@preempt-timeout-write-readback-vfs-disabled.html

  * igt@xe_sriov_flr@flr-vfs-parallel:
    - shard-bmg:          [PASS][79] -> [FAIL][80] ([Intel XE#6569]) +1 other test fail
   [79]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-8/igt@xe_sriov_flr@flr-vfs-parallel.html
   [80]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-7/igt@xe_sriov_flr@flr-vfs-parallel.html

  
#### Possible fixes ####

  * igt@kms_atomic_transition@plane-all-transition:
    - shard-bmg:          [INCOMPLETE][81] ([Intel XE#7961]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-2/igt@kms_atomic_transition@plane-all-transition.html
   [82]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-2/igt@kms_atomic_transition@plane-all-transition.html

  * igt@kms_atomic_transition@plane-all-transition@pipe-b-hdmi-a-3:
    - shard-bmg:          [INCOMPLETE][83] ([Intel XE#6819] / [Intel XE#7961]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-2/igt@kms_atomic_transition@plane-all-transition@pipe-b-hdmi-a-3.html
   [84]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-2/igt@kms_atomic_transition@plane-all-transition@pipe-b-hdmi-a-3.html

  * igt@kms_flip@flip-vs-expired-vblank@a-edp1:
    - shard-lnl:          [FAIL][85] ([Intel XE#301]) -> [PASS][86] +1 other test pass
   [85]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-lnl-1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
   [86]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-lnl-2/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html

  * igt@kms_hdr@static-toggle-suspend@pipe-a-hdmi-a-3-xrgb16161616f:
    - shard-bmg:          [SKIP][87] ([Intel XE#7915]) -> [PASS][88] +1 other test pass
   [87]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-7/igt@kms_hdr@static-toggle-suspend@pipe-a-hdmi-a-3-xrgb16161616f.html
   [88]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-9/igt@kms_hdr@static-toggle-suspend@pipe-a-hdmi-a-3-xrgb16161616f.html

  * igt@xe_evict@evict-mixed-many-threads-small:
    - shard-bmg:          [INCOMPLETE][89] ([Intel XE#6321]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-4/igt@xe_evict@evict-mixed-many-threads-small.html
   [90]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-10/igt@xe_evict@evict-mixed-many-threads-small.html

  
#### Warnings ####

  * igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs:
    - shard-bmg:          [ABORT][91] -> [SKIP][92] ([Intel XE#2652]) +1 other test skip
   [91]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-1/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs.html
   [92]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-2/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs.html

  * igt@kms_tiled_display@basic-test-pattern-with-chamelium:
    - shard-bmg:          [SKIP][93] ([Intel XE#2426] / [Intel XE#5848]) -> [SKIP][94] ([Intel XE#2509] / [Intel XE#7437])
   [93]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8911/shard-bmg-9/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
   [94]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/shard-bmg-6/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html

  
  [Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
  [Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
  [Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
  [Intel XE#1421]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1421
  [Intel XE#1424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1424
  [Intel XE#1428]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1428
  [Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
  [Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
  [Intel XE#2142]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2142
  [Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
  [Intel XE#2244]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2244
  [Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
  [Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
  [Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
  [Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
  [Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
  [Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
  [Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
  [Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509
  [Intel XE#2652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2652
  [Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
  [Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
  [Intel XE#2893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2893
  [Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
  [Intel XE#3414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3414
  [Intel XE#3658]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3658
  [Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
  [Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
  [Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
  [Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
  [Intel XE#4227]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4227
  [Intel XE#4298]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4298
  [Intel XE#4422]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4422
  [Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
  [Intel XE#5020]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5020
  [Intel XE#5100]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5100
  [Intel XE#5848]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5848
  [Intel XE#5873]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5873
  [Intel XE#6312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6312
  [Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
  [Intel XE#6503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6503
  [Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
  [Intel XE#6540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6540
  [Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
  [Intel XE#6569]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6569
  [Intel XE#6819]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6819
  [Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
  [Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
  [Intel XE#6911]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6911
  [Intel XE#7061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7061
  [Intel XE#7084]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7084
  [Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
  [Intel XE#7138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7138
  [Intel XE#7140]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7140
  [Intel XE#7174]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7174
  [Intel XE#7178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7178
  [Intel XE#7304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7304
  [Intel XE#7322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7322
  [Intel XE#7342]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7342
  [Intel XE#7348]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7348
  [Intel XE#7351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7351
  [Intel XE#7356]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7356
  [Intel XE#7360]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7360
  [Intel XE#7372]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7372
  [Intel XE#7387]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7387
  [Intel XE#7397]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7397
  [Intel XE#7408]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7408
  [Intel XE#7417]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7417
  [Intel XE#7437]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7437
  [Intel XE#7442]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7442
  [Intel XE#7466]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7466
  [Intel XE#7482]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7482
  [Intel XE#7571]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7571
  [Intel XE#7590]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7590
  [Intel XE#7636]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7636
  [Intel XE#7679]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7679
  [Intel XE#7772]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7772
  [Intel XE#7794]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7794
  [Intel XE#7865]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7865
  [Intel XE#7905]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7905
  [Intel XE#7915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7915
  [Intel XE#7922]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7922
  [Intel XE#7961]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7961
  [Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944


Build changes
-------------

  * IGT: IGT_8911 -> IGTPW_15183

  IGTPW_15183: 8c06dc420933d6e73f9bd4f7cad0f4281e94ad0c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  IGT_8911: c7f4a459bf125a487220a0b56f5f17cc0721c541 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-5062-dee34cfbffbfe2196a9332f966b006cd2e54e976: dee34cfbffbfe2196a9332f966b006cd2e54e976

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15183/index.html

[-- Attachment #2: Type: text/html, Size: 33882 bytes --]

Re: [PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[Kamil Konieczny]

Hi Shekhar,
On 2026-05-14 at 12:06:55 +0530, Shekhar Chauhan wrote:
> igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> distinguishing the error and no-workaround cases for callers. Replace
> the error return with igt_assert() and simplify debugfs_file_has_wa() by
> dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> NULL for missing files anyway.
> 
> v2: Make the func as bool instead of int.
> 
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> ---
>  lib/intel_wa.c | 19 +++++++++----------
>  lib/intel_wa.h |  2 +-
>  2 files changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> index 727dd6c98..e4fe7b0ee 100644
> --- a/lib/intel_wa.c
> +++ b/lib/intel_wa.c
> @@ -7,18 +7,18 @@
>  #include <stdint.h>
>  #include <stdio.h>
>  
> +#include "igt_core.h"
>  #include "igt_debugfs.h"
>  #include "igt_sysfs.h"
>  #include "intel_wa.h"
>  #include "xe/xe_query.h"
>  
> -static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> +static bool debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>  			       const char *debugfs_name, const char *wa)
>  {
>  	char *debugfs_dump;
>  
> -	if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> -		return -1;
> +	igt_assert(igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY));
>  
>  	debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
>  	if (debugfs_dump) {
> @@ -27,10 +27,10 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>  		free(debugfs_dump);
>  
>  		if (has_wa)
> -			return 1;
> +			return true;
>  	}
>  
> -	return 0;
> +	return false;
>  }
>  
>  /**
> @@ -38,18 +38,17 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>   * @drm_fd:	A drm file descriptor
>   * @check_wa:	Workaround to be checked
>   *
> - * Returns:	0 if no WA, 1 if WA present, -1 on error
> + * Returns:	true if WA present, false otherwise
>   */
> -int igt_has_intel_wa(int drm_fd, const char *check_wa)
> +bool igt_has_intel_wa(int drm_fd, const char *check_wa)
>  {
> -	int ret = 0;
> +	bool ret = 0;
>  	int debugfs_fd;
>  	unsigned int xe;
>  	char name[256];
>  
>  	debugfs_fd = igt_debugfs_dir(drm_fd);
> -	if (debugfs_fd == -1)
> -		return -1;
> +	igt_assert(debugfs_fd >= 0);

This will mean that all other users needs to be updated.
The way of adding any igt_assert/igt_require into lib/
make it impossible to reuse them in tools/ and require
to write same functionality twice, one in lib/ and one
for any tools which will want to use them. Or to write
__function() without igt_assert/igt_require.

Regards,
Kamil

>  
>  	xe_for_each_gt(drm_fd, xe) {
>  		sprintf(name, "gt%d/workarounds", xe);
> diff --git a/lib/intel_wa.h b/lib/intel_wa.h
> index 765a5948e..34cafecc4 100644
> --- a/lib/intel_wa.h
> +++ b/lib/intel_wa.h
> @@ -6,6 +6,6 @@
>  #ifndef __INTEL_WA_H__
>  #define __INTEL_WA_H__
>  
> -int igt_has_intel_wa(int drm_fd, const char *check_wa);
> +bool igt_has_intel_wa(int drm_fd, const char *check_wa);
>  
>  #endif /* __INTEL_WA_H__ */
> -- 
> 2.53.0
> 

Re: [PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[Dixit, Ashutosh]

On Fri, 15 May 2026 05:24:08 -0700, Kamil Konieczny wrote:
>

Hi Kamil,

> Hi Shekhar,
> On 2026-05-14 at 12:06:55 +0530, Shekhar Chauhan wrote:
> > igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> > distinguishing the error and no-workaround cases for callers. Replace
> > the error return with igt_assert() and simplify debugfs_file_has_wa() by
> > dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> > NULL for missing files anyway.
> >
> > v2: Make the func as bool instead of int.
> >
> > Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> > ---
> >  lib/intel_wa.c | 19 +++++++++----------
> >  lib/intel_wa.h |  2 +-
> >  2 files changed, 10 insertions(+), 11 deletions(-)
> >
> > diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> > index 727dd6c98..e4fe7b0ee 100644
> > --- a/lib/intel_wa.c
> > +++ b/lib/intel_wa.c
> > @@ -7,18 +7,18 @@
> >  #include <stdint.h>
> >  #include <stdio.h>
> >
> > +#include "igt_core.h"
> >  #include "igt_debugfs.h"
> >  #include "igt_sysfs.h"
> >  #include "intel_wa.h"
> >  #include "xe/xe_query.h"
> >
> > -static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > +static bool debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> >			       const char *debugfs_name, const char *wa)
> >  {
> >	char *debugfs_dump;
> >
> > -	if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> > -		return -1;
> > +	igt_assert(igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY));
> >
> >	debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
> >	if (debugfs_dump) {
> > @@ -27,10 +27,10 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> >		free(debugfs_dump);
> >
> >		if (has_wa)
> > -			return 1;
> > +			return true;
> >	}
> >
> > -	return 0;
> > +	return false;
> >  }
> >
> >  /**
> > @@ -38,18 +38,17 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> >   * @drm_fd:	A drm file descriptor
> >   * @check_wa:	Workaround to be checked
> >   *
> > - * Returns:	0 if no WA, 1 if WA present, -1 on error
> > + * Returns:	true if WA present, false otherwise
> >   */
> > -int igt_has_intel_wa(int drm_fd, const char *check_wa)
> > +bool igt_has_intel_wa(int drm_fd, const char *check_wa)
> >  {
> > -	int ret = 0;
> > +	bool ret = 0;
> >	int debugfs_fd;
> >	unsigned int xe;
> >	char name[256];
> >
> >	debugfs_fd = igt_debugfs_dir(drm_fd);
> > -	if (debugfs_fd == -1)
> > -		return -1;
> > +	igt_assert(debugfs_fd >= 0);
>
> This will mean that all other users needs to be updated.

To date there are no other users of this function, except one in OA.

> The way of adding any igt_assert/igt_require into lib/
> make it impossible to reuse them in tools/ and require
> to write same functionality twice, one in lib/ and one
> for any tools which will want to use them. Or to write
> __function() without igt_assert/igt_require.

Well it was I who suggested doing this. Can you explain your point a bit?
Any tools which use a lib function which uses e.g. igt_assert/igt_require
can also link with lib_igt (which provides igt_assert/igt_require). See
e.g. tools/xe-perf/meson.build. It is not unreasonable for IGT tools to
link with lib_igt. I thought not linking with igt_lib was an unreasonabe
requirement and I removed it for tools/xe-perf.

If you are saying tools should be able to run without debugfs mounted,
maybe you have a point. In that case we can drop this patch. But even here
maybe IGT tools should run only with debugfs mounted?

Thanks.
--
Ashutosh


> >	xe_for_each_gt(drm_fd, xe) {
> >		sprintf(name, "gt%d/workarounds", xe);
> > diff --git a/lib/intel_wa.h b/lib/intel_wa.h
> > index 765a5948e..34cafecc4 100644
> > --- a/lib/intel_wa.h
> > +++ b/lib/intel_wa.h
> > @@ -6,6 +6,6 @@
> >  #ifndef __INTEL_WA_H__
> >  #define __INTEL_WA_H__
> >
> > -int igt_has_intel_wa(int drm_fd, const char *check_wa);
> > +bool igt_has_intel_wa(int drm_fd, const char *check_wa);
> >
> >  #endif /* __INTEL_WA_H__ */
> > --
> > 2.53.0
> >

Re: [PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[Dixit, Ashutosh]

On Sat, 16 May 2026 12:11:13 -0700, Dixit, Ashutosh wrote:
>
> On Fri, 15 May 2026 05:24:08 -0700, Kamil Konieczny wrote:
> >
>
> Hi Kamil,
>
> > Hi Shekhar,
> > On 2026-05-14 at 12:06:55 +0530, Shekhar Chauhan wrote:
> > > igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> > > distinguishing the error and no-workaround cases for callers. Replace
> > > the error return with igt_assert() and simplify debugfs_file_has_wa() by
> > > dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> > > NULL for missing files anyway.
> > >
> > > v2: Make the func as bool instead of int.
> > >
> > > Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> > > ---
> > >  lib/intel_wa.c | 19 +++++++++----------
> > >  lib/intel_wa.h |  2 +-
> > >  2 files changed, 10 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> > > index 727dd6c98..e4fe7b0ee 100644
> > > --- a/lib/intel_wa.c
> > > +++ b/lib/intel_wa.c
> > > @@ -7,18 +7,18 @@
> > >  #include <stdint.h>
> > >  #include <stdio.h>
> > >
> > > +#include "igt_core.h"
> > >  #include "igt_debugfs.h"
> > >  #include "igt_sysfs.h"
> > >  #include "intel_wa.h"
> > >  #include "xe/xe_query.h"
> > >
> > > -static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > +static bool debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > >			       const char *debugfs_name, const char *wa)
> > >  {
> > >	char *debugfs_dump;
> > >
> > > -	if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> > > -		return -1;
> > > +	igt_assert(igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY));
> > >
> > >	debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
> > >	if (debugfs_dump) {
> > > @@ -27,10 +27,10 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > >		free(debugfs_dump);
> > >
> > >		if (has_wa)
> > > -			return 1;
> > > +			return true;
> > >	}
> > >
> > > -	return 0;
> > > +	return false;
> > >  }
> > >
> > >  /**
> > > @@ -38,18 +38,17 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > >   * @drm_fd:	A drm file descriptor
> > >   * @check_wa:	Workaround to be checked
> > >   *
> > > - * Returns:	0 if no WA, 1 if WA present, -1 on error
> > > + * Returns:	true if WA present, false otherwise
> > >   */
> > > -int igt_has_intel_wa(int drm_fd, const char *check_wa)
> > > +bool igt_has_intel_wa(int drm_fd, const char *check_wa)
> > >  {
> > > -	int ret = 0;
> > > +	bool ret = 0;
> > >	int debugfs_fd;
> > >	unsigned int xe;
> > >	char name[256];
> > >
> > >	debugfs_fd = igt_debugfs_dir(drm_fd);
> > > -	if (debugfs_fd == -1)
> > > -		return -1;
> > > +	igt_assert(debugfs_fd >= 0);
> >
> > This will mean that all other users needs to be updated.
>
> To date there are no other users of this function, except one in OA.
>
> > The way of adding any igt_assert/igt_require into lib/
> > make it impossible to reuse them in tools/ and require
> > to write same functionality twice, one in lib/ and one
> > for any tools which will want to use them. Or to write
> > __function() without igt_assert/igt_require.
>
> Well it was I who suggested doing this. Can you explain your point a bit?
> Any tools which use a lib function which uses e.g. igt_assert/igt_require
> can also link with lib_igt (which provides igt_assert/igt_require). See
> e.g. tools/xe-perf/meson.build. It is not unreasonable for IGT tools to
> link with lib_igt. I thought not linking with igt_lib was an unreasonabe
> requirement and I removed it for tools/xe-perf.
>
> If you are saying tools should be able to run without debugfs mounted,
> maybe you have a point. In that case we can drop this patch. But even here
> maybe IGT tools should run only with debugfs mounted?

Also the tool should realize it is calling a function which requires
debugfs, and separately check whether or not debugfs is mounted and skip
calling the function if it isn't. So I am not sure why we should do
anything different, since wa list is exposed through debugfs.

>
>
> > >	xe_for_each_gt(drm_fd, xe) {
> > >		sprintf(name, "gt%d/workarounds", xe);
> > > diff --git a/lib/intel_wa.h b/lib/intel_wa.h
> > > index 765a5948e..34cafecc4 100644
> > > --- a/lib/intel_wa.h
> > > +++ b/lib/intel_wa.h
> > > @@ -6,6 +6,6 @@
> > >  #ifndef __INTEL_WA_H__
> > >  #define __INTEL_WA_H__
> > >
> > > -int igt_has_intel_wa(int drm_fd, const char *check_wa);
> > > +bool igt_has_intel_wa(int drm_fd, const char *check_wa);
> > >
> > >  #endif /* __INTEL_WA_H__ */
> > > --
> > > 2.53.0
> > >

Re: [PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[Kamil Konieczny]

Hi all,
On 2026-05-18 at 16:53:04 -0700, Dixit, Ashutosh wrote:
> On Sat, 16 May 2026 12:11:13 -0700, Dixit, Ashutosh wrote:
> >
> > On Fri, 15 May 2026 05:24:08 -0700, Kamil Konieczny wrote:
> > >
> >
> > Hi Kamil,
> >
> > > Hi Shekhar,
> > > On 2026-05-14 at 12:06:55 +0530, Shekhar Chauhan wrote:
> > > > igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> > > > distinguishing the error and no-workaround cases for callers. Replace
> > > > the error return with igt_assert() and simplify debugfs_file_has_wa() by
> > > > dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> > > > NULL for missing files anyway.
> > > >
> > > > v2: Make the func as bool instead of int.
> > > >
> > > > Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> > > > ---
> > > >  lib/intel_wa.c | 19 +++++++++----------
> > > >  lib/intel_wa.h |  2 +-
> > > >  2 files changed, 10 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> > > > index 727dd6c98..e4fe7b0ee 100644
> > > > --- a/lib/intel_wa.c
> > > > +++ b/lib/intel_wa.c
> > > > @@ -7,18 +7,18 @@
> > > >  #include <stdint.h>
> > > >  #include <stdio.h>
> > > >
> > > > +#include "igt_core.h"
> > > >  #include "igt_debugfs.h"
> > > >  #include "igt_sysfs.h"
> > > >  #include "intel_wa.h"
> > > >  #include "xe/xe_query.h"
> > > >
> > > > -static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > > +static bool debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > >			       const char *debugfs_name, const char *wa)
> > > >  {
> > > >	char *debugfs_dump;
> > > >
> > > > -	if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> > > > -		return -1;
> > > > +	igt_assert(igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY));
> > > >
> > > >	debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
> > > >	if (debugfs_dump) {
> > > > @@ -27,10 +27,10 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > >		free(debugfs_dump);
> > > >
> > > >		if (has_wa)
> > > > -			return 1;
> > > > +			return true;
> > > >	}
> > > >
> > > > -	return 0;
> > > > +	return false;
> > > >  }
> > > >
> > > >  /**
> > > > @@ -38,18 +38,17 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > >   * @drm_fd:	A drm file descriptor
> > > >   * @check_wa:	Workaround to be checked
> > > >   *
> > > > - * Returns:	0 if no WA, 1 if WA present, -1 on error
> > > > + * Returns:	true if WA present, false otherwise
> > > >   */
> > > > -int igt_has_intel_wa(int drm_fd, const char *check_wa)
> > > > +bool igt_has_intel_wa(int drm_fd, const char *check_wa)
> > > >  {
> > > > -	int ret = 0;
> > > > +	bool ret = 0;
> > > >	int debugfs_fd;
> > > >	unsigned int xe;
> > > >	char name[256];
> > > >
> > > >	debugfs_fd = igt_debugfs_dir(drm_fd);
> > > > -	if (debugfs_fd == -1)
> > > > -		return -1;
> > > > +	igt_assert(debugfs_fd >= 0);
> > >
> > > This will mean that all other users needs to be updated.
> >
> > To date there are no other users of this function, except one in OA.
> >
> > > The way of adding any igt_assert/igt_require into lib/
> > > make it impossible to reuse them in tools/ and require
> > > to write same functionality twice, one in lib/ and one
> > > for any tools which will want to use them. Or to write
> > > __function() without igt_assert/igt_require.
> >
> > Well it was I who suggested doing this. Can you explain your point a bit?
> > Any tools which use a lib function which uses e.g. igt_assert/igt_require
> > can also link with lib_igt (which provides igt_assert/igt_require). See
> > e.g. tools/xe-perf/meson.build. It is not unreasonable for IGT tools to
> > link with lib_igt. I thought not linking with igt_lib was an unreasonabe
> > requirement and I removed it for tools/xe-perf.

Main reason was a tools asserting in middle of operation, where
it should just report an error, lack of permission or some
other reason why it cannot proceed. Another example would be
implemetation of malloc() where lib will assert instead of
returning a NULL pointer.

> >
> > If you are saying tools should be able to run without debugfs mounted,
> > maybe you have a point. In that case we can drop this patch. But even here
> > maybe IGT tools should run only with debugfs mounted?

Definitly not, there are systems without debugfs for security
reasons, and there is sysfs so for example intel_gpu_freq should
work perfectly fine.

> 
> Also the tool should realize it is calling a function which requires
> debugfs, and separately check whether or not debugfs is mounted and skip
> calling the function if it isn't. So I am not sure why we should do
> anything different, since wa list is exposed through debugfs.
> 

Well, as it is only used in intel perf tests/tools, it is ok
so I will not block it, you can merge it.

Regards,
Kamil

> >
> >
> > > >	xe_for_each_gt(drm_fd, xe) {
> > > >		sprintf(name, "gt%d/workarounds", xe);
> > > > diff --git a/lib/intel_wa.h b/lib/intel_wa.h
> > > > index 765a5948e..34cafecc4 100644
> > > > --- a/lib/intel_wa.h
> > > > +++ b/lib/intel_wa.h
> > > > @@ -6,6 +6,6 @@
> > > >  #ifndef __INTEL_WA_H__
> > > >  #define __INTEL_WA_H__
> > > >
> > > > -int igt_has_intel_wa(int drm_fd, const char *check_wa);
> > > > +bool igt_has_intel_wa(int drm_fd, const char *check_wa);
> > > >
> > > >  #endif /* __INTEL_WA_H__ */
> > > > --
> > > > 2.53.0
> > > >

Re: [PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[Dixit, Ashutosh]

On Tue, 19 May 2026 02:52:26 -0700, Kamil Konieczny wrote:
>
> Hi all,
> On 2026-05-18 at 16:53:04 -0700, Dixit, Ashutosh wrote:
> > On Sat, 16 May 2026 12:11:13 -0700, Dixit, Ashutosh wrote:
> > >
> > > On Fri, 15 May 2026 05:24:08 -0700, Kamil Konieczny wrote:
> > > >
> > >
> > > Hi Kamil,
> > >
> > > > Hi Shekhar,
> > > > On 2026-05-14 at 12:06:55 +0530, Shekhar Chauhan wrote:
> > > > > igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> > > > > distinguishing the error and no-workaround cases for callers. Replace
> > > > > the error return with igt_assert() and simplify debugfs_file_has_wa() by
> > > > > dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> > > > > NULL for missing files anyway.
> > > > >
> > > > > v2: Make the func as bool instead of int.
> > > > >
> > > > > Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> > > > > ---
> > > > >  lib/intel_wa.c | 19 +++++++++----------
> > > > >  lib/intel_wa.h |  2 +-
> > > > >  2 files changed, 10 insertions(+), 11 deletions(-)
> > > > >
> > > > > diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> > > > > index 727dd6c98..e4fe7b0ee 100644
> > > > > --- a/lib/intel_wa.c
> > > > > +++ b/lib/intel_wa.c
> > > > > @@ -7,18 +7,18 @@
> > > > >  #include <stdint.h>
> > > > >  #include <stdio.h>
> > > > >
> > > > > +#include "igt_core.h"
> > > > >  #include "igt_debugfs.h"
> > > > >  #include "igt_sysfs.h"
> > > > >  #include "intel_wa.h"
> > > > >  #include "xe/xe_query.h"
> > > > >
> > > > > -static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > > > +static bool debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > > >			       const char *debugfs_name, const char *wa)
> > > > >  {
> > > > >	char *debugfs_dump;
> > > > >
> > > > > -	if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> > > > > -		return -1;
> > > > > +	igt_assert(igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY));
> > > > >
> > > > >	debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
> > > > >	if (debugfs_dump) {
> > > > > @@ -27,10 +27,10 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > > >		free(debugfs_dump);
> > > > >
> > > > >		if (has_wa)
> > > > > -			return 1;
> > > > > +			return true;
> > > > >	}
> > > > >
> > > > > -	return 0;
> > > > > +	return false;
> > > > >  }
> > > > >
> > > > >  /**
> > > > > @@ -38,18 +38,17 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > > > >   * @drm_fd:	A drm file descriptor
> > > > >   * @check_wa:	Workaround to be checked
> > > > >   *
> > > > > - * Returns:	0 if no WA, 1 if WA present, -1 on error
> > > > > + * Returns:	true if WA present, false otherwise
> > > > >   */
> > > > > -int igt_has_intel_wa(int drm_fd, const char *check_wa)
> > > > > +bool igt_has_intel_wa(int drm_fd, const char *check_wa)
> > > > >  {
> > > > > -	int ret = 0;
> > > > > +	bool ret = 0;
> > > > >	int debugfs_fd;
> > > > >	unsigned int xe;
> > > > >	char name[256];
> > > > >
> > > > >	debugfs_fd = igt_debugfs_dir(drm_fd);
> > > > > -	if (debugfs_fd == -1)
> > > > > -		return -1;
> > > > > +	igt_assert(debugfs_fd >= 0);
> > > >
> > > > This will mean that all other users needs to be updated.
> > >
> > > To date there are no other users of this function, except one in OA.
> > >
> > > > The way of adding any igt_assert/igt_require into lib/
> > > > make it impossible to reuse them in tools/ and require
> > > > to write same functionality twice, one in lib/ and one
> > > > for any tools which will want to use them. Or to write
> > > > __function() without igt_assert/igt_require.
> > >
> > > Well it was I who suggested doing this. Can you explain your point a bit?
> > > Any tools which use a lib function which uses e.g. igt_assert/igt_require
> > > can also link with lib_igt (which provides igt_assert/igt_require). See
> > > e.g. tools/xe-perf/meson.build. It is not unreasonable for IGT tools to
> > > link with lib_igt. I thought not linking with igt_lib was an unreasonabe
> > > requirement and I removed it for tools/xe-perf.
>
> Main reason was a tools asserting in middle of operation, where
> it should just report an error, lack of permission or some
> other reason why it cannot proceed. Another example would be
> implemetation of malloc() where lib will assert instead of
> returning a NULL pointer.
>
> > >
> > > If you are saying tools should be able to run without debugfs mounted,
> > > maybe you have a point. In that case we can drop this patch. But even here
> > > maybe IGT tools should run only with debugfs mounted?
>
> Definitly not, there are systems without debugfs for security
> reasons, and there is sysfs so for example intel_gpu_freq should
> work perfectly fine.
>
> >
> > Also the tool should realize it is calling a function which requires
> > debugfs, and separately check whether or not debugfs is mounted and skip
> > calling the function if it isn't. So I am not sure why we should do
> > anything different, since wa list is exposed through debugfs.
> >
>
> Well, as it is only used in intel perf tests/tools, it is ok
> so I will not block it, you can merge it.

Well intel_wa functions are meant to be used generally to check if any
workarounds in the kernel, so they are not just for intel perf
tests/tools. However, as I mentioned, because this workaround information
is exposed through debugfs, IMO it is ok to assert if debugfs is not
mounted.

Therefore I have gone ahead and merged this. We can of course revisit if
needed in the future, but for now this patch seems correct to me.

Thanks.
--
Ashutosh


>
> > >
> > >
> > > > >	xe_for_each_gt(drm_fd, xe) {
> > > > >		sprintf(name, "gt%d/workarounds", xe);
> > > > > diff --git a/lib/intel_wa.h b/lib/intel_wa.h
> > > > > index 765a5948e..34cafecc4 100644
> > > > > --- a/lib/intel_wa.h
> > > > > +++ b/lib/intel_wa.h
> > > > > @@ -6,6 +6,6 @@
> > > > >  #ifndef __INTEL_WA_H__
> > > > >  #define __INTEL_WA_H__
> > > > >
> > > > > -int igt_has_intel_wa(int drm_fd, const char *check_wa);
> > > > > +bool igt_has_intel_wa(int drm_fd, const char *check_wa);
> > > > >
> > > > >  #endif /* __INTEL_WA_H__ */
> > > > > --
> > > > > 2.53.0
> > > > >

Re: [PATCH v2] lib/intel_wa: Assert on error instead of returning -1

[Kamil Konieczny]

Hi Shekhar,
On 2026-05-14 at 12:06:55 +0530, Shekhar Chauhan wrote:
> igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> distinguishing the error and no-workaround cases for callers. Replace
> the error return with igt_assert() and simplify debugfs_file_has_wa() by
> dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> NULL for missing files anyway.
> 
> v2: Make the func as bool instead of int.
> 
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>

Before merge, please reply to CI error reports with cc to CI-bug
filing team. Also, please cut your replay after 'Known errors',
so its size will be small.

Regards,
Kamil

> ---
>  lib/intel_wa.c | 19 +++++++++----------
>  lib/intel_wa.h |  2 +-
>  2 files changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> index 727dd6c98..e4fe7b0ee 100644
> --- a/lib/intel_wa.c
> +++ b/lib/intel_wa.c
> @@ -7,18 +7,18 @@
>  #include <stdint.h>
>  #include <stdio.h>
>  
> +#include "igt_core.h"
>  #include "igt_debugfs.h"
>  #include "igt_sysfs.h"
>  #include "intel_wa.h"
>  #include "xe/xe_query.h"
>  
> -static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> +static bool debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>  			       const char *debugfs_name, const char *wa)
>  {
>  	char *debugfs_dump;
>  
> -	if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> -		return -1;
> +	igt_assert(igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY));
>  
>  	debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
>  	if (debugfs_dump) {
> @@ -27,10 +27,10 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>  		free(debugfs_dump);
>  
>  		if (has_wa)
> -			return 1;
> +			return true;
>  	}
>  
> -	return 0;
> +	return false;
>  }
>  
>  /**
> @@ -38,18 +38,17 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
>   * @drm_fd:	A drm file descriptor
>   * @check_wa:	Workaround to be checked
>   *
> - * Returns:	0 if no WA, 1 if WA present, -1 on error
> + * Returns:	true if WA present, false otherwise
>   */
> -int igt_has_intel_wa(int drm_fd, const char *check_wa)
> +bool igt_has_intel_wa(int drm_fd, const char *check_wa)
>  {
> -	int ret = 0;
> +	bool ret = 0;
>  	int debugfs_fd;
>  	unsigned int xe;
>  	char name[256];
>  
>  	debugfs_fd = igt_debugfs_dir(drm_fd);
> -	if (debugfs_fd == -1)
> -		return -1;
> +	igt_assert(debugfs_fd >= 0);
>  
>  	xe_for_each_gt(drm_fd, xe) {
>  		sprintf(name, "gt%d/workarounds", xe);
> diff --git a/lib/intel_wa.h b/lib/intel_wa.h
> index 765a5948e..34cafecc4 100644
> --- a/lib/intel_wa.h
> +++ b/lib/intel_wa.h
> @@ -6,6 +6,6 @@
>  #ifndef __INTEL_WA_H__
>  #define __INTEL_WA_H__
>  
> -int igt_has_intel_wa(int drm_fd, const char *check_wa);
> +bool igt_has_intel_wa(int drm_fd, const char *check_wa);
>  
>  #endif /* __INTEL_WA_H__ */
> -- 
> 2.53.0
>