From: Markus Armbruster <armbru@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] ui/console: remove console from global list on finalization
Date: Fri, 24 Apr 2026 08:50:42 +0200 [thread overview]
Message-ID: <87eck4x35p.fsf@pond.sub.org> (raw)
In-Reply-To: <20260422202646.272081-1-marcandre.lureau@redhat.com> (marcandre lureau's message of "Thu, 23 Apr 2026 00:26:46 +0400")
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> This commit removes the QemuConsole from the global "consoles" list when
> it is finalized.
>
> Previously, there was a TODO comment indicating this path needed
> checking. The assertions added ensure that `dcls`, `gl_block`, and the
> `dump_queue` are empty before removal, confirming the console is in a
> clean state.
>
> Fix potential use-after-free crashes when a display console is removed.
Suggest to mention reproducers: QMP command qom-list-properties with
typename "qemu-text-console", "qemu-fixed-text-console" or
"qemu-graphic-console".
> Reported-by: Markus Armbruster <armbru@redhat.com>
Please add
Cc: qemu-stable@nongnu.org
and Fixes: if it's not too much trouble.
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
next prev parent reply other threads:[~2026-04-24 6:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 20:26 [PATCH] ui/console: remove console from global list on finalization marcandre.lureau
2026-04-23 5:02 ` Markus Armbruster
2026-04-23 6:28 ` Marc-André Lureau
2026-04-23 6:59 ` Markus Armbruster
2026-04-23 8:02 ` Marc-André Lureau
2026-04-23 10:57 ` Markus Armbruster
2026-04-27 8:13 ` Marc-André Lureau
2026-04-24 6:50 ` Markus Armbruster [this message]
2026-04-27 8:17 ` Marc-André Lureau
2026-04-27 9:20 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eck4x35p.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.