All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: <tiwai@suse.de>, <broonie@kernel.org>,
	<andriy.shevchenko@linux.intel.com>,
	<linux-kernel@vger.kernel.org>, <baojun.xu@ti.com>,
	<Baojun.Xu@fpt.com>, <13564923607@139.com>, <13916275206@139.com>,
	<matthew.schwartz@linux.dev>, <lkml@antheas.dev>
Subject: Re: [PATCH v1] ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781
Date: Sat, 28 Feb 2026 09:28:29 +0100	[thread overview]
Message-ID: <87ecm56zma.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260227144641.1243-1-shenghao-ding@ti.com>

On Fri, 27 Feb 2026 15:46:40 +0100,
Shenghao Ding wrote:
> 
> On TAS2781, if the Speaker calibrated impedance is lower than default
> value hard-coded inside the TAS2781, it will cuase vol lower than
> normal. In order to fix this issue, the parameter of SineGainI need
> updating.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
> 
> ---
> v1:
>  - Add tas2781_cali_preproc() to check whether the calibrated-impedance is lower than the default value. If so, update the SineGainI.
>  - Specify the TAS2781 chipid for cliabrated data preprocessing.
>  - Revert b7e26c8bdae7 ("ALSA: hda/tas2781: Skip UEFI calibration on ASUS ROG Xbox Ally X") in tas2781.

Thanks, applied now.


Takashi

      parent reply	other threads:[~2026-02-28  8:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 14:46 [PATCH v1] ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781 Shenghao Ding
2026-02-27 21:00 ` Matthew Schwartz
2026-02-28  8:28 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecm56zma.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=13564923607@139.com \
    --cc=13916275206@139.com \
    --cc=Baojun.Xu@fpt.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@antheas.dev \
    --cc=matthew.schwartz@linux.dev \
    --cc=shenghao-ding@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.